detached bcb6f23

fix(ux): auto-select single AMD P-State mode and remove bootloader message

commit
bcb6f2304e267e7eed0f4ce7f791599e330bf957
author
bnema · · 2025-10-20 16:54 UTC
committer
bnema · · 2025-10-20 17:33 UTC
parent
62c7657
signature
unsigned
3 files · +4 -6
M CHANGELOG.md +1 -0
@@ -12,6 +12,7 @@ All notable changes to this project will be documented in this file.
1212 ### Fixed
1313 - **Limine bootloader**: Fixed kernel panic with non-default kernels (cachyos, zen, lts)
1414 - **AMD P-State selection**: Auto-select when only one mode available
15+- **Bootloader message**: Removed unnecessary Limine message since no choice exists
1516 - **Curl-pipe installation**: Fixed curl-based one-liner installation by auto-detecting piped input, re-executing with TTY for interactive prompts, and running bootstrap before downloads
1617 - **Cleanup flag**: Fixed --cleanup flag to run after helper files are downloaded
1718 - **Verification script**: Disabled ERR trap during verification to properly show all failures and prompt user, use dynamic kernel name instead of hardcoded linux, made fallback initramfs optional
@@ -12,6 +12,7 @@ All notable changes to this project will be documented in this file.
12 ### Fixed12 ### Fixed
13 - **Limine bootloader**: Fixed kernel panic with non-default kernels (cachyos, zen, lts)13 - **Limine bootloader**: Fixed kernel panic with non-default kernels (cachyos, zen, lts)
14 - **AMD P-State selection**: Auto-select when only one mode available14 - **AMD P-State selection**: Auto-select when only one mode available
15+- **Bootloader message**: Removed unnecessary Limine message since no choice exists
15 - **Curl-pipe installation**: Fixed curl-based one-liner installation by auto-detecting piped input, re-executing with TTY for interactive prompts, and running bootstrap before downloads16 - **Curl-pipe installation**: Fixed curl-based one-liner installation by auto-detecting piped input, re-executing with TTY for interactive prompts, and running bootstrap before downloads
16 - **Cleanup flag**: Fixed --cleanup flag to run after helper files are downloaded17 - **Cleanup flag**: Fixed --cleanup flag to run after helper files are downloaded
17 - **Verification script**: Disabled ERR trap during verification to properly show all failures and prompt user, use dynamic kernel name instead of hardcoded linux, made fallback initramfs optional18 - **Verification script**: Disabled ERR trap during verification to properly show all failures and prompt user, use dynamic kernel name instead of hardcoded linux, made fallback initramfs optional
M install/base/kernel.sh +3 -3
@@ -78,8 +78,8 @@ if [ "$CPU_TYPE" = "AMD" ]; then
7878 fi
7979 fi
8080
81- # Remove duplicates and sort
82- mapfile -t AVAILABLE_MODES < <(printf '%s\n' "${AVAILABLE_MODES[@]}" | sort -u)
81+ # Remove duplicates and sort, filter out empty strings
82+ mapfile -t AVAILABLE_MODES < <(printf '%s\n' "${AVAILABLE_MODES[@]}" | grep -v '^$' | sort -u)
8383
8484 # Display detected modes
8585 if [ ${#AVAILABLE_MODES[@]} -gt 0 ]; then
@@ -90,7 +90,7 @@ if [ "$CPU_TYPE" = "AMD" ]; then
9090 fi
9191
9292 # Auto-select if only one mode available, otherwise prompt user
93- if [ ${#AVAILABLE_MODES[@]} -eq 1 ]; then
93+ if [[ ${#AVAILABLE_MODES[@]} -eq 1 ]]; then
9494 AMD_PSTATE="${AVAILABLE_MODES[0]}"
9595 gum style --foreground 2 --padding "1 0 0 $PADDING_LEFT" "[OK] Auto-selected: $AMD_PSTATE (only available mode)"
9696 else
@@ -78,8 +78,8 @@ if [ "$CPU_TYPE" = "AMD" ]; then
78 fi78 fi
79 fi79 fi
80 80
81- # Remove duplicates and sort81+ # Remove duplicates and sort, filter out empty strings
82- mapfile -t AVAILABLE_MODES < <(printf '%s\n' "${AVAILABLE_MODES[@]}" | sort -u)82+ mapfile -t AVAILABLE_MODES < <(printf '%s\n' "${AVAILABLE_MODES[@]}" | grep -v '^$' | sort -u)
83 83
84 # Display detected modes84 # Display detected modes
85 if [ ${#AVAILABLE_MODES[@]} -gt 0 ]; then85 if [ ${#AVAILABLE_MODES[@]} -gt 0 ]; then
@@ -90,7 +90,7 @@ if [ "$CPU_TYPE" = "AMD" ]; then
90 fi90 fi
91 91
92 # Auto-select if only one mode available, otherwise prompt user92 # Auto-select if only one mode available, otherwise prompt user
93- if [ ${#AVAILABLE_MODES[@]} -eq 1 ]; then93+ if [[ ${#AVAILABLE_MODES[@]} -eq 1 ]]; then
94 AMD_PSTATE="${AVAILABLE_MODES[0]}"94 AMD_PSTATE="${AVAILABLE_MODES[0]}"
95 gum style --foreground 2 --padding "1 0 0 $PADDING_LEFT" "[OK] Auto-selected: $AMD_PSTATE (only available mode)"95 gum style --foreground 2 --padding "1 0 0 $PADDING_LEFT" "[OK] Auto-selected: $AMD_PSTATE (only available mode)"
96 else96 else
M install/preflight/begin.sh +0 -3
@@ -15,9 +15,6 @@ if ! gum confirm "Ready to begin installation?" --padding "0 0 1 $PADDING_LEFT";
1515 fi
1616
1717 # ArchUp uses Limine bootloader exclusively
18-gum style --foreground 6 --padding "1 0 0 $PADDING_LEFT" "Bootloader: Limine"
19-gum style --padding "0 0 1 $PADDING_LEFT" "ArchUp uses Limine for superior btrfs and snapshot support"
20-
2118 export ARCHUP_BOOTLOADER="limine"
2219 config_set "ARCHUP_BOOTLOADER" "limine"
2320 echo "Bootloader: limine" >> "$ARCHUP_INSTALL_LOG_FILE"
@@ -15,9 +15,6 @@ if ! gum confirm "Ready to begin installation?" --padding "0 0 1 $PADDING_LEFT";
15 fi15 fi
16 16
17 # ArchUp uses Limine bootloader exclusively17 # ArchUp uses Limine bootloader exclusively
18-gum style --foreground 6 --padding "1 0 0 $PADDING_LEFT" "Bootloader: Limine"
19-gum style --padding "0 0 1 $PADDING_LEFT" "ArchUp uses Limine for superior btrfs and snapshot support"
20-
21 export ARCHUP_BOOTLOADER="limine"18 export ARCHUP_BOOTLOADER="limine"
22 config_set "ARCHUP_BOOTLOADER" "limine"19 config_set "ARCHUP_BOOTLOADER" "limine"
23 echo "Bootloader: limine" >> "$ARCHUP_INSTALL_LOG_FILE"20 echo "Bootloader: limine" >> "$ARCHUP_INSTALL_LOG_FILE"

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 1

Tags 0

    ↑↓ moveenter openesc close