detached 04c1bf8

test(cef): require effective mapped ancestor visibility

commit
04c1bf88e96bf6f8fd9387520c43d52cd8e65674
author
brice · · 2026-07-14 07:16 UTC
committer
brice · · 2026-07-14 09:32 UTC
parent
ca9c392
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +19 -0
M internal/infrastructure/cef/webview_visibility_test.go +19 -0
@@ -6,6 +6,25 @@ import (
66 "github.com/stretchr/testify/require"
77 )
88
9+func TestEffectiveViewportVisibilityRequiresMappedVisibleAncestors(t *testing.T) {
10+ tests := []struct {
11+ name string
12+ states []viewportWidgetVisibility
13+ visible bool
14+ }{
15+ {name: "mapped visible widget", states: []viewportWidgetVisibility{{visible: true, mapped: true}}, visible: true},
16+ {name: "unmapped widget", states: []viewportWidgetVisibility{{visible: true, mapped: false}}},
17+ {name: "hidden widget", states: []viewportWidgetVisibility{{visible: false, mapped: true}}},
18+ {name: "hidden ancestor", states: []viewportWidgetVisibility{{visible: true, mapped: true}, {visible: false, mapped: true}}},
19+ {name: "unmapped ancestor", states: []viewportWidgetVisibility{{visible: true, mapped: true}, {visible: true, mapped: false}}},
20+ }
21+ for _, tt := range tests {
22+ t.Run(tt.name, func(t *testing.T) {
23+ require.Equal(t, tt.visible, effectiveViewportVisibility(tt.states))
24+ })
25+ }
26+}
27+
928 func TestWebViewEffectiveVisibilitySendsInitialStateAndDeduplicatesTransitions(t *testing.T) {
1029 host := &viewportSyncOrderHost{}
1130 wv := &WebView{}
@@ -6,6 +6,25 @@ import (
6 "github.com/stretchr/testify/require"6 "github.com/stretchr/testify/require"
7 )7 )
8 8
9+func TestEffectiveViewportVisibilityRequiresMappedVisibleAncestors(t *testing.T) {
10+ tests := []struct {
11+ name string
12+ states []viewportWidgetVisibility
13+ visible bool
14+ }{
15+ {name: "mapped visible widget", states: []viewportWidgetVisibility{{visible: true, mapped: true}}, visible: true},
16+ {name: "unmapped widget", states: []viewportWidgetVisibility{{visible: true, mapped: false}}},
17+ {name: "hidden widget", states: []viewportWidgetVisibility{{visible: false, mapped: true}}},
18+ {name: "hidden ancestor", states: []viewportWidgetVisibility{{visible: true, mapped: true}, {visible: false, mapped: true}}},
19+ {name: "unmapped ancestor", states: []viewportWidgetVisibility{{visible: true, mapped: true}, {visible: true, mapped: false}}},
20+ }
21+ for _, tt := range tests {
22+ t.Run(tt.name, func(t *testing.T) {
23+ require.Equal(t, tt.visible, effectiveViewportVisibility(tt.states))
24+ })
25+ }
26+}
27+
9 func TestWebViewEffectiveVisibilitySendsInitialStateAndDeduplicatesTransitions(t *testing.T) {28 func TestWebViewEffectiveVisibilitySendsInitialStateAndDeduplicatesTransitions(t *testing.T) {
10 host := &viewportSyncOrderHost{}29 host := &viewportSyncOrderHost{}
11 wv := &WebView{}30 wv := &WebView{}

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close