detached 08a887b

refactor(workspace): add ClearRootWidgetRef for incremental operations

Add ClearRootWidgetRef() method to WorkspaceView for safe root widget
reference clearing during incremental split/close operations.

This enables incremental widget operations (doIncrementalSplit,
doIncrementalClose, doIncrementalStackClose) to reuse existing widgets
and promote siblings without full tree reconstruction, preventing
WebView corruption that occurred during complex split sequences.
commit
08a887b0051b1fd3dc666f0ff2a714ab606ad5de
author
brice · · 2025-12-15 17:14 UTC
committer
brice · · 2025-12-15 19:25 UTC
parent
2912397
signature
unsigned
1 file · +9 -0
Unified
UnifiedSplit
M internal/ui/component/workspace_view.go +9 -0
@@ -331,6 +331,15 @@ func (wv *WorkspaceView) SetRootWidgetDirect(widget layout.Widget) {
331331 wv.rootWidget = widget
332332 }
333333
334+// ClearRootWidgetRef clears the stored root widget reference without removing it.
335+// Use this before SetRootWidgetDirect when the old root has already been removed
336+// through other means (e.g., GTK paned operations).
337+func (wv *WorkspaceView) ClearRootWidgetRef() {
338+ wv.mu.Lock()
339+ defer wv.mu.Unlock()
340+ wv.rootWidget = nil
341+}
342+
334343 // Factory returns the widget factory used by this workspace view.
335344 func (wv *WorkspaceView) Factory() layout.WidgetFactory {
336345 return wv.factory
@@ -331,6 +331,15 @@ func (wv *WorkspaceView) SetRootWidgetDirect(widget layout.Widget) {
331 wv.rootWidget = widget331 wv.rootWidget = widget
332 }332 }
333 333
334+// ClearRootWidgetRef clears the stored root widget reference without removing it.
335+// Use this before SetRootWidgetDirect when the old root has already been removed
336+// through other means (e.g., GTK paned operations).
337+func (wv *WorkspaceView) ClearRootWidgetRef() {
338+ wv.mu.Lock()
339+ defer wv.mu.Unlock()
340+ wv.rootWidget = nil
341+}
342+
334 // Factory returns the widget factory used by this workspace view.343 // Factory returns the widget factory used by this workspace view.
335 func (wv *WorkspaceView) Factory() layout.WidgetFactory {344 func (wv *WorkspaceView) Factory() layout.WidgetFactory {
336 return wv.factory345 return wv.factory

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close