detached 12a6535

fix(css): remove duplicate focus styling and fix omnibox container rendering

commit
12a6535d16ed9c7c3cb533a749cdf0802f0c4c1a
author
bnema · · 2025-12-16 21:41 UTC
parent
75c1a27
signature
unsigned
1 file · +20 -8
M internal/ui/theme/css.go +20 -8
@@ -109,17 +109,17 @@ button.tab-button.tab-button-active {
109109 func generateOmniboxCSS(p Palette) string {
110110 return `/* ===== Omnibox Styling ===== */
111111
112-/* Omnibox window - floating popup */
113-window.omnibox-window {
114- background-color: var(--surface-variant);
115- border: 0.0625em solid var(--border);
116- border-radius: 0.1875em;
112+/* Omnibox outer container - for positioning in overlay */
113+.omnibox-outer {
114+ /* Positioning is handled via SetHalign/SetValign/SetMarginTop in Go */
117115 }
118116
119-/* Main container */
117+/* Omnibox main container - the visible popup */
120118 .omnibox-container {
119+ background-color: var(--surface-variant);
120+ border: 0.0625em solid var(--border);
121+ border-radius: 0.1875em;
121122 padding: 0;
122- background-color: transparent;
123123 }
124124
125125 /* Header with History/Favorites toggle */
@@ -165,9 +165,21 @@ window.omnibox-window {
165165 caret-color: var(--accent);
166166 }
167167
168-.omnibox-entry:focus {
168+entry.omnibox-entry:focus,
169+entry.omnibox-entry:focus-within,
170+entry.omnibox-entry:focus-visible {
169171 border-color: var(--accent);
170172 background-color: shade(var(--bg), 1.05);
173+ outline-style: none;
174+ outline-width: 0;
175+ outline-color: transparent;
176+}
177+
178+/* Override any internal focus styling */
179+entry.omnibox-entry > *:focus,
180+entry.omnibox-entry > *:focus-visible {
181+ outline-style: none;
182+ outline-color: transparent;
171183 }
172184
173185 /* Scrolled window for suggestions */
@@ -109,17 +109,17 @@ button.tab-button.tab-button-active {
109 func generateOmniboxCSS(p Palette) string {109 func generateOmniboxCSS(p Palette) string {
110 return `/* ===== Omnibox Styling ===== */110 return `/* ===== Omnibox Styling ===== */
111 111
112-/* Omnibox window - floating popup */112+/* Omnibox outer container - for positioning in overlay */
113-window.omnibox-window {113+.omnibox-outer {
114- background-color: var(--surface-variant);114+ /* Positioning is handled via SetHalign/SetValign/SetMarginTop in Go */
115- border: 0.0625em solid var(--border);
116- border-radius: 0.1875em;
117 }115 }
118 116
119-/* Main container */117+/* Omnibox main container - the visible popup */
120 .omnibox-container {118 .omnibox-container {
119+ background-color: var(--surface-variant);
120+ border: 0.0625em solid var(--border);
121+ border-radius: 0.1875em;
121 padding: 0;122 padding: 0;
122- background-color: transparent;
123 }123 }
124 124
125 /* Header with History/Favorites toggle */125 /* Header with History/Favorites toggle */
@@ -165,9 +165,21 @@ window.omnibox-window {
165 caret-color: var(--accent);165 caret-color: var(--accent);
166 }166 }
167 167
168-.omnibox-entry:focus {168+entry.omnibox-entry:focus,
169+entry.omnibox-entry:focus-within,
170+entry.omnibox-entry:focus-visible {
169 border-color: var(--accent);171 border-color: var(--accent);
170 background-color: shade(var(--bg), 1.05);172 background-color: shade(var(--bg), 1.05);
173+ outline-style: none;
174+ outline-width: 0;
175+ outline-color: transparent;
176+}
177+
178+/* Override any internal focus styling */
179+entry.omnibox-entry > *:focus,
180+entry.omnibox-entry > *:focus-visible {
181+ outline-style: none;
182+ outline-color: transparent;
171 }183 }
172 184
173 /* Scrolled window for suggestions */185 /* Scrolled window for suggestions */

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close