detached 17ea0b8

fix(input): release unrealized shortcut test window without destroy (#419)

commit
17ea0b87459603167954526cd74383a171a863ae
author
bnema · · 2026-09-09 05:59 UTC
committer
GitHub · · 2026-09-09 05:59 UTC
parent
461ba10
signature
GPG UnverifiedB5690EEEBB952194 The key is unknown
1 file · +6 -1
M internal/ui/input/global_shortcuts_test.go +6 -1
@@ -82,7 +82,12 @@ func TestGlobalShortcutHandlerUsesDistinctNamedActionsAcrossReloads(t *testing.T
8282 }
8383 t.Cleanup(func() {
8484 h.Detach()
85- window.Destroy()
85+ // The test window is never presented, so it has no Wayland surface.
86+ // gtk_window_destroy on such an unrealized window segfaults on the
87+ // Wayland backend (gdk_surface_get_display assertion). Release the
88+ // initial reference instead, matching the unrealized-window paths in
89+ // window.New/PopupWindow. Destroy remains correct for shown windows.
90+ window.Unref()
8691 app.Unref()
8792 })
8893
@@ -82,7 +82,12 @@ func TestGlobalShortcutHandlerUsesDistinctNamedActionsAcrossReloads(t *testing.T
82 }82 }
83 t.Cleanup(func() {83 t.Cleanup(func() {
84 h.Detach()84 h.Detach()
85- window.Destroy()85+ // The test window is never presented, so it has no Wayland surface.
86+ // gtk_window_destroy on such an unrealized window segfaults on the
87+ // Wayland backend (gdk_surface_get_display assertion). Release the
88+ // initial reference instead, matching the unrealized-window paths in
89+ // window.New/PopupWindow. Destroy remains correct for shown windows.
90+ window.Unref()
86 app.Unref()91 app.Unref()
87 })92 })
88 93

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close