fix(messaging): add error handling for omnibox InjectScript

Check and log errors when injecting suggestions instead of silently ignoring.
Fixes linter errcheck warning while maintaining KISS (only logs actual errors).

commit: 3c46dee192478cb6732b9456c3187bdd04b45b3a
author: bnema · 12mo ago · 2025-10-24 05:54 UTC
committer: bnema · 12mo ago · 2025-10-24 17:33 UTC
parent: 01f94b7
signature: unsigned

1 file · +3 -1

M internal/app/messaging/handler.go +3 -1


@@ -261,7 +261,9 @@ func (h *Handler) handleQuery(msg Message) {
261	261		if b, err := json.Marshal(results); err == nil {
262	262		// Prefer unified page-world API; fallback to legacy global function
263	263		script := "(window.__dumber?.omnibox?.suggestions ? window.__dumber.omnibox.suggestions(" + string(b) + ") : (window.__dumber_omnibox_suggestions && window.__dumber_omnibox_suggestions(" + string(b) + ")))"
264		-	h.webView.InjectScript(script)
	264	+	if err := h.webView.InjectScript(script); err != nil {
	265	+	log.Printf("[ERROR] Failed to inject omnibox suggestions: %v", err)
	266	+	}
265	267		}
266	268		}
267	269

 	if b, err := json.Marshal(results); err == nil {
 		// Prefer unified page-world API; fallback to legacy global function
 		script := "(window.__dumber?.omnibox?.suggestions ? window.__dumber.omnibox.suggestions(" + string(b) + ") : (window.__dumber_omnibox_suggestions && window.__dumber_omnibox_suggestions(" + string(b) + ")))"
-		h.webView.InjectScript(script)
+		if err := h.webView.InjectScript(script); err != nil {
+			log.Printf("[ERROR] Failed to inject omnibox suggestions: %v", err)
+		}
 	}
 }