fix(ci): add caching and 20m timeout for CGO lint
- commit
- 495f8d70ada3113d0ed544bb590a97df2d34b843
- author
- bnema · · 2025-11-30 04:33 UTC
- parent
- 920e9ed
- signature
- unsigned
3 files · +9 -8
M .github/workflows/ci.yml +5 -6
| @@ -16,19 +16,17 @@ jobs: | |||
| 16 | 16 | - uses: actions/setup-go@v6 | |
| 17 | 17 | with: | |
| 18 | 18 | go-version: stable | |
| 19 | - | - uses: actions/setup-node@v6 | |
| 20 | - | with: | |
| 21 | - | node-version: '24' | |
| 19 | + | cache: true | |
| 22 | 20 | - name: Install WebKitGTK 6.0 dependencies | |
| 23 | 21 | run: | | |
| 24 | 22 | sudo apt-get update | |
| 25 | 23 | sudo apt-get install -y libwebkitgtk-6.0-dev libgtk-4-dev libgirepository1.0-dev | |
| 26 | - | - name: Build frontend assets | |
| 27 | - | run: make build-frontend | |
| 28 | 24 | - name: Run golangci-lint | |
| 29 | 25 | uses: golangci/golangci-lint-action@v7 | |
| 30 | 26 | with: | |
| 31 | - | version: v2.4 | |
| 27 | + | version: v2.6.2 | |
| 28 | + | skip-cache: false | |
| 29 | + | args: --timeout=20m | |
| 32 | 30 | ||
| 33 | 31 | test: | |
| 34 | 32 | runs-on: ubuntu-latest | |
| @@ -37,6 +35,7 @@ jobs: | |||
| 37 | 35 | - uses: actions/setup-go@v6 | |
| 38 | 36 | with: | |
| 39 | 37 | go-version: stable | |
| 38 | + | cache: true | |
| 40 | 39 | - uses: actions/setup-node@v6 | |
| 41 | 40 | with: | |
| 42 | 41 | node-version: '24' | |
| @@ -16,19 +16,17 @@ jobs: | |||||
| 16 | - uses: actions/setup-go@v6 | 16 | - uses: actions/setup-go@v6 | ||
| 17 | with: | 17 | with: | ||
| 18 | go-version: stable | 18 | go-version: stable | ||
| 19 | - | - uses: actions/setup-node@v6 | 19 | + | cache: true |
| 20 | - | with: | |||
| 21 | - | node-version: '24' | |||
| 22 | - name: Install WebKitGTK 6.0 dependencies | 20 | - name: Install WebKitGTK 6.0 dependencies | ||
| 23 | run: | | 21 | run: | | ||
| 24 | sudo apt-get update | 22 | sudo apt-get update | ||
| 25 | sudo apt-get install -y libwebkitgtk-6.0-dev libgtk-4-dev libgirepository1.0-dev | 23 | sudo apt-get install -y libwebkitgtk-6.0-dev libgtk-4-dev libgirepository1.0-dev | ||
| 26 | - | - name: Build frontend assets | |||
| 27 | - | run: make build-frontend | |||
| 28 | - name: Run golangci-lint | 24 | - name: Run golangci-lint | ||
| 29 | uses: golangci/golangci-lint-action@v7 | 25 | uses: golangci/golangci-lint-action@v7 | ||
| 30 | with: | 26 | with: | ||
| 31 | - | version: v2.4 | 27 | + | version: v2.6.2 |
| 28 | + | skip-cache: false | |||
| 29 | + | args: --timeout=20m | |||
| 32 | 30 | ||||
| 33 | test: | 31 | test: | ||
| 34 | runs-on: ubuntu-latest | 32 | runs-on: ubuntu-latest | ||
| @@ -37,6 +35,7 @@ jobs: | |||||
| 37 | - uses: actions/setup-go@v6 | 35 | - uses: actions/setup-go@v6 | ||
| 38 | with: | 36 | with: | ||
| 39 | go-version: stable | 37 | go-version: stable | ||
| 38 | + | cache: true | |||
| 40 | - uses: actions/setup-node@v6 | 39 | - uses: actions/setup-node@v6 | ||
| 41 | with: | 40 | with: | ||
| 42 | node-version: '24' | 41 | node-version: '24' | ||
M .golangci.yml +3 -1
| @@ -95,6 +95,8 @@ linters: | |||
| 95 | 95 | ||
| 96 | 96 | exclusions: | |
| 97 | 97 | generated: lax | |
| 98 | + | paths: | |
| 99 | + | - vendor | |
| 98 | 100 | rules: | |
| 99 | 101 | - path: _test\.go | |
| 100 | 102 | linters: | |
| @@ -113,7 +115,7 @@ linters: | |||
| 113 | 115 | - lll | |
| 114 | 116 | ||
| 115 | 117 | run: | |
| 116 | - | timeout: 5m | |
| 118 | + | timeout: 20m | |
| 117 | 119 | modules-download-mode: readonly | |
| 118 | 120 | build-tags: | |
| 119 | 121 | - webkit_cgo | |
| @@ -95,6 +95,8 @@ linters: | |||||
| 95 | 95 | ||||
| 96 | exclusions: | 96 | exclusions: | ||
| 97 | generated: lax | 97 | generated: lax | ||
| 98 | + | paths: | |||
| 99 | + | - vendor | |||
| 98 | rules: | 100 | rules: | ||
| 99 | - path: _test\.go | 101 | - path: _test\.go | ||
| 100 | linters: | 102 | linters: | ||
| @@ -113,7 +115,7 @@ linters: | |||||
| 113 | - lll | 115 | - lll | ||
| 114 | 116 | ||||
| 115 | run: | 117 | run: | ||
| 116 | - | timeout: 5m | 118 | + | timeout: 20m |
| 117 | modules-download-mode: readonly | 119 | modules-download-mode: readonly | ||
| 118 | build-tags: | 120 | build-tags: | ||
| 119 | - webkit_cgo | 121 | - webkit_cgo | ||
M Makefile +1 -1
| @@ -97,7 +97,7 @@ test-race: ## Run tests with race detection | |||
| 97 | 97 | $(GOENV) CGO_ENABLED=1 go test -race -v ./... | |
| 98 | 98 | ||
| 99 | 99 | # Linting | |
| 100 | - | lint: ## Run golangci-lint | |
| 100 | + | lint: ## Run golangci-lint (excludes pkg/webkit CGO files via config) | |
| 101 | 101 | @echo "Running golangci-lint..." | |
| 102 | 102 | golangci-lint run | |
| 103 | 103 | ||
| @@ -97,7 +97,7 @@ test-race: ## Run tests with race detection | |||||
| 97 | $(GOENV) CGO_ENABLED=1 go test -race -v ./... | 97 | $(GOENV) CGO_ENABLED=1 go test -race -v ./... | ||
| 98 | 98 | ||||
| 99 | # Linting | 99 | # Linting | ||
| 100 | - | lint: ## Run golangci-lint | 100 | + | lint: ## Run golangci-lint (excludes pkg/webkit CGO files via config) |
| 101 | @echo "Running golangci-lint..." | 101 | @echo "Running golangci-lint..." | ||
| 102 | golangci-lint run | 102 | golangci-lint run | ||
| 103 | 103 | ||||