detached 5e1311a

fix(build): quote GOFLAGS and order verify after wasm build (#435)

Unquoted GOFLAGS splits multi-flag values (e.g. AUR's
'-trimpath -mod=readonly -modcacherw') into a broken command, failing
dumber-browser-git builds with '-mod=readonly: command not found'.

Ordering verify-systemviews-assets after build-systemviews removes the
parallel-make race where verification ran before the manifest/wasm
artifacts existed.
commit
5e1311a5c259ae2dd0841ec428491d41f3caed11
author
bnema · · 2026-09-13 19:40 UTC
committer
GitHub · · 2026-09-13 19:40 UTC
parent
813f329
signature
GPG UnverifiedB5690EEEBB952194 The key is unknown
1 file · +2 -2
M Makefile +2 -2
@@ -154,9 +154,9 @@ verify-generated: ## Verify tracked generated systemviews artifacts are committe
154154 exit 1; \
155155 }
156156
157-verify-systemviews-assets: ## Verify release embeds a compressed systemviews WASM asset
157+verify-systemviews-assets: build-systemviews ## Verify release embeds a compressed systemviews WASM asset
158158 @echo "Verifying embedded systemviews WASM asset..."
159- DUMBER_REQUIRE_SYSTEMVIEWS_WASM=1 GOFLAGS=$(GOFLAGS) go test -count=1 -run 'TestWebUIAssetsIncludesCompressedSystemviewsWASM|TestAssetManifestMatchesEmbeddedArtifacts' ./assets
159+ DUMBER_REQUIRE_SYSTEMVIEWS_WASM=1 GOFLAGS="$(GOFLAGS)" go test -count=1 -run 'TestWebUIAssetsIncludesCompressedSystemviewsWASM|TestAssetManifestMatchesEmbeddedArtifacts' ./assets
160160 go run ./cmd/systemviews-assets -check -dir assets/systemviews
161161
162162 # Linting
@@ -154,9 +154,9 @@ verify-generated: ## Verify tracked generated systemviews artifacts are committe
154 exit 1; \154 exit 1; \
155 }155 }
156 156
157-verify-systemviews-assets: ## Verify release embeds a compressed systemviews WASM asset157+verify-systemviews-assets: build-systemviews ## Verify release embeds a compressed systemviews WASM asset
158 @echo "Verifying embedded systemviews WASM asset..."158 @echo "Verifying embedded systemviews WASM asset..."
159- DUMBER_REQUIRE_SYSTEMVIEWS_WASM=1 GOFLAGS=$(GOFLAGS) go test -count=1 -run 'TestWebUIAssetsIncludesCompressedSystemviewsWASM|TestAssetManifestMatchesEmbeddedArtifacts' ./assets159+ DUMBER_REQUIRE_SYSTEMVIEWS_WASM=1 GOFLAGS="$(GOFLAGS)" go test -count=1 -run 'TestWebUIAssetsIncludesCompressedSystemviewsWASM|TestAssetManifestMatchesEmbeddedArtifacts' ./assets
160 go run ./cmd/systemviews-assets -check -dir assets/systemviews160 go run ./cmd/systemviews-assets -check -dir assets/systemviews
161 161
162 # Linting162 # Linting

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close