fix(build): quote GOFLAGS and order verify after wasm build (#435)
Unquoted GOFLAGS splits multi-flag values (e.g. AUR's '-trimpath -mod=readonly -modcacherw') into a broken command, failing dumber-browser-git builds with '-mod=readonly: command not found'. Ordering verify-systemviews-assets after build-systemviews removes the parallel-make race where verification ran before the manifest/wasm artifacts existed.
- commit
- 5e1311a5c259ae2dd0841ec428491d41f3caed11
- author
- bnema · · 2026-09-13 19:40 UTC
- committer
- GitHub · · 2026-09-13 19:40 UTC
- parent
- 813f329
- signature
- GPG Unverified
B5690EEEBB952194The key is unknown
1 file · +2 -2
M Makefile +2 -2
| @@ -154,9 +154,9 @@ verify-generated: ## Verify tracked generated systemviews artifacts are committe | |||
| 154 | 154 | exit 1; \ | |
| 155 | 155 | } | |
| 156 | 156 | ||
| 157 | - | verify-systemviews-assets: ## Verify release embeds a compressed systemviews WASM asset | |
| 157 | + | verify-systemviews-assets: build-systemviews ## Verify release embeds a compressed systemviews WASM asset | |
| 158 | 158 | @echo "Verifying embedded systemviews WASM asset..." | |
| 159 | - | DUMBER_REQUIRE_SYSTEMVIEWS_WASM=1 GOFLAGS=$(GOFLAGS) go test -count=1 -run 'TestWebUIAssetsIncludesCompressedSystemviewsWASM|TestAssetManifestMatchesEmbeddedArtifacts' ./assets | |
| 159 | + | DUMBER_REQUIRE_SYSTEMVIEWS_WASM=1 GOFLAGS="$(GOFLAGS)" go test -count=1 -run 'TestWebUIAssetsIncludesCompressedSystemviewsWASM|TestAssetManifestMatchesEmbeddedArtifacts' ./assets | |
| 160 | 160 | go run ./cmd/systemviews-assets -check -dir assets/systemviews | |
| 161 | 161 | ||
| 162 | 162 | # Linting | |
| @@ -154,9 +154,9 @@ verify-generated: ## Verify tracked generated systemviews artifacts are committe | |||||
| 154 | exit 1; \ | 154 | exit 1; \ | ||
| 155 | } | 155 | } | ||
| 156 | 156 | ||||
| 157 | - | verify-systemviews-assets: ## Verify release embeds a compressed systemviews WASM asset | 157 | + | verify-systemviews-assets: build-systemviews ## Verify release embeds a compressed systemviews WASM asset |
| 158 | @echo "Verifying embedded systemviews WASM asset..." | 158 | @echo "Verifying embedded systemviews WASM asset..." | ||
| 159 | - | DUMBER_REQUIRE_SYSTEMVIEWS_WASM=1 GOFLAGS=$(GOFLAGS) go test -count=1 -run 'TestWebUIAssetsIncludesCompressedSystemviewsWASM|TestAssetManifestMatchesEmbeddedArtifacts' ./assets | 159 | + | DUMBER_REQUIRE_SYSTEMVIEWS_WASM=1 GOFLAGS="$(GOFLAGS)" go test -count=1 -run 'TestWebUIAssetsIncludesCompressedSystemviewsWASM|TestAssetManifestMatchesEmbeddedArtifacts' ./assets |
| 160 | go run ./cmd/systemviews-assets -check -dir assets/systemviews | 160 | go run ./cmd/systemviews-assets -check -dir assets/systemviews | ||
| 161 | 161 | ||||
| 162 | # Linting | 162 | # Linting | ||