fix: cap fallback visit increment loop in LazyHistoryRepository

Defense-in-depth: cap the single-increment fallback loop at 256
iterations to prevent unbounded DB writes if delta is unexpectedly
large, matching the cap already applied by the usecase caller.

commit: 6a4247940d44bc79b20f6f17001deb466be8eee7
author: brice · 8mo ago · 2026-02-07 10:56 UTC
parent: 36ecc6b
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +7 -1

M internal/infrastructure/persistence/sqlite/lazy_repos.go +7 -1


@@ -127,7 +127,13 @@ func (r *LazyHistoryRepository) IncrementVisitCountBy(ctx context.Context, url s
127	127		}); ok {
128	128		return deltaRepo.IncrementVisitCountBy(ctx, url, delta)
129	129		}
130		-	for i := 0; i < delta; i++ {
	130	+	// Cap the fallback loop to avoid unbounded DB writes if delta is unexpectedly large.
	131	+	const fallbackCap = 256
	132	+	iterations := delta
	133	+	if iterations > fallbackCap {
	134	+	iterations = fallbackCap
	135	+	}
	136	+	for i := 0; i < iterations; i++ {
131	137		if err := r.repo.IncrementVisitCount(ctx, url); err != nil {
132	138		return err
133	139		}

 	}); ok {
 		return deltaRepo.IncrementVisitCountBy(ctx, url, delta)
 	}
-	for i := 0; i < delta; i++ {
+	// Cap the fallback loop to avoid unbounded DB writes if delta is unexpectedly large.
+	const fallbackCap = 256
+	iterations := delta
+	if iterations > fallbackCap {
+		iterations = fallbackCap
+	}
+	for i := 0; i < iterations; i++ {
 		if err := r.repo.IncrementVisitCount(ctx, url); err != nil {
 			return err
 		}