fix(focus): prevent duplicate GTK focus events with propagation phase

Set event controller propagation phase to GTK_PHASE_TARGET to receive
events only for the specific widget, not bubbled events from parent
widgets in the hierarchy.

This eliminates redundant focus state changes that were causing log spam
when focus events propagated through the widget tree.

commit: 78194acabd16a140ad553633a56eb9c27530c87a
author: bamen · 12mo ago · 2025-10-12 11:10 UTC
parent: 7d34df7
signature: unsigned

1 file · +4 -0

M internal/app/browser/focus_state_machine.go +4 -0


@@ -928,6 +928,10 @@ func (fsm FocusStateMachine) attachGTKController(node paneNode) {
928	928		// Create focus controller for GTK4
929	929		controller := gtk.NewEventControllerFocus()
930	930
	931	+	// Set propagation phase to TARGET only to avoid duplicate events from parent widgets
	932	+	// GTK_PHASE_TARGET means we only get events for this specific widget, not bubbled events
	933	+	controller.SetPropagationPhase(gtk.PhaseTarget)
	934	+
931	935		// Connect focus enter/leave callbacks for this specific node
932	936		controller.ConnectEnter(func() {
933	937		log.Printf("[FSM] GTK focus enter: %p", node)


@@ -928,6 +928,10 @@ func (fsm FocusStateMachine) attachGTKController(node paneNode) {
928	// Create focus controller for GTK4	928		// Create focus controller for GTK4
929	controller := gtk.NewEventControllerFocus()	929		controller := gtk.NewEventControllerFocus()
930		930
		931	+	// Set propagation phase to TARGET only to avoid duplicate events from parent widgets
		932	+	// GTK_PHASE_TARGET means we only get events for this specific widget, not bubbled events
		933	+	controller.SetPropagationPhase(gtk.PhaseTarget)
		934	+
931	// Connect focus enter/leave callbacks for this specific node	935		// Connect focus enter/leave callbacks for this specific node
932	controller.ConnectEnter(func() {	936		controller.ConnectEnter(func() {
933	log.Printf("[FSM] GTK focus enter: %p", node)	937		log.Printf("[FSM] GTK focus enter: %p", node)