detached 7eb8e31

fix: check actual GTK buffer to detect user edits in ghost text

The stale input check based on realInput was insufficient because
realInput isn't updated until the debounced search-changed signal
fires. Reading the actual buffer content detects user edits that
happened between the search start and result delivery.
commit
7eb8e318707657359d4e090662508f55315bf233
author
brice · · 2026-03-27 19:31 UTC
parent
3a4e710
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +10 -6
M internal/ui/component/omnibox.go +10 -6
@@ -910,16 +910,20 @@ func (o *Omnibox) setGhostText(originalInput, suffix string) {
910910 return
911911 }
912912
913- // Verify the user hasn't typed since this ghost was computed.
913+ // Verify the buffer hasn't been modified by user typing since this ghost
914+ // was computed. We check the actual buffer — not realInput, which may be
915+ // stale due to debounced search-changed signal.
916+ currentBuffer := o.entry.GetText()
914917 o.mu.RLock()
915- currentInput := o.realInput
918+ existingGhost := o.ghostSuffix
916919 o.mu.RUnlock()
917- if currentInput != originalInput {
920+ expectedWithGhost := originalInput + existingGhost
921+ if currentBuffer != originalInput && currentBuffer != expectedWithGhost {
918922 log.Debug().
919- Str("staleInput", originalInput).
920- Str("currentInput", currentInput).
923+ Str("originalInput", originalInput).
924+ Str("currentBuffer", currentBuffer).
921925 Str("suffix", suffix).
922- Msg("ghost: setGhostText skipped (stale input)")
926+ Msg("ghost: setGhostText skipped (buffer modified by user)")
923927 return
924928 }
925929
@@ -910,16 +910,20 @@ func (o *Omnibox) setGhostText(originalInput, suffix string) {
910 return910 return
911 }911 }
912 912
913- // Verify the user hasn't typed since this ghost was computed.913+ // Verify the buffer hasn't been modified by user typing since this ghost
914+ // was computed. We check the actual buffer — not realInput, which may be
915+ // stale due to debounced search-changed signal.
916+ currentBuffer := o.entry.GetText()
914 o.mu.RLock()917 o.mu.RLock()
915- currentInput := o.realInput918+ existingGhost := o.ghostSuffix
916 o.mu.RUnlock()919 o.mu.RUnlock()
917- if currentInput != originalInput {920+ expectedWithGhost := originalInput + existingGhost
921+ if currentBuffer != originalInput && currentBuffer != expectedWithGhost {
918 log.Debug().922 log.Debug().
919- Str("staleInput", originalInput).923+ Str("originalInput", originalInput).
920- Str("currentInput", currentInput).924+ Str("currentBuffer", currentBuffer).
921 Str("suffix", suffix).925 Str("suffix", suffix).
922- Msg("ghost: setGhostText skipped (stale input)")926+ Msg("ghost: setGhostText skipped (buffer modified by user)")
923 return927 return
924 }928 }
925 929

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close