detached 82da5b8

test(tree): cover split cleanup ownership

commit
82da5b8ffb6ab283050b37be65d70e7da55b214f
author
brice · · 2026-07-14 06:21 UTC
committer
brice · · 2026-07-14 07:06 UTC
parent
5a776d4
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +48 -0
A internal/ui/layout/tree_cleanup_test.go +48 -0
@@ -0,0 +1,48 @@
1+package layout_test
2+
3+import (
4+ "context"
5+ "testing"
6+
7+ "github.com/bnema/dumber/internal/domain/entity"
8+ "github.com/bnema/dumber/internal/ui/layout"
9+ "github.com/bnema/dumber/internal/ui/layout/mocks"
10+ "github.com/stretchr/testify/mock"
11+ "github.com/stretchr/testify/require"
12+)
13+
14+func TestTreeRendererClearReleasesOwnedSplitTickExactlyOnce(t *testing.T) {
15+ ctx := context.Background()
16+ factory := mocks.NewMockWidgetFactory(t)
17+ paneFactory := mocks.NewMockPaneViewFactory(t)
18+ paned := mocks.NewMockPanedWidget(t)
19+ leftStack, leftContainer := setupStackedLeafMocks(t, factory)
20+ rightStack, rightContainer := setupStackedLeafMocks(t, factory)
21+
22+ left := &entity.PaneNode{ID: "left", Pane: entity.NewPane("left")}
23+ right := &entity.PaneNode{ID: "right", Pane: entity.NewPane("right")}
24+ root := &entity.PaneNode{ID: "split", SplitDir: entity.SplitHorizontal, SplitRatio: 0.5, Children: []*entity.PaneNode{left, right}}
25+
26+ paneFactory.EXPECT().CreatePaneView(left).Return(leftContainer).Once()
27+ paneFactory.EXPECT().CreatePaneView(right).Return(rightContainer).Once()
28+ factory.EXPECT().NewPaned(layout.OrientationHorizontal).Return(paned).Once()
29+ paned.EXPECT().SetResizeStartChild(true).Once()
30+ paned.EXPECT().SetResizeEndChild(true).Once()
31+ paned.EXPECT().SetVisible(true).Once()
32+ leftStack.EXPECT().SetVisible(true).Once()
33+ rightStack.EXPECT().SetVisible(true).Once()
34+ paned.EXPECT().SetStartChild(leftStack).Once()
35+ paned.EXPECT().SetEndChild(rightStack).Once()
36+ paned.EXPECT().ConnectNotifyPosition(mock.Anything).Return(uint(0)).Once()
37+ paned.EXPECT().GetAllocatedWidth().Return(0).Once()
38+ paned.EXPECT().ConnectMap(mock.Anything).Return(uint(0)).Once()
39+ paned.EXPECT().AddTickCallback(mock.Anything).Return(uint(42)).Once()
40+ paned.EXPECT().RemoveTickCallback(uint(42)).Once()
41+
42+ renderer := layout.NewTreeRenderer(ctx, factory, paneFactory)
43+ _, err := renderer.Build(ctx, root)
44+ require.NoError(t, err)
45+
46+ renderer.Clear()
47+ renderer.Clear()
48+}
@@ -0,0 +1,48 @@
1+package layout_test
2+
3+import (
4+ "context"
5+ "testing"
6+
7+ "github.com/bnema/dumber/internal/domain/entity"
8+ "github.com/bnema/dumber/internal/ui/layout"
9+ "github.com/bnema/dumber/internal/ui/layout/mocks"
10+ "github.com/stretchr/testify/mock"
11+ "github.com/stretchr/testify/require"
12+)
13+
14+func TestTreeRendererClearReleasesOwnedSplitTickExactlyOnce(t *testing.T) {
15+ ctx := context.Background()
16+ factory := mocks.NewMockWidgetFactory(t)
17+ paneFactory := mocks.NewMockPaneViewFactory(t)
18+ paned := mocks.NewMockPanedWidget(t)
19+ leftStack, leftContainer := setupStackedLeafMocks(t, factory)
20+ rightStack, rightContainer := setupStackedLeafMocks(t, factory)
21+
22+ left := &entity.PaneNode{ID: "left", Pane: entity.NewPane("left")}
23+ right := &entity.PaneNode{ID: "right", Pane: entity.NewPane("right")}
24+ root := &entity.PaneNode{ID: "split", SplitDir: entity.SplitHorizontal, SplitRatio: 0.5, Children: []*entity.PaneNode{left, right}}
25+
26+ paneFactory.EXPECT().CreatePaneView(left).Return(leftContainer).Once()
27+ paneFactory.EXPECT().CreatePaneView(right).Return(rightContainer).Once()
28+ factory.EXPECT().NewPaned(layout.OrientationHorizontal).Return(paned).Once()
29+ paned.EXPECT().SetResizeStartChild(true).Once()
30+ paned.EXPECT().SetResizeEndChild(true).Once()
31+ paned.EXPECT().SetVisible(true).Once()
32+ leftStack.EXPECT().SetVisible(true).Once()
33+ rightStack.EXPECT().SetVisible(true).Once()
34+ paned.EXPECT().SetStartChild(leftStack).Once()
35+ paned.EXPECT().SetEndChild(rightStack).Once()
36+ paned.EXPECT().ConnectNotifyPosition(mock.Anything).Return(uint(0)).Once()
37+ paned.EXPECT().GetAllocatedWidth().Return(0).Once()
38+ paned.EXPECT().ConnectMap(mock.Anything).Return(uint(0)).Once()
39+ paned.EXPECT().AddTickCallback(mock.Anything).Return(uint(42)).Once()
40+ paned.EXPECT().RemoveTickCallback(uint(42)).Once()
41+
42+ renderer := layout.NewTreeRenderer(ctx, factory, paneFactory)
43+ _, err := renderer.Build(ctx, root)
44+ require.NoError(t, err)
45+
46+ renderer.Clear()
47+ renderer.Clear()
48+}

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close