detached 89aeee6

fix: address copilot review comments on PR #51

commit
89aeee6bec2a08dbc416dea4827df332d540f982
author
brice · · 2025-12-28 08:41 UTC
parent
be07ce6
signature
unsigned
2 files · +93 -30
Unified
UnifiedSplit
A internal/application/usecase/manage_favorites_test.go +77 -0
@@ -0,0 +1,77 @@
1+package usecase_test
2+
3+import (
4+ "errors"
5+ "testing"
6+
7+ "github.com/bnema/dumber/internal/application/usecase"
8+ "github.com/bnema/dumber/internal/domain/entity"
9+ repomocks "github.com/bnema/dumber/internal/domain/repository/mocks"
10+ "github.com/stretchr/testify/assert"
11+ "github.com/stretchr/testify/mock"
12+ "github.com/stretchr/testify/require"
13+)
14+
15+func TestManageFavoritesUseCase_GetAllURLs_ReturnsURLSet(t *testing.T) {
16+ ctx := testContext()
17+
18+ favoriteRepo := repomocks.NewMockFavoriteRepository(t)
19+ folderRepo := repomocks.NewMockFolderRepository(t)
20+ tagRepo := repomocks.NewMockTagRepository(t)
21+
22+ favorites := []*entity.Favorite{
23+ {ID: 1, URL: "https://example.com"},
24+ {ID: 2, URL: "https://github.com"},
25+ {ID: 3, URL: "https://google.com"},
26+ }
27+
28+ favoriteRepo.EXPECT().GetAll(mock.Anything).Return(favorites, nil)
29+
30+ uc := usecase.NewManageFavoritesUseCase(favoriteRepo, folderRepo, tagRepo)
31+
32+ urls, err := uc.GetAllURLs(ctx)
33+ require.NoError(t, err)
34+ require.NotNil(t, urls)
35+
36+ assert.Len(t, urls, 3)
37+ _, hasExample := urls["https://example.com"]
38+ _, hasGithub := urls["https://github.com"]
39+ _, hasGoogle := urls["https://google.com"]
40+ assert.True(t, hasExample)
41+ assert.True(t, hasGithub)
42+ assert.True(t, hasGoogle)
43+}
44+
45+func TestManageFavoritesUseCase_GetAllURLs_ReturnsEmptySetWhenNoFavorites(t *testing.T) {
46+ ctx := testContext()
47+
48+ favoriteRepo := repomocks.NewMockFavoriteRepository(t)
49+ folderRepo := repomocks.NewMockFolderRepository(t)
50+ tagRepo := repomocks.NewMockTagRepository(t)
51+
52+ favoriteRepo.EXPECT().GetAll(mock.Anything).Return([]*entity.Favorite{}, nil)
53+
54+ uc := usecase.NewManageFavoritesUseCase(favoriteRepo, folderRepo, tagRepo)
55+
56+ urls, err := uc.GetAllURLs(ctx)
57+ require.NoError(t, err)
58+ require.NotNil(t, urls)
59+ assert.Empty(t, urls)
60+}
61+
62+func TestManageFavoritesUseCase_GetAllURLs_ReturnsErrorOnRepoFailure(t *testing.T) {
63+ ctx := testContext()
64+
65+ favoriteRepo := repomocks.NewMockFavoriteRepository(t)
66+ folderRepo := repomocks.NewMockFolderRepository(t)
67+ tagRepo := repomocks.NewMockTagRepository(t)
68+
69+ favoriteRepo.EXPECT().GetAll(mock.Anything).Return(nil, errors.New("db connection failed"))
70+
71+ uc := usecase.NewManageFavoritesUseCase(favoriteRepo, folderRepo, tagRepo)
72+
73+ urls, err := uc.GetAllURLs(ctx)
74+ require.Error(t, err)
75+ assert.Nil(t, urls)
76+ assert.Contains(t, err.Error(), "failed to get favorites")
77+}
@@ -0,0 +1,77 @@
1+package usecase_test
2+
3+import (
4+ "errors"
5+ "testing"
6+
7+ "github.com/bnema/dumber/internal/application/usecase"
8+ "github.com/bnema/dumber/internal/domain/entity"
9+ repomocks "github.com/bnema/dumber/internal/domain/repository/mocks"
10+ "github.com/stretchr/testify/assert"
11+ "github.com/stretchr/testify/mock"
12+ "github.com/stretchr/testify/require"
13+)
14+
15+func TestManageFavoritesUseCase_GetAllURLs_ReturnsURLSet(t *testing.T) {
16+ ctx := testContext()
17+
18+ favoriteRepo := repomocks.NewMockFavoriteRepository(t)
19+ folderRepo := repomocks.NewMockFolderRepository(t)
20+ tagRepo := repomocks.NewMockTagRepository(t)
21+
22+ favorites := []*entity.Favorite{
23+ {ID: 1, URL: "https://example.com"},
24+ {ID: 2, URL: "https://github.com"},
25+ {ID: 3, URL: "https://google.com"},
26+ }
27+
28+ favoriteRepo.EXPECT().GetAll(mock.Anything).Return(favorites, nil)
29+
30+ uc := usecase.NewManageFavoritesUseCase(favoriteRepo, folderRepo, tagRepo)
31+
32+ urls, err := uc.GetAllURLs(ctx)
33+ require.NoError(t, err)
34+ require.NotNil(t, urls)
35+
36+ assert.Len(t, urls, 3)
37+ _, hasExample := urls["https://example.com"]
38+ _, hasGithub := urls["https://github.com"]
39+ _, hasGoogle := urls["https://google.com"]
40+ assert.True(t, hasExample)
41+ assert.True(t, hasGithub)
42+ assert.True(t, hasGoogle)
43+}
44+
45+func TestManageFavoritesUseCase_GetAllURLs_ReturnsEmptySetWhenNoFavorites(t *testing.T) {
46+ ctx := testContext()
47+
48+ favoriteRepo := repomocks.NewMockFavoriteRepository(t)
49+ folderRepo := repomocks.NewMockFolderRepository(t)
50+ tagRepo := repomocks.NewMockTagRepository(t)
51+
52+ favoriteRepo.EXPECT().GetAll(mock.Anything).Return([]*entity.Favorite{}, nil)
53+
54+ uc := usecase.NewManageFavoritesUseCase(favoriteRepo, folderRepo, tagRepo)
55+
56+ urls, err := uc.GetAllURLs(ctx)
57+ require.NoError(t, err)
58+ require.NotNil(t, urls)
59+ assert.Empty(t, urls)
60+}
61+
62+func TestManageFavoritesUseCase_GetAllURLs_ReturnsErrorOnRepoFailure(t *testing.T) {
63+ ctx := testContext()
64+
65+ favoriteRepo := repomocks.NewMockFavoriteRepository(t)
66+ folderRepo := repomocks.NewMockFolderRepository(t)
67+ tagRepo := repomocks.NewMockTagRepository(t)
68+
69+ favoriteRepo.EXPECT().GetAll(mock.Anything).Return(nil, errors.New("db connection failed"))
70+
71+ uc := usecase.NewManageFavoritesUseCase(favoriteRepo, folderRepo, tagRepo)
72+
73+ urls, err := uc.GetAllURLs(ctx)
74+ require.Error(t, err)
75+ assert.Nil(t, urls)
76+ assert.Contains(t, err.Error(), "failed to get favorites")
77+}
M internal/ui/component/omnibox.go +16 -30
@@ -606,26 +606,16 @@ func (o *Omnibox) performSearch() {
606606 favCh := make(chan map[string]struct{}, 1)
607607
608608 go func() {
609- select {
610- case <-ctx.Done():
611- searchCh <- searchResult{nil, ctx.Err()}
612- default:
613- searchInput := usecase.SearchInput{
614- Query: query,
615- Limit: OmniboxListDefaults.MaxResults,
616- }
617- output, err := o.historyUC.Search(ctx, searchInput)
618- searchCh <- searchResult{output, err}
609+ searchInput := usecase.SearchInput{
610+ Query: query,
611+ Limit: OmniboxListDefaults.MaxResults,
619612 }
613+ output, err := o.historyUC.Search(ctx, searchInput)
614+ searchCh <- searchResult{output, err}
620615 }()
621616
622617 go func() {
623- select {
624- case <-ctx.Done():
625- favCh <- nil
626- default:
627- favCh <- o.getFavoriteURLs(ctx)
628- }
618+ favCh <- o.getFavoriteURLs(ctx)
629619 }()
630620
631621 // Wait for both results
@@ -636,6 +626,9 @@ func (o *Omnibox) performSearch() {
636626 log.Error().Err(sr.err).Msg("history search failed")
637627 return
638628 }
629+ if sr.output == nil {
630+ return
631+ }
639632
640633 suggestions := make([]Suggestion, 0, len(sr.output.Matches))
641634 for _, r := range sr.output.Matches {
@@ -678,23 +671,13 @@ func (o *Omnibox) loadInitialHistory() {
678671 favCh := make(chan map[string]struct{}, 1)
679672
680673 go func() {
681- select {
682- case <-ctx.Done():
683- historyCh <- historyResult{nil, ctx.Err()}
684- default:
685- // TODO: Implement GetMostVisited in use case if needed
686- results, err := o.historyUC.GetRecent(ctx, OmniboxListDefaults.MaxResults, 0)
687- historyCh <- historyResult{results, err}
688- }
674+ // TODO: Implement GetMostVisited in use case if needed
675+ results, err := o.historyUC.GetRecent(ctx, OmniboxListDefaults.MaxResults, 0)
676+ historyCh <- historyResult{results, err}
689677 }()
690678
691679 go func() {
692- select {
693- case <-ctx.Done():
694- favCh <- nil
695- default:
696- favCh <- o.getFavoriteURLs(ctx)
697- }
680+ favCh <- o.getFavoriteURLs(ctx)
698681 }()
699682
700683 // Wait for both results
@@ -705,6 +688,9 @@ func (o *Omnibox) loadInitialHistory() {
705688 log.Error().Err(hr.err).Msg("failed to load recent history")
706689 return
707690 }
691+ if hr.results == nil {
692+ return
693+ }
708694
709695 suggestions = make([]Suggestion, 0, len(hr.results))
710696 for _, r := range hr.results {
@@ -606,26 +606,16 @@ func (o *Omnibox) performSearch() {
606 favCh := make(chan map[string]struct{}, 1)606 favCh := make(chan map[string]struct{}, 1)
607 607
608 go func() {608 go func() {
609- select {609+ searchInput := usecase.SearchInput{
610- case <-ctx.Done():610+ Query: query,
611- searchCh <- searchResult{nil, ctx.Err()}611+ Limit: OmniboxListDefaults.MaxResults,
612- default:
613- searchInput := usecase.SearchInput{
614- Query: query,
615- Limit: OmniboxListDefaults.MaxResults,
616- }
617- output, err := o.historyUC.Search(ctx, searchInput)
618- searchCh <- searchResult{output, err}
619 }612 }
613+ output, err := o.historyUC.Search(ctx, searchInput)
614+ searchCh <- searchResult{output, err}
620 }()615 }()
621 616
622 go func() {617 go func() {
623- select {618+ favCh <- o.getFavoriteURLs(ctx)
624- case <-ctx.Done():
625- favCh <- nil
626- default:
627- favCh <- o.getFavoriteURLs(ctx)
628- }
629 }()619 }()
630 620
631 // Wait for both results621 // Wait for both results
@@ -636,6 +626,9 @@ func (o *Omnibox) performSearch() {
636 log.Error().Err(sr.err).Msg("history search failed")626 log.Error().Err(sr.err).Msg("history search failed")
637 return627 return
638 }628 }
629+ if sr.output == nil {
630+ return
631+ }
639 632
640 suggestions := make([]Suggestion, 0, len(sr.output.Matches))633 suggestions := make([]Suggestion, 0, len(sr.output.Matches))
641 for _, r := range sr.output.Matches {634 for _, r := range sr.output.Matches {
@@ -678,23 +671,13 @@ func (o *Omnibox) loadInitialHistory() {
678 favCh := make(chan map[string]struct{}, 1)671 favCh := make(chan map[string]struct{}, 1)
679 672
680 go func() {673 go func() {
681- select {674+ // TODO: Implement GetMostVisited in use case if needed
682- case <-ctx.Done():675+ results, err := o.historyUC.GetRecent(ctx, OmniboxListDefaults.MaxResults, 0)
683- historyCh <- historyResult{nil, ctx.Err()}676+ historyCh <- historyResult{results, err}
684- default:
685- // TODO: Implement GetMostVisited in use case if needed
686- results, err := o.historyUC.GetRecent(ctx, OmniboxListDefaults.MaxResults, 0)
687- historyCh <- historyResult{results, err}
688- }
689 }()677 }()
690 678
691 go func() {679 go func() {
692- select {680+ favCh <- o.getFavoriteURLs(ctx)
693- case <-ctx.Done():
694- favCh <- nil
695- default:
696- favCh <- o.getFavoriteURLs(ctx)
697- }
698 }()681 }()
699 682
700 // Wait for both results683 // Wait for both results
@@ -705,6 +688,9 @@ func (o *Omnibox) loadInitialHistory() {
705 log.Error().Err(hr.err).Msg("failed to load recent history")688 log.Error().Err(hr.err).Msg("failed to load recent history")
706 return689 return
707 }690 }
691+ if hr.results == nil {
692+ return
693+ }
708 694
709 suggestions = make([]Suggestion, 0, len(hr.results))695 suggestions = make([]Suggestion, 0, len(hr.results))
710 for _, r := range hr.results {696 for _, r := range hr.results {

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close