fix(favicon): guard against nil texture overwriting good favicon in GetOrFetch callback

The async GetOrFetch callback could return nil (WebKit DB empty at commit
time, DuckDuckGo ICO parse failure) and overwrite a valid favicon that was
already set by an earlier notify::favicon signal. Skip nil results since
they mean 'could not resolve', not 'no favicon exists'.

commit: 929f98fa3f544f2407440bc11fbb09b12ea0c3db
author: brice · 7mo ago · 2026-03-13 05:57 UTC
parent: 4b76d6b
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +6 -0

M internal/ui/coordinator/content.go +6 -0


@@ -1091,6 +1091,12 @@ func (c *ContentCoordinator) resolveCommittedFavicon(ctx context.Context, paneID
1091	1091		// Capture current generation to guard against stale callbacks
1092	1092		gen := wv.Generation()
1093	1093		c.faviconAdapter.GetOrFetch(ctx, uri, func(texture *gdk.Texture) {
	1094	+	// Skip nil results — a nil means "couldn't resolve", not "no favicon".
	1095	+	// Without this guard, a late nil callback can overwrite a good favicon
	1096	+	// that was already set by an earlier onFaviconChanged signal.
	1097	+	if texture == nil {
	1098	+	return
	1099	+	}
1094	1100		// Verify WebView is still bound to pane and hasn't been reused
1095	1101		if wv.Generation() != gen {
1096	1102		return


@@ -1091,6 +1091,12 @@ func (c *ContentCoordinator) resolveCommittedFavicon(ctx context.Context, paneID
1091	// Capture current generation to guard against stale callbacks	1091		// Capture current generation to guard against stale callbacks
1092	gen := wv.Generation()	1092		gen := wv.Generation()
1093	c.faviconAdapter.GetOrFetch(ctx, uri, func(texture *gdk.Texture) {	1093		c.faviconAdapter.GetOrFetch(ctx, uri, func(texture *gdk.Texture) {
		1094	+	// Skip nil results — a nil means "couldn't resolve", not "no favicon".
		1095	+	// Without this guard, a late nil callback can overwrite a good favicon
		1096	+	// that was already set by an earlier onFaviconChanged signal.
		1097	+	if texture == nil {
		1098	+	return
		1099	+	}
1094	// Verify WebView is still bound to pane and hasn't been reused	1100		// Verify WebView is still bound to pane and hasn't been reused
1095	if wv.Generation() != gen {	1101		if wv.Generation() != gen {
1096	return	1102		return