test(favicon): handle sized PNG decode failures

commit: 99a0f9c1bfee026c5fa1bd25de47a99e4175f4f1
author: brice · 3mo ago · 2026-07-22 07:43 UTC
parent: bfd57d4
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +6 -2

M internal/infrastructure/favicon/webp_decoder_test.go +6 -2


@@ -30,8 +30,12 @@ func TestConverterWebPConvertsAlphaFixture(t *testing.T) {
30	30		if got := color.NRGBAModel.Convert(img.At(0, 0)).(color.NRGBA); got.A != 64 \|\| got.R != 255 {
31	31		t.Fatalf("alpha pixel = %#v, want red alpha 64", got)
32	32		}
33		-	if sized, err := png.Decode(bytes.NewReader(out.SizedPNG[32])); err != nil \|\| sized.Bounds() != image.Rect(0, 0, 32, 32) {
34		-	t.Fatalf("sized WebP = %v, %v", sized.Bounds(), err)
	33	+	sized, err := png.Decode(bytes.NewReader(out.SizedPNG[32]))
	34	+	if err != nil {
	35	+	t.Fatal(err)
	36	+	}
	37	+	if sized.Bounds() != image.Rect(0, 0, 32, 32) {
	38	+	t.Fatalf("sized WebP bounds = %v, want 32x32", sized.Bounds())
35	39		}
36	40		}
37	41

 	if got := color.NRGBAModel.Convert(img.At(0, 0)).(color.NRGBA); got.A != 64 || got.R != 255 {
 		t.Fatalf("alpha pixel = %#v, want red alpha 64", got)
 	}
-	if sized, err := png.Decode(bytes.NewReader(out.SizedPNG[32])); err != nil || sized.Bounds() != image.Rect(0, 0, 32, 32) {
+	sized, err := png.Decode(bytes.NewReader(out.SizedPNG[32]))
-		t.Fatalf("sized WebP = %v, %v", sized.Bounds(), err)
+	if err != nil {
+		t.Fatal(err)
+	}
+	if sized.Bounds() != image.Rect(0, 0, 32, 32) {
+		t.Fatalf("sized WebP bounds = %v, want 32x32", sized.Bounds())
 	}
 }