detached aae7da7

fix: keep ghost completion explicitly selected until user accepts

commit
aae7da71e123afb2dd758f912636b6bc8c7ad8e7
author
brice · · 2026-02-07 06:02 UTC
parent
59a422a
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +3 -1
M internal/ui/component/omnibox.go +3 -1
@@ -836,6 +836,7 @@ func (o *Omnibox) setGhostText(originalInput, suffix, fullText string) {
836836 displayText = fullText
837837 }
838838 selectionStart := utf8.RuneCountInString(originalInput)
839+ selectionEnd := utf8.RuneCountInString(displayText)
839840
840841 o.mu.Lock()
841842 o.realInput = originalInput
@@ -860,7 +861,8 @@ func (o *Omnibox) setGhostText(originalInput, suffix, fullText string) {
860861 o.mu.Unlock()
861862
862863 o.entry.SetText(displayText)
863- o.entry.SelectRegion(selectionStart, -1)
864+ o.entry.SetPosition(selectionStart)
865+ o.entry.SelectRegion(selectionStart, selectionEnd)
864866
865867 o.mu.Lock()
866868 o.isAcceptingGhost = false
@@ -836,6 +836,7 @@ func (o *Omnibox) setGhostText(originalInput, suffix, fullText string) {
836 displayText = fullText836 displayText = fullText
837 }837 }
838 selectionStart := utf8.RuneCountInString(originalInput)838 selectionStart := utf8.RuneCountInString(originalInput)
839+ selectionEnd := utf8.RuneCountInString(displayText)
839 840
840 o.mu.Lock()841 o.mu.Lock()
841 o.realInput = originalInput842 o.realInput = originalInput
@@ -860,7 +861,8 @@ func (o *Omnibox) setGhostText(originalInput, suffix, fullText string) {
860 o.mu.Unlock()861 o.mu.Unlock()
861 862
862 o.entry.SetText(displayText)863 o.entry.SetText(displayText)
863- o.entry.SelectRegion(selectionStart, -1)864+ o.entry.SetPosition(selectionStart)
865+ o.entry.SelectRegion(selectionStart, selectionEnd)
864 866
865 o.mu.Lock()867 o.mu.Lock()
866 o.isAcceptingGhost = false868 o.isAcceptingGhost = false

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close