detached ad1fde7

refactor(config): reuse atomicWriteFile in engine migration

Replace duplicated atomic write logic with existing atomicWriteFile
utility from writer.go.
commit
ad1fde7683442dbd2368ebff6b5639bd11a8c34d
author
brice · · 2026-03-18 05:12 UTC
parent
2b3891d
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +3 -4
M internal/infrastructure/config/migrate_engine.go +3 -4
@@ -2,10 +2,9 @@ package config
22
33 import (
44 "fmt"
5+ "github.com/pelletier/go-toml/v2"
56 "io/fs"
67 "os"
7-
8- "github.com/pelletier/go-toml/v2"
98 )
109
1110 // configFilePermissions is the file permission used when writing migrated config files.
@@ -129,8 +128,8 @@ func MigrateToEngineConfig(configFile string) (bool, error) {
129128 return false, marshalErr
130129 }
131130
132- if writeErr := os.WriteFile(configFile, out, configFilePermissions); writeErr != nil {
133- return false, writeErr
131+ if err := atomicWriteFile(configFile, string(out), configFilePermissions); err != nil {
132+ return false, err
134133 }
135134
136135 return true, nil
@@ -2,10 +2,9 @@ package config
2 2
3 import (3 import (
4 "fmt"4 "fmt"
5+ "github.com/pelletier/go-toml/v2"
5 "io/fs"6 "io/fs"
6 "os"7 "os"
7-
8- "github.com/pelletier/go-toml/v2"
9 )8 )
10 9
11 // configFilePermissions is the file permission used when writing migrated config files.10 // configFilePermissions is the file permission used when writing migrated config files.
@@ -129,8 +128,8 @@ func MigrateToEngineConfig(configFile string) (bool, error) {
129 return false, marshalErr128 return false, marshalErr
130 }129 }
131 130
132- if writeErr := os.WriteFile(configFile, out, configFilePermissions); writeErr != nil {131+ if err := atomicWriteFile(configFile, string(out), configFilePermissions); err != nil {
133- return false, writeErr132+ return false, err
134 }133 }
135 134
136 return true, nil135 return true, nil

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close