detached bba9426

fix(webkit): add directory verification logging for gc-safe path handling

commit
bba942658de7b9a2e423033104f55d6ccf8f94c4
author
bnema · · 2025-12-18 04:47 UTC
parent
a59671e
signature
unsigned
2 files · +11 -1
M go.mod +1 -1
@@ -13,6 +13,7 @@ require (
1313 github.com/pressly/goose/v3 v3.26.0
1414 github.com/rs/zerolog v1.33.0
1515 github.com/sahilm/fuzzy v0.1.1
16+ github.com/spf13/cobra v1.10.2
1617 github.com/spf13/viper v1.21.0
1718 github.com/stretchr/testify v1.11.1
1819 )
@@ -47,7 +48,6 @@ require (
4748 github.com/sourcegraph/conc v0.3.1-0.20240121214520-5f936abd7ae8 // indirect
4849 github.com/spf13/afero v1.15.0 // indirect
4950 github.com/spf13/cast v1.10.0 // indirect
50- github.com/spf13/cobra v1.10.2 // indirect
5151 github.com/spf13/pflag v1.0.10 // indirect
5252 github.com/stretchr/objx v0.5.2 // indirect
5353 github.com/subosito/gotenv v1.6.0 // indirect
@@ -13,6 +13,7 @@ require (
13 github.com/pressly/goose/v3 v3.26.013 github.com/pressly/goose/v3 v3.26.0
14 github.com/rs/zerolog v1.33.014 github.com/rs/zerolog v1.33.0
15 github.com/sahilm/fuzzy v0.1.115 github.com/sahilm/fuzzy v0.1.1
16+ github.com/spf13/cobra v1.10.2
16 github.com/spf13/viper v1.21.017 github.com/spf13/viper v1.21.0
17 github.com/stretchr/testify v1.11.118 github.com/stretchr/testify v1.11.1
18 )19 )
@@ -47,7 +48,6 @@ require (
47 github.com/sourcegraph/conc v0.3.1-0.20240121214520-5f936abd7ae8 // indirect48 github.com/sourcegraph/conc v0.3.1-0.20240121214520-5f936abd7ae8 // indirect
48 github.com/spf13/afero v1.15.0 // indirect49 github.com/spf13/afero v1.15.0 // indirect
49 github.com/spf13/cast v1.10.0 // indirect50 github.com/spf13/cast v1.10.0 // indirect
50- github.com/spf13/cobra v1.10.2 // indirect
51 github.com/spf13/pflag v1.0.10 // indirect51 github.com/spf13/pflag v1.0.10 // indirect
52 github.com/stretchr/objx v0.5.2 // indirect52 github.com/stretchr/objx v0.5.2 // indirect
53 github.com/subosito/gotenv v1.6.0 // indirect53 github.com/subosito/gotenv v1.6.0 // indirect
M internal/infrastructure/webkit/context.go +10 -0
@@ -94,6 +94,16 @@ func (c *WebKitContext) initNetworkSession() error {
9494 return fmt.Errorf("website data manager is ephemeral")
9595 }
9696
97+ // Debug: verify the directories WebKit is actually using
98+ actualDataDir := dataManager.GetBaseDataDirectory()
99+ actualCacheDir := dataManager.GetBaseCacheDirectory()
100+ c.logger.Info().
101+ Str("expected_data_dir", c.dataDir).
102+ Str("actual_data_dir", actualDataDir).
103+ Str("expected_cache_dir", c.cacheDir).
104+ Str("actual_cache_dir", actualCacheDir).
105+ Msg("webkit directories configured")
106+
97107 // Enable favicon collection and get database reference
98108 dataManager.SetFaviconsEnabled(true)
99109 c.faviconDB = dataManager.GetFaviconDatabase()
@@ -94,6 +94,16 @@ func (c *WebKitContext) initNetworkSession() error {
94 return fmt.Errorf("website data manager is ephemeral")94 return fmt.Errorf("website data manager is ephemeral")
95 }95 }
96 96
97+ // Debug: verify the directories WebKit is actually using
98+ actualDataDir := dataManager.GetBaseDataDirectory()
99+ actualCacheDir := dataManager.GetBaseCacheDirectory()
100+ c.logger.Info().
101+ Str("expected_data_dir", c.dataDir).
102+ Str("actual_data_dir", actualDataDir).
103+ Str("expected_cache_dir", c.cacheDir).
104+ Str("actual_cache_dir", actualCacheDir).
105+ Msg("webkit directories configured")
106+
97 // Enable favicon collection and get database reference107 // Enable favicon collection and get database reference
98 dataManager.SetFaviconsEnabled(true)108 dataManager.SetFaviconsEnabled(true)
99 c.faviconDB = dataManager.GetFaviconDatabase()109 c.faviconDB = dataManager.GetFaviconDatabase()

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close