detached bef9811

fix(webkit): clarify js fallback log messages for SPA navigation

commit
bef9811bb3a36659d9ba790fdb13bbc01b43fa0d
author
bnema · · 2026-01-08 17:41 UTC
parent
f291bc4
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +2 -2
M internal/infrastructure/webkit/webview.go +2 -2
@@ -778,7 +778,7 @@ func (wv *WebView) GoBack(ctx context.Context) error {
778778 // Fall back to JavaScript history.back() for SPA navigation
779779 // This handles pushState/replaceState history that WebKit's BackForwardList doesn't track
780780 wv.RunJavaScript(ctx, "history.back()", "")
781- log.Debug().Int("webview_id", int(wv.id)).Msg("webview go back (js)")
781+ log.Debug().Int("webview_id", int(wv.id)).Msg("webview go back (js fallback)")
782782 return nil
783783 }
784784
@@ -800,7 +800,7 @@ func (wv *WebView) GoForward(ctx context.Context) error {
800800 // Fall back to JavaScript history.forward() for SPA navigation
801801 // This handles pushState/replaceState history that WebKit's BackForwardList doesn't track
802802 wv.RunJavaScript(ctx, "history.forward()", "")
803- log.Debug().Int("webview_id", int(wv.id)).Msg("webview go forward (js)")
803+ log.Debug().Int("webview_id", int(wv.id)).Msg("webview go forward (js fallback)")
804804 return nil
805805 }
806806
@@ -778,7 +778,7 @@ func (wv *WebView) GoBack(ctx context.Context) error {
778 // Fall back to JavaScript history.back() for SPA navigation778 // Fall back to JavaScript history.back() for SPA navigation
779 // This handles pushState/replaceState history that WebKit's BackForwardList doesn't track779 // This handles pushState/replaceState history that WebKit's BackForwardList doesn't track
780 wv.RunJavaScript(ctx, "history.back()", "")780 wv.RunJavaScript(ctx, "history.back()", "")
781- log.Debug().Int("webview_id", int(wv.id)).Msg("webview go back (js)")781+ log.Debug().Int("webview_id", int(wv.id)).Msg("webview go back (js fallback)")
782 return nil782 return nil
783 }783 }
784 784
@@ -800,7 +800,7 @@ func (wv *WebView) GoForward(ctx context.Context) error {
800 // Fall back to JavaScript history.forward() for SPA navigation800 // Fall back to JavaScript history.forward() for SPA navigation
801 // This handles pushState/replaceState history that WebKit's BackForwardList doesn't track801 // This handles pushState/replaceState history that WebKit's BackForwardList doesn't track
802 wv.RunJavaScript(ctx, "history.forward()", "")802 wv.RunJavaScript(ctx, "history.forward()", "")
803- log.Debug().Int("webview_id", int(wv.id)).Msg("webview go forward (js)")803+ log.Debug().Int("webview_id", int(wv.id)).Msg("webview go forward (js fallback)")
804 return nil804 return nil
805 }805 }
806 806

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close