fix(benchmarks): report sqlite close errors

commit: c5ad8c0111ff59f5669d6df71cafbc0b11e5079e
author: brice · 3mo ago · 2026-07-14 14:16 UTC
parent: 4d548f3
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +7 -2

M internal/infrastructure/persistence/sqlite/history_repo_benchmark_test.go +7 -2


@@ -22,6 +22,12 @@ func newHistoryBenchmarkRepository(b *testing.B) (repository.HistoryRepository,
22	22		b.Fatal(err)
23	23		}
24	24
	25	+	b.Cleanup(func() {
	26	+	if err := db.Close(); err != nil {
	27	+	b.Errorf("close benchmark database: %v", err)
	28	+	}
	29	+	})
	30	+
25	31		repo := sqlite.NewHistoryRepository(db)
26	32		for i := range 200 {
27	33		entry := &entity.HistoryEntry{

@@ -29,12 +35,11 @@ func newHistoryBenchmarkRepository(b *testing.B) (repository.HistoryRepository,
29	35		Title: fmt.Sprintf("Dumber history entry %d", i),
30	36		}
31	37		if err := repo.Save(ctx, entry); err != nil {
32		-	_ = db.Close()
33	38		b.Fatal(err)
34	39		}
35	40		}
36	41
37		-	return repo, func() { _ = db.Close() }
	42	+	return repo, func() {}
38	43		}
39	44
40	45		func BenchmarkHistorySQLiteSidebarRecent(b *testing.B) {

 		b.Fatal(err)
 	}
+	b.Cleanup(func() {
+		if err := db.Close(); err != nil {
+			b.Errorf("close benchmark database: %v", err)
+		}
+	})
 	repo := sqlite.NewHistoryRepository(db)
 	for i := range 200 {
 		entry := &entity.HistoryEntry{
 			Title: fmt.Sprintf("Dumber history entry %d", i),
 		}
 		if err := repo.Save(ctx, entry); err != nil {
-			_ = db.Close()
 			b.Fatal(err)
 		}
 	}
-	return repo, func() { _ = db.Close() }
+	return repo, func() {}
 }
 func BenchmarkHistorySQLiteSidebarRecent(b *testing.B) {