detached c9efd76

omnibox: make favicons readable on dark overlay (light chip background, subtle border/shadow, slight brightness/contrast boost); keeps transparency for non-square icons

commit
c9efd769f8b8c452cf00d75ffc0de00d50ed0812
author
bamen · · 2025-09-09 19:13 UTC
committer
bamen · · 2025-09-09 19:42 UTC
parent
66e5fc8
signature
unsigned
1 file · +3 -2
M pkg/webkit/ucm_js_cgo.go +3 -2
@@ -171,8 +171,9 @@ func getOmniboxScript() string {
171171 // Favicon
172172 const icon = document.createElement('img');
173173 icon.src = s.favicon || '';
174- icon.width = 18; icon.height = 18; icon.loading = 'lazy';
175- icon.style.cssText = 'flex:0 0 18px;width:18px;height:18px;border-radius:4px;opacity:.95;';
174+ icon.width = 16; icon.height = 16; icon.loading = 'lazy';
175+ // Ensure dark favicons remain visible on dark overlay: light chip + mild lift
176+ icon.style.cssText = 'flex:0 0 20px;width:16px;height:16px;padding:2px;box-sizing:content-box;border-radius:6px;background:#fff;border:1px solid rgba(0,0,0,.15);box-shadow:0 1px 2px rgba(0,0,0,.15);filter:brightness(1.12) contrast(1.04);';
176177 icon.onerror = ()=>{ icon.style.display='none'; };
177178 // Text line: Domain | full path (one line, fade at end)
178179 let domain = '', path = '';
@@ -171,8 +171,9 @@ func getOmniboxScript() string {
171 // Favicon171 // Favicon
172 const icon = document.createElement('img');172 const icon = document.createElement('img');
173 icon.src = s.favicon || '';173 icon.src = s.favicon || '';
174- icon.width = 18; icon.height = 18; icon.loading = 'lazy';174+ icon.width = 16; icon.height = 16; icon.loading = 'lazy';
175- icon.style.cssText = 'flex:0 0 18px;width:18px;height:18px;border-radius:4px;opacity:.95;';175+ // Ensure dark favicons remain visible on dark overlay: light chip + mild lift
176+ icon.style.cssText = 'flex:0 0 20px;width:16px;height:16px;padding:2px;box-sizing:content-box;border-radius:6px;background:#fff;border:1px solid rgba(0,0,0,.15);box-shadow:0 1px 2px rgba(0,0,0,.15);filter:brightness(1.12) contrast(1.04);';
176 icon.onerror = ()=>{ icon.style.display='none'; };177 icon.onerror = ()=>{ icon.style.display='none'; };
177 // Text line: Domain | full path (one line, fade at end)178 // Text line: Domain | full path (one line, fade at end)
178 let domain = '', path = '';179 let domain = '', path = '';

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close