refactor: use typed *glib.Error in signal callbacks (puregotk v0.2.2)

Bump puregotk to v0.2.2 and puregotk-webkit to v0.0.16.
Signal callbacks now receive *glib.Error instead of raw uintptr,
giving us actual error messages in load-failed and download-failed logs.

commit: e2241c565e09029d95e511d90963f32898c05e78
author: brice · 6mo ago · 2026-03-27 20:48 UTC
parent: 26fd7de
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

4 files · +11 -11

M go.mod +2 -2


@@ -4,8 +4,8 @@ go 1.26.1
4	4
5	5		require (
6	6		github.com/bnema/purego-sqlite v0.1.1
7		-	github.com/bnema/puregotk v0.2.1
8		-	github.com/bnema/puregotk-webkit v0.0.15
	7	+	github.com/bnema/puregotk v0.2.2
	8	+	github.com/bnema/puregotk-webkit v0.0.16
9	9		github.com/charmbracelet/bubbles v1.0.0
10	10		github.com/charmbracelet/bubbletea v1.3.10
11	11		github.com/charmbracelet/lipgloss v1.1.0


@@ -4,8 +4,8 @@ go 1.26.1
4			4
5		require (	5		require (
6		github.com/bnema/purego-sqlite v0.1.1	6		github.com/bnema/purego-sqlite v0.1.1
7	-	github.com/bnema/puregotk v0.2.1	7	+	github.com/bnema/puregotk v0.2.2
8	-	github.com/bnema/puregotk-webkit v0.0.15	8	+	github.com/bnema/puregotk-webkit v0.0.16
9		github.com/charmbracelet/bubbles v1.0.0	9		github.com/charmbracelet/bubbles v1.0.0
10		github.com/charmbracelet/bubbletea v1.3.10	10		github.com/charmbracelet/bubbletea v1.3.10
11		github.com/charmbracelet/lipgloss v1.1.0	11		github.com/charmbracelet/lipgloss v1.1.0

M go.sum +4 -4 generated file: collapsed

load diff

M internal/infrastructure/webkit/download_handler.go +3 -2


@@ -10,6 +10,7 @@ import (
10	10		downloadutil "github.com/bnema/dumber/internal/domain/download"
11	11		"github.com/bnema/dumber/internal/logging"
12	12		"github.com/bnema/puregotk-webkit/webkit"
	13	+	"github.com/bnema/puregotk/v4/glib"
13	14		)
14	15
15	16		const (

@@ -114,7 +115,7 @@ func (h DownloadHandler) HandleDownload(ctx context.Context, download webkit.D
114	115		download.ConnectDecideDestination(&decideDestCb)
115	116
116	117		// Handle failed signal.
117		-	failedCb := func(d webkit.Download, _ uintptr) {
	118	+	failedCb := func(d webkit.Download, gerr *glib.Error) {
118	119		state.mu.Lock()
119	120		state.failed = true
120	121		state.mu.Unlock()

@@ -123,7 +124,7 @@ func (h DownloadHandler) HandleDownload(ctx context.Context, download webkit.D
123	124		filename := downloadutil.ExtractFilenameFromDestination(dest)
124	125
125	126		// Create error for the failed download.
126		-	downloadErr := fmt.Errorf("download failed: %s", filename)
	127	+	downloadErr := fmt.Errorf("download failed: %s: %s", filename, gerr.MessageGo())
127	128
128	129		if eventHandler != nil {
129	130		eventHandler.OnDownloadEvent(ctx, port.DownloadEvent{

 	downloadutil "github.com/bnema/dumber/internal/domain/download"
 	"github.com/bnema/dumber/internal/logging"
 	"github.com/bnema/puregotk-webkit/webkit"
+	"github.com/bnema/puregotk/v4/glib"
 )
 const (
 	download.ConnectDecideDestination(&decideDestCb)
 	// Handle failed signal.
-	failedCb := func(d webkit.Download, _ uintptr) {
+	failedCb := func(d webkit.Download, gerr *glib.Error) {
 		state.mu.Lock()
 		state.failed = true
 		state.mu.Unlock()
 		filename := downloadutil.ExtractFilenameFromDestination(dest)
 		// Create error for the failed download.
-		downloadErr := fmt.Errorf("download failed: %s", filename)
+		downloadErr := fmt.Errorf("download failed: %s: %s", filename, gerr.MessageGo())
 		if eventHandler != nil {
 			eventHandler.OnDownloadEvent(ctx, port.DownloadEvent{

M internal/infrastructure/webkit/webview.go +2 -3


@@ -467,13 +467,12 @@ func (wv *WebView) connectLoadChangedSignal() {
467	467		}
468	468
469	469		func (wv *WebView) connectLoadFailedSignal() {
470		-	loadFailedCb := func(_ webkit.WebView, event webkit.LoadEvent, failingURI string, _ uintptr) bool {
471		-	// Note: error details are a raw uintptr (GError*) — see bnema/puregotk#6
472		-	// for tracking proper *glib.Error conversion in signal callbacks.
	470	+	loadFailedCb := func(_ webkit.WebView, event webkit.LoadEvent, failingURI string, gerr *glib.Error) bool {
473	471		wv.logger.Warn().
474	472		Str("component", "webview").
475	473		Str("uri", failingURI).
476	474		Int("load_event", int(event)).
	475	+	Str("error", gerr.MessageGo()).
477	476		Msg("load failed")
478	477		return false
479	478		}

 }
 func (wv *WebView) connectLoadFailedSignal() {
-	loadFailedCb := func(_ webkit.WebView, event webkit.LoadEvent, failingURI string, _ uintptr) bool {
+	loadFailedCb := func(_ webkit.WebView, event webkit.LoadEvent, failingURI string, gerr *glib.Error) bool {
-		// Note: error details are a raw uintptr (GError*) — see bnema/puregotk#6
-		// for tracking proper *glib.Error conversion in signal callbacks.
 		wv.logger.Warn().
 			Str("component", "webview").
 			Str("uri", failingURI).
 			Int("load_event", int(event)).
+			Str("error", gerr.MessageGo()).
 			Msg("load failed")
 		return false
 	}