Address trivial zoom review follow-ups
- commit
- e9cfa6d0508b7e0f5351ed800db0a1cd71e091d7
- author
- brice · · 2026-05-15 06:39 UTC
- parent
- ca353b8
- signature
- GPG Verified
CD88F9E564E0102646FB6077A1A07C7C7C3E349D· arch-gpg Verified for the committer email
2 files · +5 -0
M internal/ui/app_browser_launch_test.go +4 -0
| @@ -2213,12 +2213,16 @@ func TestApp_DispatchBrowserWindowActionZoomInSupportsFileURLs(t *testing.T) { | |||
| 2213 | 2213 | ||
| 2214 | 2214 | app := &App{ | |
| 2215 | 2215 | browserWindows: map[string]*browserWindow{bw.id: bw}, | |
| 2216 | + | tabs: entity.NewTabList(), | |
| 2217 | + | windowForTab: map[entity.TabID]*browserWindow{tab.ID: bw}, | |
| 2216 | 2218 | contentCoord: contentCoord, | |
| 2217 | 2219 | deps: &Dependencies{ZoomUC: usecase.NewManageZoomUseCase(&fakeZoomRepo{}, 1.0, nil)}, | |
| 2218 | 2220 | workspaceViews: map[entity.TabID]*component.WorkspaceView{ | |
| 2219 | 2221 | tab.ID: &component.WorkspaceView{}, | |
| 2220 | 2222 | }, | |
| 2221 | 2223 | } | |
| 2224 | + | app.tabs.Add(tab) | |
| 2225 | + | app.tabs.SetActive(tab.ID) | |
| 2222 | 2226 | ||
| 2223 | 2227 | if err := app.dispatchBrowserWindowAction(ctx, bw, input.ActionZoomIn); err != nil { | |
| 2224 | 2228 | t.Fatalf("dispatchBrowserWindowAction returned error: %v", err) | |
| @@ -2213,12 +2213,16 @@ func TestApp_DispatchBrowserWindowActionZoomInSupportsFileURLs(t *testing.T) { | |||||
| 2213 | 2213 | ||||
| 2214 | app := &App{ | 2214 | app := &App{ | ||
| 2215 | browserWindows: map[string]*browserWindow{bw.id: bw}, | 2215 | browserWindows: map[string]*browserWindow{bw.id: bw}, | ||
| 2216 | + | tabs: entity.NewTabList(), | |||
| 2217 | + | windowForTab: map[entity.TabID]*browserWindow{tab.ID: bw}, | |||
| 2216 | contentCoord: contentCoord, | 2218 | contentCoord: contentCoord, | ||
| 2217 | deps: &Dependencies{ZoomUC: usecase.NewManageZoomUseCase(&fakeZoomRepo{}, 1.0, nil)}, | 2219 | deps: &Dependencies{ZoomUC: usecase.NewManageZoomUseCase(&fakeZoomRepo{}, 1.0, nil)}, | ||
| 2218 | workspaceViews: map[entity.TabID]*component.WorkspaceView{ | 2220 | workspaceViews: map[entity.TabID]*component.WorkspaceView{ | ||
| 2219 | tab.ID: &component.WorkspaceView{}, | 2221 | tab.ID: &component.WorkspaceView{}, | ||
| 2220 | }, | 2222 | }, | ||
| 2221 | } | 2223 | } | ||
| 2224 | + | app.tabs.Add(tab) | |||
| 2225 | + | app.tabs.SetActive(tab.ID) | |||
| 2222 | 2226 | ||||
| 2223 | if err := app.dispatchBrowserWindowAction(ctx, bw, input.ActionZoomIn); err != nil { | 2227 | if err := app.dispatchBrowserWindowAction(ctx, bw, input.ActionZoomIn); err != nil { | ||
| 2224 | t.Fatalf("dispatchBrowserWindowAction returned error: %v", err) | 2228 | t.Fatalf("dispatchBrowserWindowAction returned error: %v", err) | ||
M internal/ui/coordinator/content/navigation.go +1 -0
| @@ -108,6 +108,7 @@ func (c *Coordinator) onLoadCommitted(ctx context.Context, paneID entity.PaneID, | |||
| 108 | 108 | ||
| 109 | 109 | zoomKey, err := usecase.ExtractZoomKey(uri) | |
| 110 | 110 | if err != nil { | |
| 111 | + | log.Debug().Err(err).Str("uri", uri).Msg("skipping zoom application: cannot extract zoom key") | |
| 111 | 112 | return | |
| 112 | 113 | } | |
| 113 | 114 | ||
| @@ -108,6 +108,7 @@ func (c *Coordinator) onLoadCommitted(ctx context.Context, paneID entity.PaneID, | |||||
| 108 | 108 | ||||
| 109 | zoomKey, err := usecase.ExtractZoomKey(uri) | 109 | zoomKey, err := usecase.ExtractZoomKey(uri) | ||
| 110 | if err != nil { | 110 | if err != nil { | ||
| 111 | + | log.Debug().Err(err).Str("uri", uri).Msg("skipping zoom application: cannot extract zoom key") | |||
| 111 | return | 112 | return | ||
| 112 | } | 113 | } | ||
| 113 | 114 | ||||