fix(updater): skip update checks for Flatpak and AUR installs

commit: eac150d65694e8aef3c95b975ae8ba9c8cc2e149
author: bnema · 9mo ago · 2026-01-06 18:33 UTC
committer: bnema · 9mo ago · 2026-01-06 19:04 UTC
parent: 2e2d702
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +15 -0

M internal/infrastructure/updater/github.go +15 -0


@@ -23,6 +23,7 @@ import (
23	23		"time"
24	24
25	25		"github.com/bnema/dumber/internal/domain/entity"
	26	+	"github.com/bnema/dumber/internal/infrastructure/env"
26	27		"github.com/bnema/dumber/internal/logging"
27	28		)
28	29

@@ -93,6 +94,20 @@ func (g *GitHubChecker) CheckForUpdate(ctx context.Context, currentVersion strin
93	94		}, nil
94	95		}
95	96
	97	+	// Skip check for package manager installs (Flatpak, AUR).
	98	+	// These should use their respective package managers for updates.
	99	+	if env.IsFlatpak() \|\| env.IsPacman() {
	100	+	log.Debug().
	101	+	Bool("flatpak", env.IsFlatpak()).
	102	+	Bool("pacman", env.IsPacman()).
	103	+	Msg("skipping update check for package manager install")
	104	+	return &entity.UpdateInfo{
	105	+	CurrentVersion: currentVersion,
	106	+	LatestVersion: currentVersion,
	107	+	IsNewer: false,
	108	+	}, nil
	109	+	}
	110	+
96	111		req, err := http.NewRequestWithContext(ctx, http.MethodGet, githubAPIURL, http.NoBody)
97	112		if err != nil {
98	113		return nil, fmt.Errorf("failed to create request: %w", err)


@@ -23,6 +23,7 @@ import (
23	"time"	23		"time"
24		24
25	"github.com/bnema/dumber/internal/domain/entity"	25		"github.com/bnema/dumber/internal/domain/entity"
		26	+	"github.com/bnema/dumber/internal/infrastructure/env"
26	"github.com/bnema/dumber/internal/logging"	27		"github.com/bnema/dumber/internal/logging"
27	)	28		)
28		29

@@ -93,6 +94,20 @@ func (g *GitHubChecker) CheckForUpdate(ctx context.Context, currentVersion strin
93	}, nil	94		}, nil
94	}	95		}
95		96
		97	+	// Skip check for package manager installs (Flatpak, AUR).
		98	+	// These should use their respective package managers for updates.
		99	+	if env.IsFlatpak() \|\| env.IsPacman() {
		100	+	log.Debug().
		101	+	Bool("flatpak", env.IsFlatpak()).
		102	+	Bool("pacman", env.IsPacman()).
		103	+	Msg("skipping update check for package manager install")
		104	+	return &entity.UpdateInfo{
		105	+	CurrentVersion: currentVersion,
		106	+	LatestVersion: currentVersion,
		107	+	IsNewer: false,
		108	+	}, nil
		109	+	}
		110	+
96	req, err := http.NewRequestWithContext(ctx, http.MethodGet, githubAPIURL, http.NoBody)	111		req, err := http.NewRequestWithContext(ctx, http.MethodGet, githubAPIURL, http.NoBody)
97	if err != nil {	112		if err != nil {
98	return nil, fmt.Errorf("failed to create request: %w", err)	113		return nil, fmt.Errorf("failed to create request: %w", err)