cli: print styled config-open errors without ANSI returns

commit: f13a4f40678a5188d5b3a751f94c14bb3a2a948d
author: bnema · 8mo ago · 2026-02-11 19:55 UTC
parent: 3a4e250
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +12 -4

M internal/cli/cmd/config.go +12 -4


@@ -118,18 +118,24 @@ func runConfigOpen(_ *cobra.Command, _ []string) error {
118	118
119	119		configFile, err := config.GetConfigFile()
120	120		if err != nil {
121		-	return fmt.Errorf("%s", strings.TrimRight(renderer.RenderError(fmt.Errorf("get config file: %w", err)), "\n"))
	121	+	wrappedErr := fmt.Errorf("get config file: %w", err)
	122	+	fmt.Fprintln(os.Stderr, strings.TrimRight(renderer.RenderError(wrappedErr), "\n"))
	123	+	return wrapPrintedError(wrappedErr)
122	124		}
123	125
124	126		// Check if config file exists
125	127		if _, statErr := os.Stat(configFile); os.IsNotExist(statErr) {
126		-	return fmt.Errorf("%s", strings.TrimRight(renderer.RenderError(fmt.Errorf("config file does not exist: %s", configFile)), "\n"))
	128	+	err := fmt.Errorf("config file does not exist: %s", configFile)
	129	+	fmt.Fprintln(os.Stderr, strings.TrimRight(renderer.RenderError(err), "\n"))
	130	+	return wrapPrintedError(err)
127	131		}
128	132
129	133		editor := getEditor()
130	134		if editor == "" {
131	135		const msg = "no editor found: set $EDITOR or $VISUAL environment variable"
132		-	return fmt.Errorf("%s", strings.TrimRight(renderer.RenderError(fmt.Errorf("%s", msg)), "\n"))
	136	+	err := fmt.Errorf("%s", msg)
	137	+	fmt.Fprintln(os.Stderr, strings.TrimRight(renderer.RenderError(err), "\n"))
	138	+	return wrapPrintedError(err)
133	139		}
134	140
135	141		// Keep this a simple, non-interactive message; the actual editor takes over the terminal.

@@ -141,7 +147,9 @@ func runConfigOpen(_ *cobra.Command, _ []string) error {
141	147		cmd.Stderr = os.Stderr
142	148
143	149		if err := cmd.Run(); err != nil {
144		-	return fmt.Errorf("%s", strings.TrimRight(renderer.RenderError(fmt.Errorf("open config: %w", err)), "\n"))
	150	+	wrappedErr := fmt.Errorf("open config: %w", err)
	151	+	fmt.Fprintln(os.Stderr, strings.TrimRight(renderer.RenderError(wrappedErr), "\n"))
	152	+	return wrapPrintedError(wrappedErr)
145	153		}
146	154		return nil
147	155		}

 	configFile, err := config.GetConfigFile()
 	if err != nil {
-		return fmt.Errorf("%s", strings.TrimRight(renderer.RenderError(fmt.Errorf("get config file: %w", err)), "\n"))
+		wrappedErr := fmt.Errorf("get config file: %w", err)
+		fmt.Fprintln(os.Stderr, strings.TrimRight(renderer.RenderError(wrappedErr), "\n"))
+		return wrapPrintedError(wrappedErr)
 	}
 	// Check if config file exists
 	if _, statErr := os.Stat(configFile); os.IsNotExist(statErr) {
-		return fmt.Errorf("%s", strings.TrimRight(renderer.RenderError(fmt.Errorf("config file does not exist: %s", configFile)), "\n"))
+		err := fmt.Errorf("config file does not exist: %s", configFile)
+		fmt.Fprintln(os.Stderr, strings.TrimRight(renderer.RenderError(err), "\n"))
+		return wrapPrintedError(err)
 	}
 	editor := getEditor()
 	if editor == "" {
 		const msg = "no editor found: set $EDITOR or $VISUAL environment variable"
-		return fmt.Errorf("%s", strings.TrimRight(renderer.RenderError(fmt.Errorf("%s", msg)), "\n"))
+		err := fmt.Errorf("%s", msg)
+		fmt.Fprintln(os.Stderr, strings.TrimRight(renderer.RenderError(err), "\n"))
+		return wrapPrintedError(err)
 	}
 	// Keep this a simple, non-interactive message; the actual editor takes over the terminal.
 	cmd.Stderr = os.Stderr
 	if err := cmd.Run(); err != nil {
-		return fmt.Errorf("%s", strings.TrimRight(renderer.RenderError(fmt.Errorf("open config: %w", err)), "\n"))
+		wrappedErr := fmt.Errorf("open config: %w", err)
+		fmt.Fprintln(os.Stderr, strings.TrimRight(renderer.RenderError(wrappedErr), "\n"))
+		return wrapPrintedError(wrappedErr)
 	}
 	return nil
 }