chore(logging): remove excessive debug spam from omnibox suggestions

Removed 8 DEBUG log statements that fired on every keystroke:
- Handling query message
- handleQuery called
- Searching history
- Found X history entries
- History entry details
- Final results count
- Injecting omnibox suggestions
- Successfully injected

Also removed ERROR/WARN logs for nil checks that are now early returns.
Silent operation unless actual errors occur - KISS principle.

commit: f79d84b3af66e3cef799cca561787d6b8d1a9f87
author: bnema · 12mo ago · 2025-10-24 05:37 UTC
committer: bnema · 12mo ago · 2025-10-24 17:33 UTC
parent: 3f362d6
signature: GPG Unverified2B82207D370127A0 The key is unknown

2 files · +6 -26

M internal/app/messaging/handler.go +5 -26


@@ -82,9 +82,7 @@ func (h *Handler) Handle(payload string) {
82	82		case "navigate":
83	83		h.handleNavigation(msg)
84	84		case "query":
85		-	log.Printf("[DEBUG] Handling query message: q=%s, limit=%d", msg.Q, msg.Limit)
86	85		if h.webView == nil {
87		-	log.Printf("[WARN] Dropping query response: webview unavailable for suggestions")
88	86		return
89	87		}
90	88		h.handleQuery(msg)

@@ -200,13 +198,7 @@ func (h *Handler) handleClosePopup(msg Message) {
200	198		}
201	199
202	200		func (h *Handler) handleQuery(msg Message) {
203		-	if h.webView == nil {
204		-	log.Printf("[WARN] Skipping query handling: webview is nil")
205		-	return
206		-	}
207		-	log.Printf("[DEBUG] handleQuery called: q='%s', limit=%d", msg.Q, msg.Limit)
208		-	if h.browserService == nil {
209		-	log.Printf("[ERROR] handleQuery: browserService is nil")
	201	+	if h.webView == nil \|\| h.browserService == nil {
210	202		return
211	203		}
212	204		ctx := context.Background()

@@ -233,12 +225,8 @@ func (h *Handler) handleQuery(msg Message) {
233	225		// History
234	226		if len(results) < limit {
235	227		remaining := limit - len(results)
236		-	log.Printf("[DEBUG] Searching history for '%s' with limit %d", q, remaining)
237		-	if entries, err := h.browserService.SearchHistory(ctx, q, remaining); err != nil {
238		-	log.Printf("[ERROR] Failed to search history: %v", err)
239		-	} else {
240		-	log.Printf("[DEBUG] Found %d history entries", len(entries))
241		-	for i, e := range entries {
	228	+	if entries, err := h.browserService.SearchHistory(ctx, q, remaining); err == nil {
	229	+	for _, e := range entries {
242	230		// JSON roundtrip to map to get url field agnostic of struct tag
243	231		bb, _ := json.Marshal(e)
244	232		var m map[string]any

@@ -249,7 +237,6 @@ func (h *Handler) handleQuery(msg Message) {
249	237		} else if s, ok := m["URL"].(string); ok {
250	238		url = s
251	239		}
252		-	log.Printf("[DEBUG] History entry %d: url=%s", i, url)
253	240		if url == "" {
254	241		continue
255	242		}

@@ -271,18 +258,10 @@ func (h *Handler) handleQuery(msg Message) {
271	258		}
272	259
273	260		// Inject back to GUI
274		-	log.Printf("[DEBUG] Final results count: %d", len(results))
275		-	if b, err := json.Marshal(results); err != nil {
276		-	log.Printf("[ERROR] Failed to marshal results: %v", err)
277		-	} else {
	261	+	if b, err := json.Marshal(results); err == nil {
278	262		// Prefer unified page-world API; fallback to legacy global function
279	263		script := "(window.__dumber?.omnibox?.suggestions ? window.__dumber.omnibox.suggestions(" + string(b) + ") : (window.__dumber_omnibox_suggestions && window.__dumber_omnibox_suggestions(" + string(b) + ")))"
280		-	log.Print("[DEBUG] Injecting omnibox suggestions")
281		-	if injErr := h.webView.InjectScript(script); injErr != nil {
282		-	log.Printf("[ERROR] Failed to inject suggestions script: %v", injErr)
283		-	} else {
284		-	log.Printf("[DEBUG] Successfully injected omnibox suggestions")
285		-	}
	264	+	h.webView.InjectScript(script)
286	265		}
287	266		}
288	267

 	case "navigate":
 		h.handleNavigation(msg)
 	case "query":
-		log.Printf("[DEBUG] Handling query message: q=%s, limit=%d", msg.Q, msg.Limit)
 		if h.webView == nil {
-			log.Printf("[WARN] Dropping query response: webview unavailable for suggestions")
 			return
 		}
 		h.handleQuery(msg)
 }
 func (h *Handler) handleQuery(msg Message) {
-	if h.webView == nil {
+	if h.webView == nil || h.browserService == nil {
-		log.Printf("[WARN] Skipping query handling: webview is nil")
-		return
-	}
-	log.Printf("[DEBUG] handleQuery called: q='%s', limit=%d", msg.Q, msg.Limit)
-	if h.browserService == nil {
-		log.Printf("[ERROR] handleQuery: browserService is nil")
 		return
 	}
 	ctx := context.Background()
 	// History
 	if len(results) < limit {
 		remaining := limit - len(results)
-		log.Printf("[DEBUG] Searching history for '%s' with limit %d", q, remaining)
+		if entries, err := h.browserService.SearchHistory(ctx, q, remaining); err == nil {
-		if entries, err := h.browserService.SearchHistory(ctx, q, remaining); err != nil {
+			for _, e := range entries {
-			log.Printf("[ERROR] Failed to search history: %v", err)
-		} else {
-			log.Printf("[DEBUG] Found %d history entries", len(entries))
-			for i, e := range entries {
 				// JSON roundtrip to map to get url field agnostic of struct tag
 				bb, _ := json.Marshal(e)
 				var m map[string]any
 				} else if s, ok := m["URL"].(string); ok {
 					url = s
 				}
-				log.Printf("[DEBUG] History entry %d: url=%s", i, url)
 				if url == "" {
 					continue
 				}
 	}
 	// Inject back to GUI
-	log.Printf("[DEBUG] Final results count: %d", len(results))
+	if b, err := json.Marshal(results); err == nil {
-	if b, err := json.Marshal(results); err != nil {
-		log.Printf("[ERROR] Failed to marshal results: %v", err)
-	} else {
 		// Prefer unified page-world API; fallback to legacy global function
 		script := "(window.__dumber?.omnibox?.suggestions ? window.__dumber.omnibox.suggestions(" + string(b) + ") : (window.__dumber_omnibox_suggestions && window.__dumber_omnibox_suggestions(" + string(b) + ")))"
-		log.Print("[DEBUG] Injecting omnibox suggestions")
+		h.webView.InjectScript(script)
-		if injErr := h.webView.InjectScript(script); injErr != nil {
-			log.Printf("[ERROR] Failed to inject suggestions script: %v", injErr)
-		} else {
-			log.Printf("[DEBUG] Successfully injected omnibox suggestions")
-		}
 	}
 }

M pkg/webkit/webview.go +1 -0


@@ -6,6 +6,7 @@ import (
6	6		"log"
7	7		"strconv"
8	8		"sync"
	9	+	"sync/atomic"
9	10
10	11		webkit "github.com/diamondburned/gotk4-webkitgtk/pkg/webkit/v6"
11	12		"github.com/diamondburned/gotk4/pkg/gdk/v4"


@@ -6,6 +6,7 @@ import (
6	"log"	6		"log"
7	"strconv"	7		"strconv"
8	"sync"	8		"sync"
		9	+	"sync/atomic"
9		10
10	webkit "github.com/diamondburned/gotk4-webkitgtk/pkg/webkit/v6"	11		webkit "github.com/diamondburned/gotk4-webkitgtk/pkg/webkit/v6"
11	"github.com/diamondburned/gotk4/pkg/gdk/v4"	12		"github.com/diamondburned/gotk4/pkg/gdk/v4"