test(expr): pass the nil context through a variable (staticcheck SA1012)

commit: 73aa774d7606894e11858e50f0f70123d82a619b
author: brice · 9d ago · 2026-10-13 14:05 UTC
committer: brice · 4d ago · 2026-10-18 14:59 UTC
parent: a2f934c
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +4 -3

M expr/limits_test.go +4 -3


@@ -204,9 +204,10 @@ func TestEvaluateContextCancellation(t *testing.T) {
204	204		if _, err = Evaluate(ctx, mustParse(t, "contains(big, 'nope')", []string{"big"}, nil), EvalContext{Contexts: map[string]Value{"big": arr}}); !errors.Is(err, context.DeadlineExceeded) {
205	205		t.Errorf("deadline: err = %v", err)
206	206		}
207		-	// A nil context behaves as Background.
208		-	//nolint:staticcheck // deliberately passing nil
209		-	if v, err := Evaluate(nil, n, EvalContext{}); err != nil \|\| v != Boolean(true) {
	207	+	// A nil context behaves as Background. (Through a variable: passing a nil
	208	+	// literal is what staticcheck SA1012 flags.)
	209	+	var nilCtx context.Context
	210	+	if v, err := Evaluate(nilCtx, n, EvalContext{}); err != nil \|\| v != Boolean(true) {
210	211		t.Errorf("nil context: %v, %v", v, err)
211	212		}
212	213		}

 	if _, err = Evaluate(ctx, mustParse(t, "contains(big, 'nope')", []string{"big"}, nil), EvalContext{Contexts: map[string]Value{"big": arr}}); !errors.Is(err, context.DeadlineExceeded) {
 		t.Errorf("deadline: err = %v", err)
 	}
-	// A nil context behaves as Background.
+	// A nil context behaves as Background. (Through a variable: passing a nil
-	//nolint:staticcheck // deliberately passing nil
+	// literal is what staticcheck SA1012 flags.)
-	if v, err := Evaluate(nil, n, EvalContext{}); err != nil || v != Boolean(true) {
+	var nilCtx context.Context
+	if v, err := Evaluate(nilCtx, n, EvalContext{}); err != nil || v != Boolean(true) {
 		t.Errorf("nil context: %v, %v", v, err)
 	}
 }