fix(proto): keep failing_checks_block as a deprecated field instead of removing it

commit: e4b332d4ee65c3da47f730b86c499f3a7230935a
author: brice · 31h ago · 2026-10-21 14:11 UTC
parent: d1c609e
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
checks: 4/4
refs: tag: v0.15.0

2 files · +20 -6

M gen/ermite/repo.pb.go +17 -3


@@ -146,6 +146,11 @@ type RepoSettings struct {
146	146		// duplicate. Every mode is allowed by default. MERGE_MODE_UNSPECIFIED is
147	147		// rejected.
148	148		AllowedMergeModes []MergeMode `protobuf:"varint,1,rep,packed,name=allowed_merge_modes,json=allowedMergeModes,proto3,enum=ermite.MergeMode" json:"allowed_merge_modes,omitempty"`
	149	+	// FailingChecksBlock is unused: servers ignore it and never set it. A merge
	150	+	// needs passing checks unless MergeMergeRequestRequest.ignore_checks is set.
	151	+	//
	152	+	// Deprecated: Marked as deprecated in ermite/repo.proto.
	153	+	FailingChecksBlock bool `protobuf:"varint,2,opt,name=failing_checks_block,json=failingChecksBlock,proto3" json:"failing_checks_block,omitempty"`
149	154		// Issues is the issue participation mode of the repository.
150	155		Issues IssuesMode `protobuf:"varint,3,opt,name=issues,proto3,enum=ermite.IssuesMode" json:"issues,omitempty"`
151	156		// AllowAutoMerge says whether auto-merge can be enabled on the merge requests

@@ -193,6 +198,14 @@ func (x *RepoSettings) GetAllowedMergeModes() []MergeMode {
193	198		return nil
194	199		}
195	200
	201	+	// Deprecated: Marked as deprecated in ermite/repo.proto.
	202	+	func (x *RepoSettings) GetFailingChecksBlock() bool {
	203	+	if x != nil {
	204	+	return x.FailingChecksBlock
	205	+	}
	206	+	return false
	207	+	}
	208	+
196	209		func (x *RepoSettings) GetIssues() IssuesMode {
197	210		if x != nil {
198	211		return x.Issues

@@ -910,11 +923,12 @@ var File_ermite_repo_proto protoreflect.FileDescriptor
910	923
911	924		const file_ermite_repo_proto_rawDesc = "" +
912	925		"\n" +
913		-	"\x11ermite/repo.proto\x12\x06ermite\x1a google/protobuf/field_mask.proto\x1a\x12ermite/types.proto\x1a\x1fgoogle/protobuf/timestamp.proto\"\xc3\x01\n" +
	926	+	"\x11ermite/repo.proto\x12\x06ermite\x1a google/protobuf/field_mask.proto\x1a\x12ermite/types.proto\x1a\x1fgoogle/protobuf/timestamp.proto\"\xdd\x01\n" +
914	927		"\fRepoSettings\x12A\n" +
915		-	"\x13allowed_merge_modes\x18\x01 \x03(\x0e2\x11.ermite.MergeModeR\x11allowedMergeModes\x12*\n" +
	928	+	"\x13allowed_merge_modes\x18\x01 \x03(\x0e2\x11.ermite.MergeModeR\x11allowedMergeModes\x124\n" +
	929	+	"\x14failing_checks_block\x18\x02 \x01(\bB\x02\x18\x01R\x12failingChecksBlock\x12*\n" +
916	930		"\x06issues\x18\x03 \x01(\x0e2\x12.ermite.IssuesModeR\x06issues\x12(\n" +
917		-	"\x10allow_auto_merge\x18\x04 \x01(\bR\x0eallowAutoMergeJ\x04\b\x02\x10\x03R\x14failing_checks_block\"\xd5\x02\n" +
	931	+	"\x10allow_auto_merge\x18\x04 \x01(\bR\x0eallowAutoMerge\"\xd5\x02\n" +
918	932		"\x04Repo\x12\x12\n" +
919	933		"\x04name\x18\x01 \x01(\tR\x04name\x12 \n" +
920	934		"\vdescription\x18\x02 \x01(\tR\vdescription\x122\n" +

 	// duplicate. Every mode is allowed by default. MERGE_MODE_UNSPECIFIED is
 	// rejected.
 	AllowedMergeModes []MergeMode `protobuf:"varint,1,rep,packed,name=allowed_merge_modes,json=allowedMergeModes,proto3,enum=ermite.MergeMode" json:"allowed_merge_modes,omitempty"`
+	// FailingChecksBlock is unused: servers ignore it and never set it. A merge
+	// needs passing checks unless MergeMergeRequestRequest.ignore_checks is set.
+	//
+	// Deprecated: Marked as deprecated in ermite/repo.proto.
+	FailingChecksBlock bool `protobuf:"varint,2,opt,name=failing_checks_block,json=failingChecksBlock,proto3" json:"failing_checks_block,omitempty"`
 	// Issues is the issue participation mode of the repository.
 	Issues IssuesMode `protobuf:"varint,3,opt,name=issues,proto3,enum=ermite.IssuesMode" json:"issues,omitempty"`
 	// AllowAutoMerge says whether auto-merge can be enabled on the merge requests
 	return nil
 }
+// Deprecated: Marked as deprecated in ermite/repo.proto.
+func (x *RepoSettings) GetFailingChecksBlock() bool {
+	if x != nil {
+		return x.FailingChecksBlock
+	}
+	return false
+}
 func (x *RepoSettings) GetIssues() IssuesMode {
 	if x != nil {
 		return x.Issues
 const file_ermite_repo_proto_rawDesc = "" +
 	"\n" +
-	"\x11ermite/repo.proto\x12\x06ermite\x1a google/protobuf/field_mask.proto\x1a\x12ermite/types.proto\x1a\x1fgoogle/protobuf/timestamp.proto\"\xc3\x01\n" +
+	"\x11ermite/repo.proto\x12\x06ermite\x1a google/protobuf/field_mask.proto\x1a\x12ermite/types.proto\x1a\x1fgoogle/protobuf/timestamp.proto\"\xdd\x01\n" +
 	"\fRepoSettings\x12A\n" +
-	"\x13allowed_merge_modes\x18\x01 \x03(\x0e2\x11.ermite.MergeModeR\x11allowedMergeModes\x12*\n" +
+	"\x13allowed_merge_modes\x18\x01 \x03(\x0e2\x11.ermite.MergeModeR\x11allowedMergeModes\x124\n" +
+	"\x14failing_checks_block\x18\x02 \x01(\bB\x02\x18\x01R\x12failingChecksBlock\x12*\n" +
 	"\x06issues\x18\x03 \x01(\x0e2\x12.ermite.IssuesModeR\x06issues\x12(\n" +
-	"\x10allow_auto_merge\x18\x04 \x01(\bR\x0eallowAutoMergeJ\x04\b\x02\x10\x03R\x14failing_checks_block\"\xd5\x02\n" +
+	"\x10allow_auto_merge\x18\x04 \x01(\bR\x0eallowAutoMerge\"\xd5\x02\n" +
 	"\x04Repo\x12\x12\n" +
 	"\x04name\x18\x01 \x01(\tR\x04name\x12 \n" +
 	"\vdescription\x18\x02 \x01(\tR\vdescription\x122\n" +

M proto/ermite/repo.proto +3 -3


@@ -35,14 +35,14 @@ enum IssuesMode {
35	35		// RepoSettings are the settings of a repository that govern its merge
36	36		// requests and issues.
37	37		message RepoSettings {
38		-	reserved 2;
39		-	reserved "failing_checks_block";
40		-
41	38		// AllowedMergeModes are the modes with which a merge request of the
42	39		// repository may be merged. It is never empty in a response and has no
43	40		// duplicate. Every mode is allowed by default. MERGE_MODE_UNSPECIFIED is
44	41		// rejected.
45	42		repeated MergeMode allowed_merge_modes = 1;
	43	+	// FailingChecksBlock is unused: servers ignore it and never set it. A merge
	44	+	// needs passing checks unless MergeMergeRequestRequest.ignore_checks is set.
	45	+	bool failing_checks_block = 2 [deprecated = true];
46	46		// Issues is the issue participation mode of the repository.
47	47		IssuesMode issues = 3;
48	48		// AllowAutoMerge says whether auto-merge can be enabled on the merge requests

 // RepoSettings are the settings of a repository that govern its merge
 // requests and issues.
 message RepoSettings {
-  reserved 2;
-  reserved "failing_checks_block";
   // AllowedMergeModes are the modes with which a merge request of the
   // repository may be merged. It is never empty in a response and has no
   // duplicate. Every mode is allowed by default. MERGE_MODE_UNSPECIFIED is
   // rejected.
   repeated MergeMode allowed_merge_modes = 1;
+  // FailingChecksBlock is unused: servers ignore it and never set it. A merge
+  // needs passing checks unless MergeMergeRequestRequest.ignore_checks is set.
+  bool failing_checks_block = 2 [deprecated = true];
   // Issues is the issue participation mode of the repository.
   IssuesMode issues = 3;
   // AllowAutoMerge says whether auto-merge can be enabled on the merge requests