Follow-up of !3. MergeRequestMergeability is published for every result the server settles for new tips of the source or target branch (one event per result, the state may repeat). A push that moves neither branch publishes nothing. docs/services.md says the same.
Comment-only change: no field or number changes. buf lint and go test pass.
| @@ -5,7 +5,7 @@ | |||
| 5 | 5 | | `RepoService` | `ListRepos`, `GetRepo`, `CreateRepo`, `UpdateRepo` (field mask, merge settings), `DeleteRepo` | | |
| 6 | 6 | | `GitService` | `ListRefs`, `GetTree`, `ListPaths`, `GetBlob` (streamed), `ListCommits`, `GetCommit` (structured diff), `ResolveRevision` | | |
| 7 | 7 | | `TokenService` | `CreateToken` (secret shown once), `ListTokens`, `RevokeToken` | | |
| 8 | - | | `MergeRequestService` | `CreateMergeRequest`, `ListMergeRequests`, `GetMergeRequest` (commits, diff, comments), `AddComment`, `EditComment`, `DeleteComment`, `ResolveComment`, `CloseMergeRequest`, `MergeMergeRequest` (modes fast-forward, squash, merge commit), `MarkRead`. Open merge requests carry `mergeability` (up to date, behind, conflict, or checking) and `Watch` publishes `MergeRequestMergeability` when it changes (feature `merge_requests.mergeability`) | | |
| 8 | + | | `MergeRequestService` | `CreateMergeRequest`, `ListMergeRequests`, `GetMergeRequest` (commits, diff, comments), `AddComment`, `EditComment`, `DeleteComment`, `ResolveComment`, `CloseMergeRequest`, `MergeMergeRequest` (modes fast-forward, squash, merge commit), `MarkRead`. Open merge requests carry `mergeability` (up to date, behind, conflict, or checking) and `Watch` publishes `MergeRequestMergeability` each time a result is settled for new branch tips (feature `merge_requests.mergeability`) | | |
| 9 | 9 | | `IssueService` | `CreateIssue`, `ListIssues`, `GetIssue` (comments), `AddIssueComment`, `CloseIssue`, `ReopenIssue`; owner only: `ListPendingIssues`, `ApproveIssue`, `RejectIssue`. Feature `issues`. Issues share numbers with merge requests | | |
| 10 | 10 | | `SessionService` | `CreateLoginLink`, `SignOutEverywhere` (owner only) | | |
| 11 | 11 | | `EventService` | `Watch` (streamed, resumable). Topics `home`, `repo:<name>` and `owner` (owner rights only). Events 17–21: `issue_opened`, `issue_closed`, `issue_reopened`, `issue_commented`, and `issue_submitted` (only on `owner`, no content). Event 22: `merge_request_mergeability` | | |
| @@ -5,7 +5,7 @@ | |||||
| 5 | | `RepoService` | `ListRepos`, `GetRepo`, `CreateRepo`, `UpdateRepo` (field mask, merge settings), `DeleteRepo` | | 5 | | `RepoService` | `ListRepos`, `GetRepo`, `CreateRepo`, `UpdateRepo` (field mask, merge settings), `DeleteRepo` | | ||
| 6 | | `GitService` | `ListRefs`, `GetTree`, `ListPaths`, `GetBlob` (streamed), `ListCommits`, `GetCommit` (structured diff), `ResolveRevision` | | 6 | | `GitService` | `ListRefs`, `GetTree`, `ListPaths`, `GetBlob` (streamed), `ListCommits`, `GetCommit` (structured diff), `ResolveRevision` | | ||
| 7 | | `TokenService` | `CreateToken` (secret shown once), `ListTokens`, `RevokeToken` | | 7 | | `TokenService` | `CreateToken` (secret shown once), `ListTokens`, `RevokeToken` | | ||
| 8 | - | | `MergeRequestService` | `CreateMergeRequest`, `ListMergeRequests`, `GetMergeRequest` (commits, diff, comments), `AddComment`, `EditComment`, `DeleteComment`, `ResolveComment`, `CloseMergeRequest`, `MergeMergeRequest` (modes fast-forward, squash, merge commit), `MarkRead`. Open merge requests carry `mergeability` (up to date, behind, conflict, or checking) and `Watch` publishes `MergeRequestMergeability` when it changes (feature `merge_requests.mergeability`) | | 8 | + | | `MergeRequestService` | `CreateMergeRequest`, `ListMergeRequests`, `GetMergeRequest` (commits, diff, comments), `AddComment`, `EditComment`, `DeleteComment`, `ResolveComment`, `CloseMergeRequest`, `MergeMergeRequest` (modes fast-forward, squash, merge commit), `MarkRead`. Open merge requests carry `mergeability` (up to date, behind, conflict, or checking) and `Watch` publishes `MergeRequestMergeability` each time a result is settled for new branch tips (feature `merge_requests.mergeability`) | |
| 9 | | `IssueService` | `CreateIssue`, `ListIssues`, `GetIssue` (comments), `AddIssueComment`, `CloseIssue`, `ReopenIssue`; owner only: `ListPendingIssues`, `ApproveIssue`, `RejectIssue`. Feature `issues`. Issues share numbers with merge requests | | 9 | | `IssueService` | `CreateIssue`, `ListIssues`, `GetIssue` (comments), `AddIssueComment`, `CloseIssue`, `ReopenIssue`; owner only: `ListPendingIssues`, `ApproveIssue`, `RejectIssue`. Feature `issues`. Issues share numbers with merge requests | | ||
| 10 | | `SessionService` | `CreateLoginLink`, `SignOutEverywhere` (owner only) | | 10 | | `SessionService` | `CreateLoginLink`, `SignOutEverywhere` (owner only) | | ||
| 11 | | `EventService` | `Watch` (streamed, resumable). Topics `home`, `repo:<name>` and `owner` (owner rights only). Events 17–21: `issue_opened`, `issue_closed`, `issue_reopened`, `issue_commented`, and `issue_submitted` (only on `owner`, no content). Event 22: `merge_request_mergeability` | | 11 | | `EventService` | `Watch` (streamed, resumable). Topics `home`, `repo:<name>` and `owner` (owner rights only). Events 17–21: `issue_opened`, `issue_closed`, `issue_reopened`, `issue_commented`, and `issue_submitted` (only on `owner`, no content). Event 22: `merge_request_mergeability` | | ||
| @@ -904,8 +904,9 @@ func (x *MergeRequestMerged) GetMergeRequest() *MergeRequest { | |||
| 904 | 904 | } | |
| 905 | 905 | ||
| 906 | 906 | // MergeRequestMergeability reports the mergeability of an open merge request. | |
| 907 | - | // It is published when the state changes, or when a check settles a result | |
| 908 | - | // that readers had not seen yet (they saw CHECKING), not on every push. | |
| 907 | + | // It is published each time the server settles a result for new tips of the | |
| 908 | + | // source or target branch, so the state may be the same as the previous | |
| 909 | + | // event's. A push that moves neither branch publishes nothing. | |
| 909 | 910 | type MergeRequestMergeability struct { | |
| 910 | 911 | state protoimpl.MessageState `protogen:"open.v1"` | |
| 911 | 912 | // Repo is the name of the repository. | |
| @@ -904,8 +904,9 @@ func (x *MergeRequestMerged) GetMergeRequest() *MergeRequest { | |||||
| 904 | } | 904 | } | ||
| 905 | 905 | ||||
| 906 | // MergeRequestMergeability reports the mergeability of an open merge request. | 906 | // MergeRequestMergeability reports the mergeability of an open merge request. | ||
| 907 | - | // It is published when the state changes, or when a check settles a result | 907 | + | // It is published each time the server settles a result for new tips of the |
| 908 | - | // that readers had not seen yet (they saw CHECKING), not on every push. | 908 | + | // source or target branch, so the state may be the same as the previous |
| 909 | + | // event's. A push that moves neither branch publishes nothing. | |||
| 909 | type MergeRequestMergeability struct { | 910 | type MergeRequestMergeability struct { | ||
| 910 | state protoimpl.MessageState `protogen:"open.v1"` | 911 | state protoimpl.MessageState `protogen:"open.v1"` | ||
| 911 | // Repo is the name of the repository. | 912 | // Repo is the name of the repository. | ||
| @@ -188,8 +188,9 @@ message MergeRequestMerged { | |||
| 188 | 188 | } | |
| 189 | 189 | ||
| 190 | 190 | // MergeRequestMergeability reports the mergeability of an open merge request. | |
| 191 | - | // It is published when the state changes, or when a check settles a result | |
| 192 | - | // that readers had not seen yet (they saw CHECKING), not on every push. | |
| 191 | + | // It is published each time the server settles a result for new tips of the | |
| 192 | + | // source or target branch, so the state may be the same as the previous | |
| 193 | + | // event's. A push that moves neither branch publishes nothing. | |
| 193 | 194 | message MergeRequestMergeability { | |
| 194 | 195 | // Repo is the name of the repository. | |
| 195 | 196 | string repo = 1; | |
| @@ -188,8 +188,9 @@ message MergeRequestMerged { | |||||
| 188 | } | 188 | } | ||
| 189 | 189 | ||||
| 190 | // MergeRequestMergeability reports the mergeability of an open merge request. | 190 | // MergeRequestMergeability reports the mergeability of an open merge request. | ||
| 191 | - | // It is published when the state changes, or when a check settles a result | 191 | + | // It is published each time the server settles a result for new tips of the |
| 192 | - | // that readers had not seen yet (they saw CHECKING), not on every push. | 192 | + | // source or target branch, so the state may be the same as the previous |
| 193 | + | // event's. A push that moves neither branch publishes nothing. | |||
| 193 | message MergeRequestMergeability { | 194 | message MergeRequestMergeability { | ||
| 194 | // Repo is the name of the repository. | 195 | // Repo is the name of the repository. | ||
| 195 | string repo = 1; | 196 | string repo = 1; | ||
no comments yet.