detached 3945367

fix(web): enable the merge button after choosing a mode by keyboard

commit
39453670b4cd54668bf0f9537d60b183acacb339
author
brice · · 2026-10-19 14:34 UTC
committer
brice · · 2026-10-19 14:37 UTC
parent
72d0556
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +6 -1
M internal/adapters/web/static/js/mr.js +6 -1
@@ -219,7 +219,12 @@ window.ermiteMR = (() => {
219219 const box = $('input[name="delete_branch"]', m);
220220 if (box) box.checked = !box.checked;
221221 } else {
222- if (!radios[act.mode].disabled) radios[act.mode].checked = true;
222+ const r = radios[act.mode];
223+ // A change event lets the live bindings enable the Merge button again.
224+ if (!r.disabled && !r.checked) {
225+ r.checked = true;
226+ r.dispatchEvent(new Event('change', { bubbles: true }));
227+ }
223228 }
224229 $('[data-default]', m)?.focus();
225230 return true;
@@ -219,7 +219,12 @@ window.ermiteMR = (() => {
219 const box = $('input[name="delete_branch"]', m);219 const box = $('input[name="delete_branch"]', m);
220 if (box) box.checked = !box.checked;220 if (box) box.checked = !box.checked;
221 } else {221 } else {
222- if (!radios[act.mode].disabled) radios[act.mode].checked = true;222+ const r = radios[act.mode];
223+ // A change event lets the live bindings enable the Merge button again.
224+ if (!r.disabled && !r.checked) {
225+ r.checked = true;
226+ r.dispatchEvent(new Event('change', { bubbles: true }));
227+ }
223 }228 }
224 $('[data-default]', m)?.focus();229 $('[data-default]', m)?.focus();
225 return true;230 return true;

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 4

Tags 45

↑↓ moveenter openesc close