#18 feat(issues): link issues and merge requests

M docs/cli.md +1 -0


@@ -61,6 +61,7 @@ ermite mr merge <repo> <n> --head <id> [--mode fast-forward\|squash\|merge] [--del
61	61
62	62		ermite issue create <repo> --title … [--body … \| --body-file …] \| list <repo> [--state open\|closed\|all]
63	63		ermite issue show <repo> <n> \| comment <repo> <n> -m … \| close <repo> <n> \| reopen <repo> <n>
	64	+	# issue show prints `closed by !N` when a merge closed it, and a `merge requests (K)` block (`!5 open <title> · closes`); --json adds closed_by_merge_request and references
64	65
65	66		ermite run list <repo> [--workflow …] [--branch …] [--status …]
66	67		ermite run view <repo> <id> [--attempt n] [--log [--job …]] [--summary]


@@ -61,6 +61,7 @@ ermite mr merge <repo> <n> --head <id> [--mode fast-forward\|squash\|merge] [--del
61		61
62	ermite issue create <repo> --title … [--body … \| --body-file …] \| list <repo> [--state open\|closed\|all]	62		ermite issue create <repo> --title … [--body … \| --body-file …] \| list <repo> [--state open\|closed\|all]
63	ermite issue show <repo> <n> \| comment <repo> <n> -m … \| close <repo> <n> \| reopen <repo> <n>	63		ermite issue show <repo> <n> \| comment <repo> <n> -m … \| close <repo> <n> \| reopen <repo> <n>
		64	+	# issue show prints `closed by !N` when a merge closed it, and a `merge requests (K)` block (`!5 open <title> · closes`); --json adds closed_by_merge_request and references
64		65
65	ermite run list <repo> [--workflow …] [--branch …] [--status …]	66		ermite run list <repo> [--workflow …] [--branch …] [--status …]
66	ermite run view <repo> <id> [--attempt n] [--log [--job …]] [--summary]	67		ermite run view <repo> <id> [--attempt n] [--log [--job …]] [--summary]

M docs/issues.md +12 -0


@@ -34,6 +34,18 @@ ermite token create claude --preset agent --scope issue:write --repo <repo> --br
34	34
35	35		Merge requests and issues of a repository draw `#n` from one sequence, so a number names one thing: `ermite mr show myrepo 1`, `ermite issue show myrepo 2`.
36	36
	37	+	## Merge request links
	38	+
	39	+	A merge request and the issues of its repository are linked by `#N` in its text:
	40	+
	41	+	- Closing keywords close the issue when the merge request is merged, and only then: `close`, `closes`, `closed`, `fix`, `fixes`, `fixed`, `resolve`, `resolves`, `resolved` (any case), then `#N`, with an optional `:` after the keyword. A list works: `fixes #3, #4 and #5`. They count in the title, the description and the commit messages, not in notes. Closing the merge request without merging closes nothing.
	42	+	- Any `#N` in the title, description, notes or commit messages shows the merge request on the issue (`ermite issue show`, the API `references`), with its state and whether it closes the issue.
	43	+	- A closed issue records the merge request that closed it ("closed by !N"). Reopening or closing by hand clears it.
	44	+	- The links are recomputed whenever the merge request changes (a note added, edited or deleted, a push to its branch, a merge), so removing a mention removes the link.
	45	+	- Words glued to the number (`abc#3`), `'` and `##3` are not references. Code spans are not skipped.
	46	+
	47	+	Limits: the 100 most recent commits of the merge request, 16 KiB of each text, 100 merge requests listed per issue. Only numbers of existing issues are linked: a mention of a number that does not exist yet is not filled in later. With issues `off`, nothing is closed.
	48	+
37	49		## Inbox
38	50
39	51		The signed-in owner has an Inbox at `/-/inbox`, reached from the Inbox button at the top left of the home page, which shows the number of open items. It lists the open merge requests and the open issues of every repository, most recently updated first. The counters at the top (`N merge requests · M issues`) always count everything; `?repo=<name>` restricts the two lists to one repository, and the repository links under the counters set it. Repositories with issues off contribute no issues.


@@ -34,6 +34,18 @@ ermite token create claude --preset agent --scope issue:write --repo <repo> --br
34		34
35	Merge requests and issues of a repository draw `#n` from one sequence, so a number names one thing: `ermite mr show myrepo 1`, `ermite issue show myrepo 2`.	35		Merge requests and issues of a repository draw `#n` from one sequence, so a number names one thing: `ermite mr show myrepo 1`, `ermite issue show myrepo 2`.
36		36
		37	+	## Merge request links
		38	+
		39	+	A merge request and the issues of its repository are linked by `#N` in its text:
		40	+
		41	+	- Closing keywords close the issue when the merge request is merged, and only then: `close`, `closes`, `closed`, `fix`, `fixes`, `fixed`, `resolve`, `resolves`, `resolved` (any case), then `#N`, with an optional `:` after the keyword. A list works: `fixes #3, #4 and #5`. They count in the title, the description and the commit messages, not in notes. Closing the merge request without merging closes nothing.
		42	+	- Any `#N` in the title, description, notes or commit messages shows the merge request on the issue (`ermite issue show`, the API `references`), with its state and whether it closes the issue.
		43	+	- A closed issue records the merge request that closed it ("closed by !N"). Reopening or closing by hand clears it.
		44	+	- The links are recomputed whenever the merge request changes (a note added, edited or deleted, a push to its branch, a merge), so removing a mention removes the link.
		45	+	- Words glued to the number (`abc#3`), `'` and `##3` are not references. Code spans are not skipped.
		46	+
		47	+	Limits: the 100 most recent commits of the merge request, 16 KiB of each text, 100 merge requests listed per issue. Only numbers of existing issues are linked: a mention of a number that does not exist yet is not filled in later. With issues `off`, nothing is closed.
		48	+
37	## Inbox	49		## Inbox
38		50
39	The signed-in owner has an Inbox at `/-/inbox`, reached from the Inbox button at the top left of the home page, which shows the number of open items. It lists the open merge requests and the open issues of every repository, most recently updated first. The counters at the top (`N merge requests · M issues`) always count everything; `?repo=<name>` restricts the two lists to one repository, and the repository links under the counters set it. Repositories with issues off contribute no issues.	51		The signed-in owner has an Inbox at `/-/inbox`, reached from the Inbox button at the top left of the home page, which shows the number of open items. It lists the open merge requests and the open issues of every repository, most recently updated first. The counters at the top (`N merge requests · M issues`) always count everything; `?repo=<name>` restricts the two lists to one repository, and the repository links under the counters set it. Repositories with issues off contribute no issues.

M docs/merge-requests.md +2 -0


@@ -8,6 +8,8 @@ ermite mr show myrepo 1 --diff
8	8		ermite mr merge myrepo 1 --head <commit> [--mode fast-forward\|squash\|merge] [--delete-branch]
9	9		```
10	10
	11	+	Naming an issue with `#N` links it, and `Fixes #N` closes it on merge: see [issues](issues.md#merge-request-links).
	12	+
11	13		`ermite mr create` and `ermite mr close` print a confirmation followed by the full
12	14		merge request web URL on its own line. With `--json`, merge request objects
13	15		(create, show, list, close and merge) include `url` alongside the other fields.


@@ -8,6 +8,8 @@ ermite mr show myrepo 1 --diff
8	ermite mr merge myrepo 1 --head <commit> [--mode fast-forward\|squash\|merge] [--delete-branch]	8		ermite mr merge myrepo 1 --head <commit> [--mode fast-forward\|squash\|merge] [--delete-branch]
9	```	9		```
10		10
		11	+	Naming an issue with `#N` links it, and `Fixes #N` closes it on merge: see [issues](issues.md#merge-request-links).
		12	+
11	`ermite mr create` and `ermite mr close` print a confirmation followed by the full	13		`ermite mr create` and `ermite mr close` print a confirmation followed by the full
12	merge request web URL on its own line. With `--json`, merge request objects	14		merge request web URL on its own line. With `--json`, merge request objects
13	(create, show, list, close and merge) include `url` alongside the other fields.	15		(create, show, list, close and merge) include `url` alongside the other fields.

M gen/ermite/storage/issue.pb.go +146 -31 generated file: collapsed

load diff

M go.mod +1 -1


@@ -13,7 +13,7 @@ tool (
13	13
14	14		require (
15	15		bnema.dev/ermite-actions v0.2.0
16		-	bnema.dev/ermite-api v0.12.0
	16	+	bnema.dev/ermite-api v0.13.0
17	17		bnema.dev/ermite-git v0.1.0
18	18		bnema.dev/ermite-kv v0.1.0
19	19		connectrpc.com/connect v1.21.0


@@ -13,7 +13,7 @@ tool (
13			13
14		require (	14		require (
15		bnema.dev/ermite-actions v0.2.0	15		bnema.dev/ermite-actions v0.2.0
16	-	bnema.dev/ermite-api v0.12.0	16	+	bnema.dev/ermite-api v0.13.0
17		bnema.dev/ermite-git v0.1.0	17		bnema.dev/ermite-git v0.1.0
18		bnema.dev/ermite-kv v0.1.0	18		bnema.dev/ermite-kv v0.1.0
19		connectrpc.com/connect v1.21.0	19		connectrpc.com/connect v1.21.0

M go.sum +2 -2 generated file: collapsed

load diff

A internal/adapters/kvstore/issue_links.go +151 -0

@@ -0,0 +1,151 @@
	1	+	// SPDX-License-Identifier: AGPL-3.0-or-later
	2	+
	3	+	package kvstore
	4	+
	5	+	import (
	6	+	"context"
	7	+	"errors"
	8	+	"fmt"
	9	+	"slices"
	10	+	"strconv"
	11	+	"strings"
	12	+
	13	+	kv "bnema.dev/ermite-kv"
	14	+	storagepb "bnema.dev/ermite/gen/ermite/storage"
	15	+	"bnema.dev/ermite/internal/domain"
	16	+	"bnema.dev/ermite/internal/ports"
	17	+	"google.golang.org/protobuf/proto"
	18	+	)
	19	+
	20	+	const issueRefPrefix = "isref/"
	21	+	const mrRefPrefix = "mrref/"
	22	+
	23	+	// IssueLinks stores the derived issue-to-merge-request index.
	24	+	type IssueLinks struct{ db *kv.DB }
	25	+
	26	+	var _ ports.IssueLinkStore = (*IssueLinks)(nil)
	27	+
	28	+	// IssueLinks returns a link store sharing this Store's database and lifetime.
	29	+	func (s Store) IssueLinks() IssueLinks { return &IssueLinks{db: s.db} }
	30	+
	31	+	func mrRefKey(repo domain.RepoName, mr int64) []byte {
	32	+	return []byte(mrRefPrefix + repo.String() + "/" + fmt.Sprintf(numberFormat, mr))
	33	+	}
	34	+	func issueRefKeys(repo domain.RepoName, issue int64) string {
	35	+	return issueRefPrefix + repo.String() + "/" + fmt.Sprintf(numberFormat, issue) + "/"
	36	+	}
	37	+	func issueRefKey(repo domain.RepoName, issue, mr int64) []byte {
	38	+	return []byte(issueRefKeys(repo, issue) + fmt.Sprintf(numberFormat, mr))
	39	+	}
	40	+
	41	+	// ReplaceLinks atomically replaces both directions of the index.
	42	+	func (l *IssueLinks) ReplaceLinks(ctx context.Context, repo domain.RepoName, mr int64, issues, closes []int64) (added, removed []domain.IssueLink, err error) {
	43	+	key := mrRefKey(repo, mr)
	44	+	item, exists := l.db.Get(ctx, key)
	45	+	var old storagepb.MergeRequestReferences
	46	+	if exists {
	47	+	if err := proto.Unmarshal(item.Value, &old); err != nil {
	48	+	return nil, nil, fmt.Errorf("decode MR references: %w", err)
	49	+	}
	50	+	}
	51	+	issues = slices.Sorted(slices.Values(issues))
	52	+	issues = slices.Compact(issues)
	53	+	closes = slices.Sorted(slices.Values(closes))
	54	+	closes = slices.Compact(closes)
	55	+	for _, n := range issues {
	56	+	if n < 1 {
	57	+	return nil, nil, domain.ErrInvalid
	58	+	}
	59	+	}
	60	+	issueSet, closeSet := toSet(issues), toSet(closes)
	61	+	oldIssues, oldCloses := toSet(old.GetIssues()), toSet(old.GetCloses())
	62	+	for _, n := range closes {
	63	+	if _, ok := issueSet[n]; !ok {
	64	+	return nil, nil, domain.ErrInvalid
	65	+	}
	66	+	}
	67	+	var b kv.Batch
	68	+	if err := guardRepoKey(ctx, l.db, &b, repo); err != nil {
	69	+	return nil, nil, err
	70	+	}
	71	+	if exists {
	72	+	b.RequireVersion(key, item.Version)
	73	+	} else {
	74	+	b.RequireAbsent(key)
	75	+	}
	76	+	for _, n := range old.GetIssues() {
	77	+	_, wasClosing := oldCloses[n]
	78	+	if _, ok := issueSet[n]; !ok {
	79	+	b.Delete(issueRefKey(repo, n, mr))
	80	+	removed = append(removed, domain.IssueLink{Issue: n, MergeRequest: mr, Closes: wasClosing})
	81	+	} else if _, still := closeSet[n]; wasClosing && !still {
	82	+	removed = append(removed, domain.IssueLink{Issue: n, MergeRequest: mr, Closes: true})
	83	+	}
	84	+	}
	85	+	for _, n := range issues {
	86	+	_, closing := closeSet[n]
	87	+	b.Put(issueRefKey(repo, n, mr), mustMarshal(&storagepb.IssueLink{Closes: closing}))
	88	+	_, was := oldIssues[n]
	89	+	_, wasClosing := oldCloses[n]
	90	+	if !was \|\| closing && !wasClosing {
	91	+	added = append(added, domain.IssueLink{Issue: n, MergeRequest: mr, Closes: closing})
	92	+	}
	93	+	}
	94	+	b.Put(key, mustMarshal(&storagepb.MergeRequestReferences{Issues: issues, Closes: closes}))
	95	+	if _, err := l.db.Apply(ctx, &b); err != nil {
	96	+	if errors.Is(err, kv.ErrConflict) {
	97	+	return nil, nil, domain.ErrConflict
	98	+	}
	99	+	return nil, nil, fmt.Errorf("replace issue links: %w", err)
	100	+	}
	101	+	return added, removed, nil
	102	+	}
	103	+
	104	+	// LinksOfIssue returns links ordered by merge request number.
	105	+	func (l *IssueLinks) LinksOfIssue(ctx context.Context, repo domain.RepoName, issue int64, limit int) ([]domain.IssueLink, error) {
	106	+	var result []domain.IssueLink
	107	+	prefix := issueRefKeys(repo, issue)
	108	+	for key, item := range l.db.Snapshot(ctx).Prefix(ctx, []byte(prefix)) {
	109	+	if err := ctx.Err(); err != nil {
	110	+	return nil, err
	111	+	}
	112	+	mr, err := strconv.ParseInt(strings.TrimPrefix(string(key), prefix), 10, 64)
	113	+	if err != nil {
	114	+	return nil, fmt.Errorf("decode issue link key: %w", err)
	115	+	}
	116	+	var pb storagepb.IssueLink
	117	+	if err := proto.Unmarshal(item.Value, &pb); err != nil {
	118	+	return nil, fmt.Errorf("decode issue link: %w", err)
	119	+	}
	120	+	result = append(result, domain.IssueLink{Issue: issue, MergeRequest: mr, Closes: pb.GetCloses()})
	121	+	if limit > 0 && len(result) >= limit {
	122	+	break
	123	+	}
	124	+	}
	125	+	return result, nil
	126	+	}
	127	+
	128	+	// LinksOfMergeRequest returns the links recorded by its last rebuild.
	129	+	func (l *IssueLinks) LinksOfMergeRequest(ctx context.Context, repo domain.RepoName, mr int64) ([]domain.IssueLink, error) {
	130	+	item, ok := l.db.Get(ctx, mrRefKey(repo, mr))
	131	+	if !ok {
	132	+	return nil, nil
	133	+	}
	134	+	var pb storagepb.MergeRequestReferences
	135	+	if err := proto.Unmarshal(item.Value, &pb); err != nil {
	136	+	return nil, fmt.Errorf("decode MR references: %w", err)
	137	+	}
	138	+	var result []domain.IssueLink
	139	+	for _, n := range pb.GetIssues() {
	140	+	result = append(result, domain.IssueLink{Issue: n, MergeRequest: mr, Closes: slices.Contains(pb.GetCloses(), n)})
	141	+	}
	142	+	return result, nil
	143	+	}
	144	+
	145	+	func toSet(numbers []int64) map[int64]struct{} {
	146	+	set := make(map[int64]struct{}, len(numbers))
	147	+	for _, n := range numbers {
	148	+	set[n] = struct{}{}
	149	+	}
	150	+	return set
	151	+	}

@@ -0,0 +1,151 @@
	1	+	// SPDX-License-Identifier: AGPL-3.0-or-later
	2	+
	3	+	package kvstore
	4	+
	5	+	import (
	6	+	"context"
	7	+	"errors"
	8	+	"fmt"
	9	+	"slices"
	10	+	"strconv"
	11	+	"strings"
	12	+
	13	+	kv "bnema.dev/ermite-kv"
	14	+	storagepb "bnema.dev/ermite/gen/ermite/storage"
	15	+	"bnema.dev/ermite/internal/domain"
	16	+	"bnema.dev/ermite/internal/ports"
	17	+	"google.golang.org/protobuf/proto"
	18	+	)
	19	+
	20	+	const issueRefPrefix = "isref/"
	21	+	const mrRefPrefix = "mrref/"
	22	+
	23	+	// IssueLinks stores the derived issue-to-merge-request index.
	24	+	type IssueLinks struct{ db *kv.DB }
	25	+
	26	+	var _ ports.IssueLinkStore = (*IssueLinks)(nil)
	27	+
	28	+	// IssueLinks returns a link store sharing this Store's database and lifetime.
	29	+	func (s Store) IssueLinks() IssueLinks { return &IssueLinks{db: s.db} }
	30	+
	31	+	func mrRefKey(repo domain.RepoName, mr int64) []byte {
	32	+	return []byte(mrRefPrefix + repo.String() + "/" + fmt.Sprintf(numberFormat, mr))
	33	+	}
	34	+	func issueRefKeys(repo domain.RepoName, issue int64) string {
	35	+	return issueRefPrefix + repo.String() + "/" + fmt.Sprintf(numberFormat, issue) + "/"
	36	+	}
	37	+	func issueRefKey(repo domain.RepoName, issue, mr int64) []byte {
	38	+	return []byte(issueRefKeys(repo, issue) + fmt.Sprintf(numberFormat, mr))
	39	+	}
	40	+
	41	+	// ReplaceLinks atomically replaces both directions of the index.
	42	+	func (l *IssueLinks) ReplaceLinks(ctx context.Context, repo domain.RepoName, mr int64, issues, closes []int64) (added, removed []domain.IssueLink, err error) {
	43	+	key := mrRefKey(repo, mr)
	44	+	item, exists := l.db.Get(ctx, key)
	45	+	var old storagepb.MergeRequestReferences
	46	+	if exists {
	47	+	if err := proto.Unmarshal(item.Value, &old); err != nil {
	48	+	return nil, nil, fmt.Errorf("decode MR references: %w", err)
	49	+	}
	50	+	}
	51	+	issues = slices.Sorted(slices.Values(issues))
	52	+	issues = slices.Compact(issues)
	53	+	closes = slices.Sorted(slices.Values(closes))
	54	+	closes = slices.Compact(closes)
	55	+	for _, n := range issues {
	56	+	if n < 1 {
	57	+	return nil, nil, domain.ErrInvalid
	58	+	}
	59	+	}
	60	+	issueSet, closeSet := toSet(issues), toSet(closes)
	61	+	oldIssues, oldCloses := toSet(old.GetIssues()), toSet(old.GetCloses())
	62	+	for _, n := range closes {
	63	+	if _, ok := issueSet[n]; !ok {
	64	+	return nil, nil, domain.ErrInvalid
	65	+	}
	66	+	}
	67	+	var b kv.Batch
	68	+	if err := guardRepoKey(ctx, l.db, &b, repo); err != nil {
	69	+	return nil, nil, err
	70	+	}
	71	+	if exists {
	72	+	b.RequireVersion(key, item.Version)
	73	+	} else {
	74	+	b.RequireAbsent(key)
	75	+	}
	76	+	for _, n := range old.GetIssues() {
	77	+	_, wasClosing := oldCloses[n]
	78	+	if _, ok := issueSet[n]; !ok {
	79	+	b.Delete(issueRefKey(repo, n, mr))
	80	+	removed = append(removed, domain.IssueLink{Issue: n, MergeRequest: mr, Closes: wasClosing})
	81	+	} else if _, still := closeSet[n]; wasClosing && !still {
	82	+	removed = append(removed, domain.IssueLink{Issue: n, MergeRequest: mr, Closes: true})
	83	+	}
	84	+	}
	85	+	for _, n := range issues {
	86	+	_, closing := closeSet[n]
	87	+	b.Put(issueRefKey(repo, n, mr), mustMarshal(&storagepb.IssueLink{Closes: closing}))
	88	+	_, was := oldIssues[n]
	89	+	_, wasClosing := oldCloses[n]
	90	+	if !was \|\| closing && !wasClosing {
	91	+	added = append(added, domain.IssueLink{Issue: n, MergeRequest: mr, Closes: closing})
	92	+	}
	93	+	}
	94	+	b.Put(key, mustMarshal(&storagepb.MergeRequestReferences{Issues: issues, Closes: closes}))
	95	+	if _, err := l.db.Apply(ctx, &b); err != nil {
	96	+	if errors.Is(err, kv.ErrConflict) {
	97	+	return nil, nil, domain.ErrConflict
	98	+	}
	99	+	return nil, nil, fmt.Errorf("replace issue links: %w", err)
	100	+	}
	101	+	return added, removed, nil
	102	+	}
	103	+
	104	+	// LinksOfIssue returns links ordered by merge request number.
	105	+	func (l *IssueLinks) LinksOfIssue(ctx context.Context, repo domain.RepoName, issue int64, limit int) ([]domain.IssueLink, error) {
	106	+	var result []domain.IssueLink
	107	+	prefix := issueRefKeys(repo, issue)
	108	+	for key, item := range l.db.Snapshot(ctx).Prefix(ctx, []byte(prefix)) {
	109	+	if err := ctx.Err(); err != nil {
	110	+	return nil, err
	111	+	}
	112	+	mr, err := strconv.ParseInt(strings.TrimPrefix(string(key), prefix), 10, 64)
	113	+	if err != nil {
	114	+	return nil, fmt.Errorf("decode issue link key: %w", err)
	115	+	}
	116	+	var pb storagepb.IssueLink
	117	+	if err := proto.Unmarshal(item.Value, &pb); err != nil {
	118	+	return nil, fmt.Errorf("decode issue link: %w", err)
	119	+	}
	120	+	result = append(result, domain.IssueLink{Issue: issue, MergeRequest: mr, Closes: pb.GetCloses()})
	121	+	if limit > 0 && len(result) >= limit {
	122	+	break
	123	+	}
	124	+	}
	125	+	return result, nil
	126	+	}
	127	+
	128	+	// LinksOfMergeRequest returns the links recorded by its last rebuild.
	129	+	func (l *IssueLinks) LinksOfMergeRequest(ctx context.Context, repo domain.RepoName, mr int64) ([]domain.IssueLink, error) {
	130	+	item, ok := l.db.Get(ctx, mrRefKey(repo, mr))
	131	+	if !ok {
	132	+	return nil, nil
	133	+	}
	134	+	var pb storagepb.MergeRequestReferences
	135	+	if err := proto.Unmarshal(item.Value, &pb); err != nil {
	136	+	return nil, fmt.Errorf("decode MR references: %w", err)
	137	+	}
	138	+	var result []domain.IssueLink
	139	+	for _, n := range pb.GetIssues() {
	140	+	result = append(result, domain.IssueLink{Issue: n, MergeRequest: mr, Closes: slices.Contains(pb.GetCloses(), n)})
	141	+	}
	142	+	return result, nil
	143	+	}
	144	+
	145	+	func toSet(numbers []int64) map[int64]struct{} {
	146	+	set := make(map[int64]struct{}, len(numbers))
	147	+	for _, n := range numbers {
	148	+	set[n] = struct{}{}
	149	+	}
	150	+	return set
	151	+	}

A internal/adapters/kvstore/issue_links_test.go +66 -0

@@ -0,0 +1,66 @@
	1	+	// SPDX-License-Identifier: AGPL-3.0-or-later
	2	+	package kvstore_test
	3	+
	4	+	import (
	5	+	"bnema.dev/ermite/internal/domain"
	6	+	"context"
	7	+	"github.com/stretchr/testify/assert"
	8	+	"github.com/stretchr/testify/require"
	9	+	"testing"
	10	+	)
	11	+
	12	+	func TestIssueLinksReplace(t *testing.T) {
	13	+	ctx := context.Background()
	14	+	s, _, repo := repoWithMRs(t)
	15	+	links := s.IssueLinks()
	16	+	added, removed, err := links.ReplaceLinks(ctx, repo, 9, []int64{3, 2, 3}, []int64{2})
	17	+	require.NoError(t, err)
	18	+	assert.Equal(t, []domain.IssueLink{{Issue: 2, MergeRequest: 9, Closes: true}, {Issue: 3, MergeRequest: 9}}, added)
	19	+	assert.Empty(t, removed)
	20	+	got, err := links.LinksOfMergeRequest(ctx, repo, 9)
	21	+	require.NoError(t, err)
	22	+	assert.Equal(t, added, got)
	23	+	added, removed, err = links.ReplaceLinks(ctx, repo, 9, []int64{2, 3}, []int64{2})
	24	+	require.NoError(t, err)
	25	+	assert.Empty(t, added)
	26	+	assert.Empty(t, removed)
	27	+	added, removed, err = links.ReplaceLinks(ctx, repo, 9, []int64{3, 4}, []int64{3})
	28	+	require.NoError(t, err)
	29	+	assert.Equal(t, []domain.IssueLink{{Issue: 3, MergeRequest: 9, Closes: true}, {Issue: 4, MergeRequest: 9}}, added)
	30	+	assert.Equal(t, []domain.IssueLink{{Issue: 2, MergeRequest: 9, Closes: true}}, removed)
	31	+	got, err = links.LinksOfIssue(ctx, repo, 2, 100)
	32	+	require.NoError(t, err)
	33	+	assert.Empty(t, got)
	34	+	added, removed, err = links.ReplaceLinks(ctx, repo, 9, []int64{3}, nil)
	35	+	require.NoError(t, err)
	36	+	assert.Empty(t, added)
	37	+	assert.Equal(t, []domain.IssueLink{{Issue: 3, MergeRequest: 9, Closes: true}, {Issue: 4, MergeRequest: 9}}, removed)
	38	+	for _, mr := range []int64{12, 1, 5} {
	39	+	_, _, err = links.ReplaceLinks(ctx, repo, mr, []int64{3}, nil)
	40	+	require.NoError(t, err)
	41	+	}
	42	+	got, err = links.LinksOfIssue(ctx, repo, 3, 2)
	43	+	require.NoError(t, err)
	44	+	assert.Equal(t, []domain.IssueLink{{Issue: 3, MergeRequest: 1}, {Issue: 3, MergeRequest: 5}}, got)
	45	+	require.NoError(t, s.Delete(ctx, repo))
	46	+	assert.Zero(t, countKeys(t, s, "isref/"+repo.String()+"/"))
	47	+	assert.Zero(t, countKeys(t, s, "mrref/"+repo.String()+"/"))
	48	+	_, _, err = links.ReplaceLinks(ctx, repo, 9, []int64{2}, nil)
	49	+	assert.ErrorIs(t, err, domain.ErrNotFound)
	50	+	}
	51	+
	52	+	func TestIssueClosedByRoundTrip(t *testing.T) {
	53	+	ctx := context.Background()
	54	+	s, _, repo := repoWithMRs(t)
	55	+	issue := newIssue(t, repo, "closed by merge")
	56	+	issue.State = domain.IssueStateClosed
	57	+	issue.ClosedByMergeRequest = 17
	58	+	stored, err := s.Issues().Create(ctx, issue)
	59	+	require.NoError(t, err)
	60	+	assert.Equal(t, int64(17), stored.ClosedByMergeRequest)
	61	+	stored.ClosedByMergeRequest = 0
	62	+	require.NoError(t, s.Issues().Update(ctx, stored))
	63	+	stored, err = s.Issues().Get(ctx, repo, stored.Number)
	64	+	require.NoError(t, err)
	65	+	assert.Zero(t, stored.ClosedByMergeRequest)
	66	+	}

@@ -0,0 +1,66 @@
	1	+	// SPDX-License-Identifier: AGPL-3.0-or-later
	2	+	package kvstore_test
	3	+
	4	+	import (
	5	+	"bnema.dev/ermite/internal/domain"
	6	+	"context"
	7	+	"github.com/stretchr/testify/assert"
	8	+	"github.com/stretchr/testify/require"
	9	+	"testing"
	10	+	)
	11	+
	12	+	func TestIssueLinksReplace(t *testing.T) {
	13	+	ctx := context.Background()
	14	+	s, _, repo := repoWithMRs(t)
	15	+	links := s.IssueLinks()
	16	+	added, removed, err := links.ReplaceLinks(ctx, repo, 9, []int64{3, 2, 3}, []int64{2})
	17	+	require.NoError(t, err)
	18	+	assert.Equal(t, []domain.IssueLink{{Issue: 2, MergeRequest: 9, Closes: true}, {Issue: 3, MergeRequest: 9}}, added)
	19	+	assert.Empty(t, removed)
	20	+	got, err := links.LinksOfMergeRequest(ctx, repo, 9)
	21	+	require.NoError(t, err)
	22	+	assert.Equal(t, added, got)
	23	+	added, removed, err = links.ReplaceLinks(ctx, repo, 9, []int64{2, 3}, []int64{2})
	24	+	require.NoError(t, err)
	25	+	assert.Empty(t, added)
	26	+	assert.Empty(t, removed)
	27	+	added, removed, err = links.ReplaceLinks(ctx, repo, 9, []int64{3, 4}, []int64{3})
	28	+	require.NoError(t, err)
	29	+	assert.Equal(t, []domain.IssueLink{{Issue: 3, MergeRequest: 9, Closes: true}, {Issue: 4, MergeRequest: 9}}, added)
	30	+	assert.Equal(t, []domain.IssueLink{{Issue: 2, MergeRequest: 9, Closes: true}}, removed)
	31	+	got, err = links.LinksOfIssue(ctx, repo, 2, 100)
	32	+	require.NoError(t, err)
	33	+	assert.Empty(t, got)
	34	+	added, removed, err = links.ReplaceLinks(ctx, repo, 9, []int64{3}, nil)
	35	+	require.NoError(t, err)
	36	+	assert.Empty(t, added)
	37	+	assert.Equal(t, []domain.IssueLink{{Issue: 3, MergeRequest: 9, Closes: true}, {Issue: 4, MergeRequest: 9}}, removed)
	38	+	for _, mr := range []int64{12, 1, 5} {
	39	+	_, _, err = links.ReplaceLinks(ctx, repo, mr, []int64{3}, nil)
	40	+	require.NoError(t, err)
	41	+	}
	42	+	got, err = links.LinksOfIssue(ctx, repo, 3, 2)
	43	+	require.NoError(t, err)
	44	+	assert.Equal(t, []domain.IssueLink{{Issue: 3, MergeRequest: 1}, {Issue: 3, MergeRequest: 5}}, got)
	45	+	require.NoError(t, s.Delete(ctx, repo))
	46	+	assert.Zero(t, countKeys(t, s, "isref/"+repo.String()+"/"))
	47	+	assert.Zero(t, countKeys(t, s, "mrref/"+repo.String()+"/"))
	48	+	_, _, err = links.ReplaceLinks(ctx, repo, 9, []int64{2}, nil)
	49	+	assert.ErrorIs(t, err, domain.ErrNotFound)
	50	+	}
	51	+
	52	+	func TestIssueClosedByRoundTrip(t *testing.T) {
	53	+	ctx := context.Background()
	54	+	s, _, repo := repoWithMRs(t)
	55	+	issue := newIssue(t, repo, "closed by merge")
	56	+	issue.State = domain.IssueStateClosed
	57	+	issue.ClosedByMergeRequest = 17
	58	+	stored, err := s.Issues().Create(ctx, issue)
	59	+	require.NoError(t, err)
	60	+	assert.Equal(t, int64(17), stored.ClosedByMergeRequest)
	61	+	stored.ClosedByMergeRequest = 0
	62	+	require.NoError(t, s.Issues().Update(ctx, stored))
	63	+	stored, err = s.Issues().Get(ctx, repo, stored.Number)
	64	+	require.NoError(t, err)
	65	+	assert.Zero(t, stored.ClosedByMergeRequest)
	66	+	}

M internal/adapters/kvstore/issues.go +15 -13


@@ -72,7 +72,7 @@ func indexOpenIssue(b *kv.Batch, issue domain.Issue) {
72	72		func issueKeys(ctx context.Context, snap *kv.Snapshot, repo domain.RepoName) [][]byte {
73	73		var keys [][]byte
74	74		for _, p := range []string{
75		-	issueRepoPrefix(repo), issueCommentPrefix + repo.String() + "/", issueOpenRepoPrefix(repo),
	75	+	issueRepoPrefix(repo), issueCommentPrefix + repo.String() + "/", issueOpenRepoPrefix(repo), issueRefPrefix + repo.String() + "/",
76	76		} {
77	77		for k := range snap.Prefix(ctx, []byte(p)) {
78	78		keys = append(keys, slices.Clone(k))

@@ -312,15 +312,16 @@ func encodeIssue(issue domain.Issue) ([]byte, error) {
312	312		return nil, err
313	313		}
314	314		return mustMarshal(&storagepb.Issue{
315		-	Number: issue.Number,
316		-	Title: issue.Title.String(),
317		-	Body: issue.Body.String(),
318		-	State: state,
319		-	Author: issue.Author,
320		-	CreatedAt: encodeTime(issue.CreatedAt),
321		-	UpdatedAt: encodeTime(issue.UpdatedAt),
322		-	CommentSeq: issue.CommentSeq,
323		-	External: issue.External,
	315	+	Number: issue.Number,
	316	+	Title: issue.Title.String(),
	317	+	Body: issue.Body.String(),
	318	+	State: state,
	319	+	Author: issue.Author,
	320	+	CreatedAt: encodeTime(issue.CreatedAt),
	321	+	UpdatedAt: encodeTime(issue.UpdatedAt),
	322	+	CommentSeq: issue.CommentSeq,
	323	+	External: issue.External,
	324	+	ClosedByMergeRequest: issue.ClosedByMergeRequest,
324	325		}), nil
325	326		}
326	327

@@ -348,9 +349,10 @@ func decodeIssue(repo domain.RepoName, item kv.Item) (domain.Issue, error) {
348	349		Repo: repo, Number: pb.GetNumber(), Title: title, Body: body, State: state,
349	350		Author: pb.GetAuthor(),
350	351		CreatedAt: decodeTime(pb.GetCreatedAt()), UpdatedAt: decodeTime(pb.GetUpdatedAt()),
351		-	CommentSeq: pb.GetCommentSeq(),
352		-	External: pb.GetExternal(),
353		-	Version: item.Version,
	352	+	CommentSeq: pb.GetCommentSeq(),
	353	+	External: pb.GetExternal(),
	354	+	ClosedByMergeRequest: pb.GetClosedByMergeRequest(),
	355	+	Version: item.Version,
354	356		}, nil
355	357		}
356	358


@@ -72,7 +72,7 @@ func indexOpenIssue(b *kv.Batch, issue domain.Issue) {
72		func issueKeys(ctx context.Context, snap *kv.Snapshot, repo domain.RepoName) [][]byte {	72		func issueKeys(ctx context.Context, snap *kv.Snapshot, repo domain.RepoName) [][]byte {
73		var keys [][]byte	73		var keys [][]byte
74		for _, p := range []string{	74		for _, p := range []string{
75	-	issueRepoPrefix(repo), issueCommentPrefix + repo.String() + "/", issueOpenRepoPrefix(repo),	75	+	issueRepoPrefix(repo), issueCommentPrefix + repo.String() + "/", issueOpenRepoPrefix(repo), issueRefPrefix + repo.String() + "/",
76		} {	76		} {
77		for k := range snap.Prefix(ctx, []byte(p)) {	77		for k := range snap.Prefix(ctx, []byte(p)) {
78		keys = append(keys, slices.Clone(k))	78		keys = append(keys, slices.Clone(k))

@@ -312,15 +312,16 @@ func encodeIssue(issue domain.Issue) ([]byte, error) {
312		return nil, err	312		return nil, err
313		}	313		}
314		return mustMarshal(&storagepb.Issue{	314		return mustMarshal(&storagepb.Issue{
315	-	Number: issue.Number,	315	+	Number: issue.Number,
316	-	Title: issue.Title.String(),	316	+	Title: issue.Title.String(),
317	-	Body: issue.Body.String(),	317	+	Body: issue.Body.String(),
318	-	State: state,	318	+	State: state,
319	-	Author: issue.Author,	319	+	Author: issue.Author,
320	-	CreatedAt: encodeTime(issue.CreatedAt),	320	+	CreatedAt: encodeTime(issue.CreatedAt),
321	-	UpdatedAt: encodeTime(issue.UpdatedAt),	321	+	UpdatedAt: encodeTime(issue.UpdatedAt),
322	-	CommentSeq: issue.CommentSeq,	322	+	CommentSeq: issue.CommentSeq,
323	-	External: issue.External,	323	+	External: issue.External,
			324	+	ClosedByMergeRequest: issue.ClosedByMergeRequest,
324		}), nil	325		}), nil
325		}	326		}
326			327

@@ -348,9 +349,10 @@ func decodeIssue(repo domain.RepoName, item kv.Item) (domain.Issue, error) {
348		Repo: repo, Number: pb.GetNumber(), Title: title, Body: body, State: state,	349		Repo: repo, Number: pb.GetNumber(), Title: title, Body: body, State: state,
349		Author: pb.GetAuthor(),	350		Author: pb.GetAuthor(),
350		CreatedAt: decodeTime(pb.GetCreatedAt()), UpdatedAt: decodeTime(pb.GetUpdatedAt()),	351		CreatedAt: decodeTime(pb.GetCreatedAt()), UpdatedAt: decodeTime(pb.GetUpdatedAt()),
351	-	CommentSeq: pb.GetCommentSeq(),	352	+	CommentSeq: pb.GetCommentSeq(),
352	-	External: pb.GetExternal(),	353	+	External: pb.GetExternal(),
353	-	Version: item.Version,	354	+	ClosedByMergeRequest: pb.GetClosedByMergeRequest(),
			355	+	Version: item.Version,
354		}, nil	356		}, nil
355		}	357		}
356			358

M internal/adapters/kvstore/mergerequests.go +1 -1


@@ -181,7 +181,7 @@ func mergeRequestKeys(ctx context.Context, snap *kv.Snapshot, repo domain.RepoNa
181	181		var keys [][]byte
182	182		for _, p := range []string{
183	183		mrRepoPrefix(repo), commentPrefix + repo.String() + "/", readPrefix + repo.String() + "/",
184		-	mrOpenRepoPrefix(repo), mrTargetPrefix + repo.String() + "/",
	184	+	mrOpenRepoPrefix(repo), mrTargetPrefix + repo.String() + "/", mrRefPrefix + repo.String() + "/",
185	185		mergePrefix + repo.String() + "/",
186	186		} {
187	187		for k := range snap.Prefix(ctx, []byte(p)) {


@@ -181,7 +181,7 @@ func mergeRequestKeys(ctx context.Context, snap *kv.Snapshot, repo domain.RepoNa
181		var keys [][]byte	181		var keys [][]byte
182		for _, p := range []string{	182		for _, p := range []string{
183		mrRepoPrefix(repo), commentPrefix + repo.String() + "/", readPrefix + repo.String() + "/",	183		mrRepoPrefix(repo), commentPrefix + repo.String() + "/", readPrefix + repo.String() + "/",
184	-	mrOpenRepoPrefix(repo), mrTargetPrefix + repo.String() + "/",	184	+	mrOpenRepoPrefix(repo), mrTargetPrefix + repo.String() + "/", mrRefPrefix + repo.String() + "/",
185		mergePrefix + repo.String() + "/",	185		mergePrefix + repo.String() + "/",
186		} {	186		} {
187		for k := range snap.Prefix(ctx, []byte(p)) {	187		for k := range snap.Prefix(ctx, []byte(p)) {

M internal/adapters/rpc/api.go +1 -1


@@ -35,7 +35,7 @@ const RunnerMaxRequestBytes = MaxRequestBytes + 64<<10
35	35		// always implements, as GetVersion lists them. FeaturePasskeys comes on top
36	36		// when Config.Passkeys is set, and FeatureCISecrets when the settings services
37	37		// are, and FeatureCommitSignatures when Config.TrustedKeys is set.
38		-	var Features = []string{"repo.update", "events.resume", "merge_requests", "merge_requests.delete_branch", "issues", "merge_requests.mergeability", "signing_key", "session", "git.list_paths", "token.branch_prefixes", "ci.runs", "ci.runs.filters", "ci.runners", "ci.actions", "ci.annotations", "ci.summaries", "ci.concurrency", "ci.dispatch", "ci.cache", "ci.workflows"}
	38	+	var Features = []string{"repo.update", "events.resume", "merge_requests", "merge_requests.delete_branch", "issues", "issues.links", "merge_requests.mergeability", "signing_key", "session", "git.list_paths", "token.branch_prefixes", "ci.runs", "ci.runs.filters", "ci.runners", "ci.actions", "ci.annotations", "ci.summaries", "ci.concurrency", "ci.dispatch", "ci.cache", "ci.workflows"}
39	39
40	40		// FeaturePasskeys is listed by GetVersion when passkeys are available.
41	41		// FeatureCIArtifacts (artifact.go) when the artifact services are served.


@@ -35,7 +35,7 @@ const RunnerMaxRequestBytes = MaxRequestBytes + 64<<10
35		// always implements, as GetVersion lists them. FeaturePasskeys comes on top	35		// always implements, as GetVersion lists them. FeaturePasskeys comes on top
36		// when Config.Passkeys is set, and FeatureCISecrets when the settings services	36		// when Config.Passkeys is set, and FeatureCISecrets when the settings services
37		// are, and FeatureCommitSignatures when Config.TrustedKeys is set.	37		// are, and FeatureCommitSignatures when Config.TrustedKeys is set.
38	-	var Features = []string{"repo.update", "events.resume", "merge_requests", "merge_requests.delete_branch", "issues", "merge_requests.mergeability", "signing_key", "session", "git.list_paths", "token.branch_prefixes", "ci.runs", "ci.runs.filters", "ci.runners", "ci.actions", "ci.annotations", "ci.summaries", "ci.concurrency", "ci.dispatch", "ci.cache", "ci.workflows"}	38	+	var Features = []string{"repo.update", "events.resume", "merge_requests", "merge_requests.delete_branch", "issues", "issues.links", "merge_requests.mergeability", "signing_key", "session", "git.list_paths", "token.branch_prefixes", "ci.runs", "ci.runs.filters", "ci.runners", "ci.actions", "ci.annotations", "ci.summaries", "ci.concurrency", "ci.dispatch", "ci.cache", "ci.workflows"}
39			39
40		// FeaturePasskeys is listed by GetVersion when passkeys are available.	40		// FeaturePasskeys is listed by GetVersion when passkeys are available.
41		// FeatureCIArtifacts (artifact.go) when the artifact services are served.	41		// FeatureCIArtifacts (artifact.go) when the artifact services are served.

M internal/adapters/rpc/convert.go +2 -2


@@ -530,8 +530,8 @@ func watchEventToPB(we ports.WatchEvent) *pb.Event {
530	530		out.Time = timestamp(ev.At)
531	531		out.Kind = &pb.Event_MirrorRecovered{MirrorRecovered: &pb.MirrorRecovered{Repo: ev.Repo.String()}}
532	532		default:
533		-	// Web-only events, such as domain.IssuePendingRemoved (the API has
534		-	// no message for it; watchers list pending issues on demand).
	533	+	// Web-only events, such as domain.IssueReferenced and
	534	+	// domain.IssuePendingRemoved: the API has no messages for them.
535	535		return nil
536	536		}
537	537		return out


@@ -530,8 +530,8 @@ func watchEventToPB(we ports.WatchEvent) *pb.Event {
530		out.Time = timestamp(ev.At)	530		out.Time = timestamp(ev.At)
531		out.Kind = &pb.Event_MirrorRecovered{MirrorRecovered: &pb.MirrorRecovered{Repo: ev.Repo.String()}}	531		out.Kind = &pb.Event_MirrorRecovered{MirrorRecovered: &pb.MirrorRecovered{Repo: ev.Repo.String()}}
532		default:	532		default:
533	-	// Web-only events, such as domain.IssuePendingRemoved (the API has	533	+	// Web-only events, such as domain.IssueReferenced and
534	-	// no message for it; watchers list pending issues on demand).	534	+	// domain.IssuePendingRemoved: the API has no messages for them.
535		return nil	535		return nil
536		}	536		}
537		return out	537		return out

M internal/adapters/rpc/issue.go +19 -9


@@ -70,15 +70,16 @@ func issuesModeFromPB(m pb.IssuesMode) (domain.IssuesMode, error) {
70	70
71	71		func issueToPB(i domain.Issue) *pb.Issue {
72	72		return &pb.Issue{
73		-	Repo: i.Repo.String(),
74		-	Number: i.Number,
75		-	Title: i.Title.String(),
76		-	Body: i.Body.String(),
77		-	State: issueStateToPB(i.State),
78		-	Author: i.Author,
79		-	CreatedAt: timestamp(i.CreatedAt),
80		-	UpdatedAt: timestamp(i.UpdatedAt),
81		-	CommentCount: int32(i.CommentSeq), //nolint:gosec // bounded by usecase.MaxCommentsPerIssue
	73	+	Repo: i.Repo.String(),
	74	+	Number: i.Number,
	75	+	Title: i.Title.String(),
	76	+	Body: i.Body.String(),
	77	+	State: issueStateToPB(i.State),
	78	+	Author: i.Author,
	79	+	CreatedAt: timestamp(i.CreatedAt),
	80	+	UpdatedAt: timestamp(i.UpdatedAt),
	81	+	CommentCount: int32(i.CommentSeq), //nolint:gosec // bounded by usecase.MaxCommentsPerIssue
	82	+	ClosedByMergeRequest: i.ClosedByMergeRequest,
82	83		}
83	84		}
84	85

@@ -138,6 +139,15 @@ func (s issueService) GetIssue(ctx context.Context, req connect.Request[pb.Get
138	139		for _, c := range d.Comments {
139	140		out.Comments = append(out.Comments, issueCommentToPB(c))
140	141		}
	142	+	out.References = make([]*pb.IssueReference, 0, len(d.References))
	143	+	for _, r := range d.References {
	144	+	out.References = append(out.References, &pb.IssueReference{
	145	+	Number: r.Number,
	146	+	Title: r.Title.String(),
	147	+	State: mergeRequestStateToPB(r.State),
	148	+	Closes: r.Closes,
	149	+	})
	150	+	}
141	151		return connect.NewResponse(out), nil
142	152		}
143	153

 func issueToPB(i domain.Issue) *pb.Issue {
 	return &pb.Issue{
-		Repo:         i.Repo.String(),
+		Repo:                 i.Repo.String(),
-		Number:       i.Number,
+		Number:               i.Number,
-		Title:        i.Title.String(),
+		Title:                i.Title.String(),
-		Body:         i.Body.String(),
+		Body:                 i.Body.String(),
-		State:        issueStateToPB(i.State),
+		State:                issueStateToPB(i.State),
-		Author:       i.Author,
+		Author:               i.Author,
-		CreatedAt:    timestamp(i.CreatedAt),
+		CreatedAt:            timestamp(i.CreatedAt),
-		UpdatedAt:    timestamp(i.UpdatedAt),
+		UpdatedAt:            timestamp(i.UpdatedAt),
-		CommentCount: int32(i.CommentSeq), //nolint:gosec // bounded by usecase.MaxCommentsPerIssue
+		CommentCount:         int32(i.CommentSeq), //nolint:gosec // bounded by usecase.MaxCommentsPerIssue
+		ClosedByMergeRequest: i.ClosedByMergeRequest,
 	}
 }
 	for _, c := range d.Comments {
 		out.Comments = append(out.Comments, issueCommentToPB(c))
 	}
+	out.References = make([]*pb.IssueReference, 0, len(d.References))
+	for _, r := range d.References {
+		out.References = append(out.References, &pb.IssueReference{
+			Number: r.Number,
+			Title:  r.Title.String(),
+			State:  mergeRequestStateToPB(r.State),
+			Closes: r.Closes,
+		})
+	}
 	return connect.NewResponse(out), nil
 }

M internal/adapters/web/fragments.go +3 -1


@@ -63,7 +63,7 @@ func liveEvent(we ports.WatchEvent) bool {
63	63		case domain.RepoCreated, domain.RepoUpdated, domain.RepoDeleted, domain.PushEvent,
64	64		domain.MergeRequestOpened, domain.MergeRequestMerged, domain.MergeRequestClosed, domain.MergeRequestReady, domain.MergeRequestMergeability, domain.CommentAdded, domain.CommentEdited, domain.CommentDeleted, domain.CommentResolved,
65	65		domain.RunUpdated, domain.JobUpdated,
66		-	domain.IssueOpened, domain.IssueClosed, domain.IssueReopened, domain.IssueCommented, domain.IssueSubmitted, domain.IssuePendingRemoved:
	66	+	domain.IssueOpened, domain.IssueClosed, domain.IssueReopened, domain.IssueCommented, domain.IssueSubmitted, domain.IssuePendingRemoved, domain.IssueReferenced:
67	67		return true
68	68		}
69	69		return false

@@ -210,6 +210,8 @@ func (l *liveStream) repoPage(ctx context.Context, we ports.WatchEvent) ([]fragm
210	210		return l.issueNotice(ctx, ev.Issue.Number, "this issue was reopened — reload")
211	211		case domain.IssueCommented:
212	212		return l.issueNotice(ctx, ev.Number, "a comment was added — reload")
	213	+	case domain.IssueReferenced:
	214	+	return l.issueNotice(ctx, ev.Issue, "a merge request mentions this issue — reload")
213	215		case domain.PushEvent:
214	216		switch l.view {
215	217		case "mr":

 	case domain.RepoCreated, domain.RepoUpdated, domain.RepoDeleted, domain.PushEvent,
 		domain.MergeRequestOpened, domain.MergeRequestMerged, domain.MergeRequestClosed, domain.MergeRequestReady, domain.MergeRequestMergeability, domain.CommentAdded, domain.CommentEdited, domain.CommentDeleted, domain.CommentResolved,
 		domain.RunUpdated, domain.JobUpdated,
-		domain.IssueOpened, domain.IssueClosed, domain.IssueReopened, domain.IssueCommented, domain.IssueSubmitted, domain.IssuePendingRemoved:
+		domain.IssueOpened, domain.IssueClosed, domain.IssueReopened, domain.IssueCommented, domain.IssueSubmitted, domain.IssuePendingRemoved, domain.IssueReferenced:
 		return true
 	}
 	return false
 		return l.issueNotice(ctx, ev.Issue.Number, "this issue was reopened — reload")
 	case domain.IssueCommented:
 		return l.issueNotice(ctx, ev.Number, "a comment was added — reload")
+	case domain.IssueReferenced:
+		return l.issueNotice(ctx, ev.Issue, "a merge request mentions this issue — reload")
 	case domain.PushEvent:
 		switch l.view {
 		case "mr":

M internal/adapters/web/issues.go +90 -13


@@ -83,6 +83,58 @@ type IssuePage struct {
83	83		Form *CommentForm
84	84		Transition *IssueActions
85	85		Live bool
	86	+	// ClosedBy is the merge request whose merge closed the issue.
	87	+	ClosedBy *Link
	88	+	// References are the merge requests naming the issue.
	89	+	References []IssueRefView
	90	+	}
	91	+
	92	+	// IssueRefView is a merge request naming an issue.
	93	+	type IssueRefView struct {
	94	+	Number, Title, State, Href string
	95	+	Closes bool
	96	+	}
	97	+
	98	+	// maxNumberLookups bounds the lookups of #N references of one render.
	99	+	const maxNumberLookups = 50
	100	+
	101	+	// numberResolver resolves #N to the page of an issue or a merge request of
	102	+	// the repository. It is meant for one render: answers are memoized and at most
	103	+	// maxNumberLookups numbers are asked, the others do not resolve.
	104	+	func (s *Server) numberResolver(ctx context.Context, repo string) func(int64) (string, domain.NumberKind, bool) {
	105	+	if s.cfg.IssueNumbers == nil {
	106	+	return nil
	107	+	}
	108	+	name, err := domain.ParseRepoName(repo)
	109	+	if err != nil {
	110	+	return nil
	111	+	}
	112	+	type answer struct {
	113	+	href string
	114	+	kind domain.NumberKind
	115	+	ok bool
	116	+	}
	117	+	seen := map[int64]answer{}
	118	+	return func(n int64) (string, domain.NumberKind, bool) {
	119	+	if a, ok := seen[n]; ok {
	120	+	return a.href, a.kind, a.ok
	121	+	}
	122	+	if len(seen) >= maxNumberLookups {
	123	+	return "", domain.NumberNone, false
	124	+	}
	125	+	var a answer
	126	+	kind, err := s.cfg.IssueNumbers.Kind(ctx, principal(ctx), name, n)
	127	+	if err == nil {
	128	+	switch kind {
	129	+	case domain.NumberIssue:
	130	+	a = answer{issueHref(repo, n), kind, true}
	131	+	case domain.NumberMergeRequest:
	132	+	a = answer{mrHref(repo, n), kind, true}
	133	+	}
	134	+	}
	135	+	seen[n] = a
	136	+	return a.href, a.kind, a.ok
	137	+	}
86	138		}
87	139
88	140		// IssueNewPage is the form that opens an issue.

@@ -238,20 +290,11 @@ func (s Server) issueShow(ctx context.Context, r http.Request) (templ.Componen
238	290		Number: "#" + strconv.FormatInt(n, 10), Title: visibleText(i.Title.String()),
239	291		State: string(i.State), Open: i.IsOpen(),
240	292		}
241		-	if body := i.Body.String(); strings.TrimSpace(body) != "" {
242		-	var h template.HTML
243		-	var err error
244		-	if i.External {
245		-	// Written by an anonymous visitor: the untrusted policy.
246		-	h, err = s.md.renderUntrusted([]byte(body), "issue-desc-")
247		-	} else {
248		-	h, _, err = s.md.renderWithIDs([]byte(body), d.name(), d.repo.DefaultBranch, "", "issue-desc-")
249		-	}
250		-	if err != nil {
251		-	return nil, 0, err
252		-	}
253		-	p.Desc = h
	293	+	if p.Desc, err = s.issueBody(ctx, d, i); err != nil {
	294	+	return nil, 0, err
254	295		}
	296	+	p.ClosedBy = numberLink(d.name(), i.ClosedByMergeRequest)
	297	+	p.References = issueRefViews(d.name(), res.References)
255	298		p.Opened.Name = s.who(i.Author)
256	299		if i.External {
257	300		// The label is the visitor's, not the owner's: shown as plain text.

@@ -295,6 +338,40 @@ func (s Server) issueShow(ctx context.Context, r http.Request) (templ.Componen
295	338		return IssueShow(l, p), http.StatusOK, nil
296	339		}
297	340
	341	+	// issueBody renders the description of an issue; an issue from the public form
	342	+	// was written by an anonymous visitor and gets the untrusted policy.
	343	+	func (s Server) issueBody(ctx context.Context, d repoData, i domain.Issue) (template.HTML, error) {
	344	+	body := i.Body.String()
	345	+	if strings.TrimSpace(body) == "" {
	346	+	return "", nil
	347	+	}
	348	+	numbers := s.numberResolver(ctx, d.name())
	349	+	if i.External {
	350	+	return s.md.renderUntrusted([]byte(body), "issue-desc-", numbers)
	351	+	}
	352	+	return s.md.renderIssue([]byte(body), d.name(), d.repo.DefaultBranch, "issue-desc-", numbers)
	353	+	}
	354	+
	355	+	// numberLink links merge request n of repo; nil for 0.
	356	+	func numberLink(repo string, n int64) *Link {
	357	+	if n == 0 {
	358	+	return nil
	359	+	}
	360	+	return &Link{Label: "!" + strconv.FormatInt(n, 10), Href: mrHref(repo, n)}
	361	+	}
	362	+
	363	+	// issueRefViews are the merge requests that mention an issue.
	364	+	func issueRefViews(repo string, refs []ports.IssueReference) []IssueRefView {
	365	+	views := make([]IssueRefView, 0, len(refs))
	366	+	for _, ref := range refs {
	367	+	views = append(views, IssueRefView{
	368	+	Number: "!" + strconv.FormatInt(ref.Number, 10), Title: visibleText(ref.Title.String()),
	369	+	State: string(ref.State), Href: mrHref(repo, ref.Number), Closes: ref.Closes,
	370	+	})
	371	+	}
	372	+	return views
	373	+	}
	374	+
298	375		// pageOrRedirect is page(), except that a page that is not found may be the
299	376		// page of the other kind of the number: target then names where to send the
300	377		// visitor ("" when there is none).


@@ -83,6 +83,58 @@ type IssuePage struct {
83		Form *CommentForm	83		Form *CommentForm
84		Transition *IssueActions	84		Transition *IssueActions
85		Live bool	85		Live bool
			86	+	// ClosedBy is the merge request whose merge closed the issue.
			87	+	ClosedBy *Link
			88	+	// References are the merge requests naming the issue.
			89	+	References []IssueRefView
			90	+	}
			91	+
			92	+	// IssueRefView is a merge request naming an issue.
			93	+	type IssueRefView struct {
			94	+	Number, Title, State, Href string
			95	+	Closes bool
			96	+	}
			97	+
			98	+	// maxNumberLookups bounds the lookups of #N references of one render.
			99	+	const maxNumberLookups = 50
			100	+
			101	+	// numberResolver resolves #N to the page of an issue or a merge request of
			102	+	// the repository. It is meant for one render: answers are memoized and at most
			103	+	// maxNumberLookups numbers are asked, the others do not resolve.
			104	+	func (s *Server) numberResolver(ctx context.Context, repo string) func(int64) (string, domain.NumberKind, bool) {
			105	+	if s.cfg.IssueNumbers == nil {
			106	+	return nil
			107	+	}
			108	+	name, err := domain.ParseRepoName(repo)
			109	+	if err != nil {
			110	+	return nil
			111	+	}
			112	+	type answer struct {
			113	+	href string
			114	+	kind domain.NumberKind
			115	+	ok bool
			116	+	}
			117	+	seen := map[int64]answer{}
			118	+	return func(n int64) (string, domain.NumberKind, bool) {
			119	+	if a, ok := seen[n]; ok {
			120	+	return a.href, a.kind, a.ok
			121	+	}
			122	+	if len(seen) >= maxNumberLookups {
			123	+	return "", domain.NumberNone, false
			124	+	}
			125	+	var a answer
			126	+	kind, err := s.cfg.IssueNumbers.Kind(ctx, principal(ctx), name, n)
			127	+	if err == nil {
			128	+	switch kind {
			129	+	case domain.NumberIssue:
			130	+	a = answer{issueHref(repo, n), kind, true}
			131	+	case domain.NumberMergeRequest:
			132	+	a = answer{mrHref(repo, n), kind, true}
			133	+	}
			134	+	}
			135	+	seen[n] = a
			136	+	return a.href, a.kind, a.ok
			137	+	}
86		}	138		}
87			139
88		// IssueNewPage is the form that opens an issue.	140		// IssueNewPage is the form that opens an issue.

@@ -238,20 +290,11 @@ func (s Server) issueShow(ctx context.Context, r http.Request) (templ.Componen
238		Number: "#" + strconv.FormatInt(n, 10), Title: visibleText(i.Title.String()),	290		Number: "#" + strconv.FormatInt(n, 10), Title: visibleText(i.Title.String()),
239		State: string(i.State), Open: i.IsOpen(),	291		State: string(i.State), Open: i.IsOpen(),
240		}	292		}
241	-	if body := i.Body.String(); strings.TrimSpace(body) != "" {	293	+	if p.Desc, err = s.issueBody(ctx, d, i); err != nil {
242	-	var h template.HTML	294	+	return nil, 0, err
243	-	var err error
244	-	if i.External {
245	-	// Written by an anonymous visitor: the untrusted policy.
246	-	h, err = s.md.renderUntrusted([]byte(body), "issue-desc-")
247	-	} else {
248	-	h, _, err = s.md.renderWithIDs([]byte(body), d.name(), d.repo.DefaultBranch, "", "issue-desc-")
249	-	}
250	-	if err != nil {
251	-	return nil, 0, err
252	-	}
253	-	p.Desc = h
254		}	295		}
			296	+	p.ClosedBy = numberLink(d.name(), i.ClosedByMergeRequest)
			297	+	p.References = issueRefViews(d.name(), res.References)
255		p.Opened.Name = s.who(i.Author)	298		p.Opened.Name = s.who(i.Author)
256		if i.External {	299		if i.External {
257		// The label is the visitor's, not the owner's: shown as plain text.	300		// The label is the visitor's, not the owner's: shown as plain text.

@@ -295,6 +338,40 @@ func (s Server) issueShow(ctx context.Context, r http.Request) (templ.Componen
295		return IssueShow(l, p), http.StatusOK, nil	338		return IssueShow(l, p), http.StatusOK, nil
296		}	339		}
297			340
			341	+	// issueBody renders the description of an issue; an issue from the public form
			342	+	// was written by an anonymous visitor and gets the untrusted policy.
			343	+	func (s Server) issueBody(ctx context.Context, d repoData, i domain.Issue) (template.HTML, error) {
			344	+	body := i.Body.String()
			345	+	if strings.TrimSpace(body) == "" {
			346	+	return "", nil
			347	+	}
			348	+	numbers := s.numberResolver(ctx, d.name())
			349	+	if i.External {
			350	+	return s.md.renderUntrusted([]byte(body), "issue-desc-", numbers)
			351	+	}
			352	+	return s.md.renderIssue([]byte(body), d.name(), d.repo.DefaultBranch, "issue-desc-", numbers)
			353	+	}
			354	+
			355	+	// numberLink links merge request n of repo; nil for 0.
			356	+	func numberLink(repo string, n int64) *Link {
			357	+	if n == 0 {
			358	+	return nil
			359	+	}
			360	+	return &Link{Label: "!" + strconv.FormatInt(n, 10), Href: mrHref(repo, n)}
			361	+	}
			362	+
			363	+	// issueRefViews are the merge requests that mention an issue.
			364	+	func issueRefViews(repo string, refs []ports.IssueReference) []IssueRefView {
			365	+	views := make([]IssueRefView, 0, len(refs))
			366	+	for _, ref := range refs {
			367	+	views = append(views, IssueRefView{
			368	+	Number: "!" + strconv.FormatInt(ref.Number, 10), Title: visibleText(ref.Title.String()),
			369	+	State: string(ref.State), Href: mrHref(repo, ref.Number), Closes: ref.Closes,
			370	+	})
			371	+	}
			372	+	return views
			373	+	}
			374	+
298		// pageOrRedirect is page(), except that a page that is not found may be the	375		// pageOrRedirect is page(), except that a page that is not found may be the
299		// page of the other kind of the number: target then names where to send the	376		// page of the other kind of the number: target then names where to send the
300		// visitor ("" when there is none).	377		// visitor ("" when there is none).

M internal/adapters/web/issues.templ +21 -0


@@ -149,6 +149,10 @@ templ IssueShow(l Layout, p IssuePage) {
149	149		{ " · " }<time datetime={ p.Opened.WhenAt } title={ p.Opened.Abs }>{ p.Opened.When }</time>
150	150		}
151	151		</dd>
	152	+	if p.ClosedBy != nil {
	153	+	<dt>closed by</dt>
	154	+	<dd><a class="ref" href={ templ.SafeURL(p.ClosedBy.Href) }>{ p.ClosedBy.Label }</a></dd>
	155	+	}
152	156		if p.UpdatedAt != "" {
153	157		<dt>updated</dt>
154	158		<dd><time datetime={ p.UpdatedAt }>{ p.Updated }</time></dd>

@@ -178,6 +182,23 @@ templ IssueShow(l Layout, p IssuePage) {
178	182		}
179	183
180	184		templ issueRail(p IssuePage) {
	185	+	if len(p.References) > 0 {
	186	+	<section aria-labelledby="r-refs">
	187	+	<h2 id="r-refs">Merge requests</h2>
	188	+	<ul>
	189	+	for _, r := range p.References {
	190	+	<li>
	191	+	<a class="ref" href={ templ.SafeURL(r.Href) }>{ r.Number }</a>
	192	+	{ " " + r.Title + " " }
	193	+	<span class="mr-state" data-state={ r.State }>{ r.State }</span>
	194	+	if r.Closes {
	195	+	{ " · closes" }
	196	+	}
	197	+	</li>
	198	+	}
	199	+	</ul>
	200	+	</section>
	201	+	}
181	202		if p.Transition != nil {
182	203		<section aria-labelledby="r-act">
183	204		<h2 id="r-act">Issue</h2>


@@ -149,6 +149,10 @@ templ IssueShow(l Layout, p IssuePage) {
149	{ " · " }<time datetime={ p.Opened.WhenAt } title={ p.Opened.Abs }>{ p.Opened.When }</time>	149		{ " · " }<time datetime={ p.Opened.WhenAt } title={ p.Opened.Abs }>{ p.Opened.When }</time>
150	}	150		}
151	</dd>	151		</dd>
		152	+	if p.ClosedBy != nil {
		153	+	<dt>closed by</dt>
		154	+	<dd><a class="ref" href={ templ.SafeURL(p.ClosedBy.Href) }>{ p.ClosedBy.Label }</a></dd>
		155	+	}
152	if p.UpdatedAt != "" {	156		if p.UpdatedAt != "" {
153	<dt>updated</dt>	157		<dt>updated</dt>
154	<dd><time datetime={ p.UpdatedAt }>{ p.Updated }</time></dd>	158		<dd><time datetime={ p.UpdatedAt }>{ p.Updated }</time></dd>

@@ -178,6 +182,23 @@ templ IssueShow(l Layout, p IssuePage) {
178	}	182		}
179		183
180	templ issueRail(p IssuePage) {	184		templ issueRail(p IssuePage) {
		185	+	if len(p.References) > 0 {
		186	+	<section aria-labelledby="r-refs">
		187	+	<h2 id="r-refs">Merge requests</h2>
		188	+	<ul>
		189	+	for _, r := range p.References {
		190	+	<li>
		191	+	<a class="ref" href={ templ.SafeURL(r.Href) }>{ r.Number }</a>
		192	+	{ " " + r.Title + " " }
		193	+	<span class="mr-state" data-state={ r.State }>{ r.State }</span>
		194	+	if r.Closes {
		195	+	{ " · closes" }
		196	+	}
		197	+	</li>
		198	+	}
		199	+	</ul>
		200	+	</section>
		201	+	}
181	if p.Transition != nil {	202		if p.Transition != nil {
182	<section aria-labelledby="r-act">	203		<section aria-labelledby="r-act">
183	<h2 id="r-act">Issue</h2>	204		<h2 id="r-act">Issue</h2>

M internal/adapters/web/issues_templ.go +164 -36


@@ -712,17 +712,17 @@ func IssueShow(l Layout, p IssuePage) templ.Component {
712	712		if templ_7745c5c3_Err != nil {
713	713		return templ_7745c5c3_Err
714	714		}
715		-	if p.UpdatedAt != "" {
716		-	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 58, "<dt>updated</dt><dd><time datetime=\"")
	715	+	if p.ClosedBy != nil {
	716	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 58, "<dt>closed by</dt><dd><a class=\"ref\" href=\"")
717	717		if templ_7745c5c3_Err != nil {
718	718		return templ_7745c5c3_Err
719	719		}
720		-	var templ_7745c5c3_Var36 string
721		-	templ_7745c5c3_Var36, templ_7745c5c3_Err = templ.ResolveAttributeValue(p.UpdatedAt)
	720	+	var templ_7745c5c3_Var36 templ.SafeURL
	721	+	templ_7745c5c3_Var36, templ_7745c5c3_Err = templ.JoinURLErrs(templ.SafeURL(p.ClosedBy.Href))
722	722		if templ_7745c5c3_Err != nil {
723		-	return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 154, Col: 38}
	723	+	return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 154, Col: 62}
724	724		}
725		-	_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ_7745c5c3_Var36)
	725	+	_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var36))
726	726		if templ_7745c5c3_Err != nil {
727	727		return templ_7745c5c3_Err
728	728		}

@@ -731,25 +731,57 @@ func IssueShow(l Layout, p IssuePage) templ.Component {
731	731		return templ_7745c5c3_Err
732	732		}
733	733		var templ_7745c5c3_Var37 string
734		-	templ_7745c5c3_Var37, templ_7745c5c3_Err = templ.JoinStringErrs(p.Updated)
	734	+	templ_7745c5c3_Var37, templ_7745c5c3_Err = templ.JoinStringErrs(p.ClosedBy.Label)
735	735		if templ_7745c5c3_Err != nil {
736		-	return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 154, Col: 52}
	736	+	return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 154, Col: 83}
737	737		}
738	738		_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var37))
739	739		if templ_7745c5c3_Err != nil {
740	740		return templ_7745c5c3_Err
741	741		}
742		-	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 60, "</time></dd>")
	742	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 60, "</a></dd>")
	743	+	if templ_7745c5c3_Err != nil {
	744	+	return templ_7745c5c3_Err
	745	+	}
	746	+	}
	747	+	if p.UpdatedAt != "" {
	748	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 61, "<dt>updated</dt><dd><time datetime=\"")
	749	+	if templ_7745c5c3_Err != nil {
	750	+	return templ_7745c5c3_Err
	751	+	}
	752	+	var templ_7745c5c3_Var38 string
	753	+	templ_7745c5c3_Var38, templ_7745c5c3_Err = templ.ResolveAttributeValue(p.UpdatedAt)
	754	+	if templ_7745c5c3_Err != nil {
	755	+	return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 158, Col: 38}
	756	+	}
	757	+	_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ_7745c5c3_Var38)
	758	+	if templ_7745c5c3_Err != nil {
	759	+	return templ_7745c5c3_Err
	760	+	}
	761	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 62, "\">")
	762	+	if templ_7745c5c3_Err != nil {
	763	+	return templ_7745c5c3_Err
	764	+	}
	765	+	var templ_7745c5c3_Var39 string
	766	+	templ_7745c5c3_Var39, templ_7745c5c3_Err = templ.JoinStringErrs(p.Updated)
	767	+	if templ_7745c5c3_Err != nil {
	768	+	return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 158, Col: 52}
	769	+	}
	770	+	_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var39))
	771	+	if templ_7745c5c3_Err != nil {
	772	+	return templ_7745c5c3_Err
	773	+	}
	774	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 63, "</time></dd>")
743	775		if templ_7745c5c3_Err != nil {
744	776		return templ_7745c5c3_Err
745	777		}
746	778		}
747		-	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 61, "</dl></header>")
	779	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 64, "</dl></header>")
748	780		if templ_7745c5c3_Err != nil {
749	781		return templ_7745c5c3_Err
750	782		}
751	783		if p.Desc != "" {
752		-	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 62, "<article class=\"mr-desc prose\" aria-label=\"description\" hx-ignore>")
	784	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 65, "<article class=\"mr-desc prose\" aria-label=\"description\" hx-ignore>")
753	785		if templ_7745c5c3_Err != nil {
754	786		return templ_7745c5c3_Err
755	787		}

@@ -757,12 +789,12 @@ func IssueShow(l Layout, p IssuePage) templ.Component {
757	789		if templ_7745c5c3_Err != nil {
758	790		return templ_7745c5c3_Err
759	791		}
760		-	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 63, "</article>")
	792	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 66, "</article>")
761	793		if templ_7745c5c3_Err != nil {
762	794		return templ_7745c5c3_Err
763	795		}
764	796		}
765		-	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 64, "</section>")
	797	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 67, "</section>")
766	798		if templ_7745c5c3_Err != nil {
767	799		return templ_7745c5c3_Err
768	800		}

@@ -772,20 +804,20 @@ func IssueShow(l Layout, p IssuePage) templ.Component {
772	804		return templ_7745c5c3_Err
773	805		}
774	806		}
775		-	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 65, " <h2 class=\"rule-h\" id=\"comments\"><span>Comments</span><span class=\"count\">")
	807	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 68, " <h2 class=\"rule-h\" id=\"comments\"><span>Comments</span><span class=\"count\">")
776	808		if templ_7745c5c3_Err != nil {
777	809		return templ_7745c5c3_Err
778	810		}
779		-	var templ_7745c5c3_Var38 string
780		-	templ_7745c5c3_Var38, templ_7745c5c3_Err = templ.JoinStringErrs(itoa(len(p.Comments)))
	811	+	var templ_7745c5c3_Var40 string
	812	+	templ_7745c5c3_Var40, templ_7745c5c3_Err = templ.JoinStringErrs(itoa(len(p.Comments)))
781	813		if templ_7745c5c3_Err != nil {
782		-	return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 167, Col: 99}
	814	+	return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 171, Col: 99}
783	815		}
784		-	_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var38))
	816	+	_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var40))
785	817		if templ_7745c5c3_Err != nil {
786	818		return templ_7745c5c3_Err
787	819		}
788		-	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 66, "</span></h2>")
	820	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 69, "</span></h2>")
789	821		if templ_7745c5c3_Err != nil {
790	822		return templ_7745c5c3_Err
791	823		}

@@ -795,17 +827,17 @@ func IssueShow(l Layout, p IssuePage) templ.Component {
795	827		return templ_7745c5c3_Err
796	828		}
797	829		}
798		-	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 67, " ")
	830	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 70, " ")
799	831		if templ_7745c5c3_Err != nil {
800	832		return templ_7745c5c3_Err
801	833		}
802	834		if len(p.Comments) == 0 {
803		-	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 68, "<p class=\"dim\">no comments yet.</p>")
	835	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 71, "<p class=\"dim\">no comments yet.</p>")
804	836		if templ_7745c5c3_Err != nil {
805	837		return templ_7745c5c3_Err
806	838		}
807	839		}
808		-	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 69, " ")
	840	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 72, " ")
809	841		if templ_7745c5c3_Err != nil {
810	842		return templ_7745c5c3_Err
811	843		}

@@ -841,39 +873,135 @@ func issueRail(p IssuePage) templ.Component {
841	873		}()
842	874		}
843	875		ctx = templ.InitializeContext(ctx)
844		-	templ_7745c5c3_Var39 := templ.GetChildren(ctx)
845		-	if templ_7745c5c3_Var39 == nil {
846		-	templ_7745c5c3_Var39 = templ.NopComponent
	876	+	templ_7745c5c3_Var41 := templ.GetChildren(ctx)
	877	+	if templ_7745c5c3_Var41 == nil {
	878	+	templ_7745c5c3_Var41 = templ.NopComponent
847	879		}
848	880		ctx = templ.ClearChildren(ctx)
	881	+	if len(p.References) > 0 {
	882	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 73, "<section aria-labelledby=\"r-refs\"><h2 id=\"r-refs\">Merge requests</h2><ul>")
	883	+	if templ_7745c5c3_Err != nil {
	884	+	return templ_7745c5c3_Err
	885	+	}
	886	+	for _, r := range p.References {
	887	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 74, "<li><a class=\"ref\" href=\"")
	888	+	if templ_7745c5c3_Err != nil {
	889	+	return templ_7745c5c3_Err
	890	+	}
	891	+	var templ_7745c5c3_Var42 templ.SafeURL
	892	+	templ_7745c5c3_Var42, templ_7745c5c3_Err = templ.JoinURLErrs(templ.SafeURL(r.Href))
	893	+	if templ_7745c5c3_Err != nil {
	894	+	return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 191, Col: 49}
	895	+	}
	896	+	_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var42))
	897	+	if templ_7745c5c3_Err != nil {
	898	+	return templ_7745c5c3_Err
	899	+	}
	900	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 75, "\">")
	901	+	if templ_7745c5c3_Err != nil {
	902	+	return templ_7745c5c3_Err
	903	+	}
	904	+	var templ_7745c5c3_Var43 string
	905	+	templ_7745c5c3_Var43, templ_7745c5c3_Err = templ.JoinStringErrs(r.Number)
	906	+	if templ_7745c5c3_Err != nil {
	907	+	return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 191, Col: 62}
	908	+	}
	909	+	_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var43))
	910	+	if templ_7745c5c3_Err != nil {
	911	+	return templ_7745c5c3_Err
	912	+	}
	913	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 76, "</a> ")
	914	+	if templ_7745c5c3_Err != nil {
	915	+	return templ_7745c5c3_Err
	916	+	}
	917	+	var templ_7745c5c3_Var44 string
	918	+	templ_7745c5c3_Var44, templ_7745c5c3_Err = templ.JoinStringErrs(" " + r.Title + " ")
	919	+	if templ_7745c5c3_Err != nil {
	920	+	return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 192, Col: 27}
	921	+	}
	922	+	_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var44))
	923	+	if templ_7745c5c3_Err != nil {
	924	+	return templ_7745c5c3_Err
	925	+	}
	926	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 77, " <span class=\"mr-state\" data-state=\"")
	927	+	if templ_7745c5c3_Err != nil {
	928	+	return templ_7745c5c3_Err
	929	+	}
	930	+	var templ_7745c5c3_Var45 string
	931	+	templ_7745c5c3_Var45, templ_7745c5c3_Err = templ.ResolveAttributeValue(r.State)
	932	+	if templ_7745c5c3_Err != nil {
	933	+	return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 193, Col: 49}
	934	+	}
	935	+	_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ_7745c5c3_Var45)
	936	+	if templ_7745c5c3_Err != nil {
	937	+	return templ_7745c5c3_Err
	938	+	}
	939	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 78, "\">")
	940	+	if templ_7745c5c3_Err != nil {
	941	+	return templ_7745c5c3_Err
	942	+	}
	943	+	var templ_7745c5c3_Var46 string
	944	+	templ_7745c5c3_Var46, templ_7745c5c3_Err = templ.JoinStringErrs(r.State)
	945	+	if templ_7745c5c3_Err != nil {
	946	+	return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 193, Col: 61}
	947	+	}
	948	+	_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var46))
	949	+	if templ_7745c5c3_Err != nil {
	950	+	return templ_7745c5c3_Err
	951	+	}
	952	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 79, "</span> ")
	953	+	if templ_7745c5c3_Err != nil {
	954	+	return templ_7745c5c3_Err
	955	+	}
	956	+	if r.Closes {
	957	+	var templ_7745c5c3_Var47 string
	958	+	templ_7745c5c3_Var47, templ_7745c5c3_Err = templ.JoinStringErrs(" · closes")
	959	+	if templ_7745c5c3_Err != nil {
	960	+	return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 195, Col: 21}
	961	+	}
	962	+	_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var47))
	963	+	if templ_7745c5c3_Err != nil {
	964	+	return templ_7745c5c3_Err
	965	+	}
	966	+	}
	967	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 80, "</li>")
	968	+	if templ_7745c5c3_Err != nil {
	969	+	return templ_7745c5c3_Err
	970	+	}
	971	+	}
	972	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 81, "</ul></section>")
	973	+	if templ_7745c5c3_Err != nil {
	974	+	return templ_7745c5c3_Err
	975	+	}
	976	+	}
849	977		if p.Transition != nil {
850		-	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 70, "<section aria-labelledby=\"r-act\"><h2 id=\"r-act\">Issue</h2><form method=\"post\" action=\"")
	978	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 82, "<section aria-labelledby=\"r-act\"><h2 id=\"r-act\">Issue</h2><form method=\"post\" action=\"")
851	979		if templ_7745c5c3_Err != nil {
852	980		return templ_7745c5c3_Err
853	981		}
854		-	var templ_7745c5c3_Var40 templ.SafeURL
855		-	templ_7745c5c3_Var40, templ_7745c5c3_Err = templ.JoinURLErrs(templ.SafeURL(p.Transition.Action))
	982	+	var templ_7745c5c3_Var48 templ.SafeURL
	983	+	templ_7745c5c3_Var48, templ_7745c5c3_Err = templ.JoinURLErrs(templ.SafeURL(p.Transition.Action))
856	984		if templ_7745c5c3_Err != nil {
857		-	return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 184, Col: 66}
	985	+	return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 205, Col: 66}
858	986		}
859		-	_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var40))
	987	+	_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var48))
860	988		if templ_7745c5c3_Err != nil {
861	989		return templ_7745c5c3_Err
862	990		}
863		-	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 71, "\"><button type=\"submit\" class=\"btn\">")
	991	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 83, "\"><button type=\"submit\" class=\"btn\">")
864	992		if templ_7745c5c3_Err != nil {
865	993		return templ_7745c5c3_Err
866	994		}
867		-	var templ_7745c5c3_Var41 string
868		-	templ_7745c5c3_Var41, templ_7745c5c3_Err = templ.JoinStringErrs(p.Transition.Label)
	995	+	var templ_7745c5c3_Var49 string
	996	+	templ_7745c5c3_Var49, templ_7745c5c3_Err = templ.JoinStringErrs(p.Transition.Label)
869	997		if templ_7745c5c3_Err != nil {
870		-	return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 185, Col: 58}
	998	+	return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 206, Col: 58}
871	999		}
872		-	_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var41))
	1000	+	_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var49))
873	1001		if templ_7745c5c3_Err != nil {
874	1002		return templ_7745c5c3_Err
875	1003		}
876		-	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 72, "</button></form></section>")
	1004	+	templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 84, "</button></form></section>")
877	1005		if templ_7745c5c3_Err != nil {
878	1006		return templ_7745c5c3_Err
879	1007		}

 			if templ_7745c5c3_Err != nil {
 				return templ_7745c5c3_Err
 			}
-			if p.UpdatedAt != "" {
+			if p.ClosedBy != nil {
-				templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 58, "<dt>updated</dt><dd><time datetime=\"")
+				templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 58, "<dt>closed by</dt><dd><a class=\"ref\" href=\"")
 				if templ_7745c5c3_Err != nil {
 					return templ_7745c5c3_Err
 				}
-				var templ_7745c5c3_Var36 string
+				var templ_7745c5c3_Var36 templ.SafeURL
-				templ_7745c5c3_Var36, templ_7745c5c3_Err = templ.ResolveAttributeValue(p.UpdatedAt)
+				templ_7745c5c3_Var36, templ_7745c5c3_Err = templ.JoinURLErrs(templ.SafeURL(p.ClosedBy.Href))
 				if templ_7745c5c3_Err != nil {
-					return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 154, Col: 38}
+					return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 154, Col: 62}
 				}
-				_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ_7745c5c3_Var36)
+				_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var36))
 				if templ_7745c5c3_Err != nil {
 					return templ_7745c5c3_Err
 				}
 					return templ_7745c5c3_Err
 				}
 				var templ_7745c5c3_Var37 string
-				templ_7745c5c3_Var37, templ_7745c5c3_Err = templ.JoinStringErrs(p.Updated)
+				templ_7745c5c3_Var37, templ_7745c5c3_Err = templ.JoinStringErrs(p.ClosedBy.Label)
 				if templ_7745c5c3_Err != nil {
-					return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 154, Col: 52}
+					return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 154, Col: 83}
 				}
 				_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var37))
 				if templ_7745c5c3_Err != nil {
 					return templ_7745c5c3_Err
 				}
-				templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 60, "</time></dd>")
+				templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 60, "</a></dd>")
+				if templ_7745c5c3_Err != nil {
+					return templ_7745c5c3_Err
+				}
+			}
+			if p.UpdatedAt != "" {
+				templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 61, "<dt>updated</dt><dd><time datetime=\"")
+				if templ_7745c5c3_Err != nil {
+					return templ_7745c5c3_Err
+				}
+				var templ_7745c5c3_Var38 string
+				templ_7745c5c3_Var38, templ_7745c5c3_Err = templ.ResolveAttributeValue(p.UpdatedAt)
+				if templ_7745c5c3_Err != nil {
+					return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 158, Col: 38}
+				}
+				_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ_7745c5c3_Var38)
+				if templ_7745c5c3_Err != nil {
+					return templ_7745c5c3_Err
+				}
+				templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 62, "\">")
+				if templ_7745c5c3_Err != nil {
+					return templ_7745c5c3_Err
+				}
+				var templ_7745c5c3_Var39 string
+				templ_7745c5c3_Var39, templ_7745c5c3_Err = templ.JoinStringErrs(p.Updated)
+				if templ_7745c5c3_Err != nil {
+					return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 158, Col: 52}
+				}
+				_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var39))
+				if templ_7745c5c3_Err != nil {
+					return templ_7745c5c3_Err
+				}
+				templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 63, "</time></dd>")
 				if templ_7745c5c3_Err != nil {
 					return templ_7745c5c3_Err
 				}
 			}
-			templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 61, "</dl></header>")
+			templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 64, "</dl></header>")
 			if templ_7745c5c3_Err != nil {
 				return templ_7745c5c3_Err
 			}
 			if p.Desc != "" {
-				templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 62, "<article class=\"mr-desc prose\" aria-label=\"description\" hx-ignore>")
+				templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 65, "<article class=\"mr-desc prose\" aria-label=\"description\" hx-ignore>")
 				if templ_7745c5c3_Err != nil {
 					return templ_7745c5c3_Err
 				}
 				if templ_7745c5c3_Err != nil {
 					return templ_7745c5c3_Err
 				}
-				templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 63, "</article>")
+				templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 66, "</article>")
 				if templ_7745c5c3_Err != nil {
 					return templ_7745c5c3_Err
 				}
 			}
-			templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 64, "</section>")
+			templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 67, "</section>")
 			if templ_7745c5c3_Err != nil {
 				return templ_7745c5c3_Err
 			}
 					return templ_7745c5c3_Err
 				}
 			}
-			templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 65, " <h2 class=\"rule-h\" id=\"comments\"><span>Comments</span><span class=\"count\">")
+			templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 68, " <h2 class=\"rule-h\" id=\"comments\"><span>Comments</span><span class=\"count\">")
 			if templ_7745c5c3_Err != nil {
 				return templ_7745c5c3_Err
 			}
-			var templ_7745c5c3_Var38 string
+			var templ_7745c5c3_Var40 string
-			templ_7745c5c3_Var38, templ_7745c5c3_Err = templ.JoinStringErrs(itoa(len(p.Comments)))
+			templ_7745c5c3_Var40, templ_7745c5c3_Err = templ.JoinStringErrs(itoa(len(p.Comments)))
 			if templ_7745c5c3_Err != nil {
-				return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 167, Col: 99}
+				return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 171, Col: 99}
 			}
-			_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var38))
+			_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var40))
 			if templ_7745c5c3_Err != nil {
 				return templ_7745c5c3_Err
 			}
-			templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 66, "</span></h2>")
+			templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 69, "</span></h2>")
 			if templ_7745c5c3_Err != nil {
 				return templ_7745c5c3_Err
 			}
 					return templ_7745c5c3_Err
 				}
 			}
-			templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 67, " ")
+			templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 70, " ")
 			if templ_7745c5c3_Err != nil {
 				return templ_7745c5c3_Err
 			}
 			if len(p.Comments) == 0 {
-				templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 68, "<p class=\"dim\">no comments yet.</p>")
+				templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 71, "<p class=\"dim\">no comments yet.</p>")
 				if templ_7745c5c3_Err != nil {
 					return templ_7745c5c3_Err
 				}
 			}
-			templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 69, " ")
+			templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 72, " ")
 			if templ_7745c5c3_Err != nil {
 				return templ_7745c5c3_Err
 			}
 			}()
 		}
 		ctx = templ.InitializeContext(ctx)
-		templ_7745c5c3_Var39 := templ.GetChildren(ctx)
+		templ_7745c5c3_Var41 := templ.GetChildren(ctx)
-		if templ_7745c5c3_Var39 == nil {
+		if templ_7745c5c3_Var41 == nil {
-			templ_7745c5c3_Var39 = templ.NopComponent
+			templ_7745c5c3_Var41 = templ.NopComponent
 		}
 		ctx = templ.ClearChildren(ctx)
+		if len(p.References) > 0 {
+			templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 73, "<section aria-labelledby=\"r-refs\"><h2 id=\"r-refs\">Merge requests</h2><ul>")
+			if templ_7745c5c3_Err != nil {
+				return templ_7745c5c3_Err
+			}
+			for _, r := range p.References {
+				templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 74, "<li><a class=\"ref\" href=\"")
+				if templ_7745c5c3_Err != nil {
+					return templ_7745c5c3_Err
+				}
+				var templ_7745c5c3_Var42 templ.SafeURL
+				templ_7745c5c3_Var42, templ_7745c5c3_Err = templ.JoinURLErrs(templ.SafeURL(r.Href))
+				if templ_7745c5c3_Err != nil {
+					return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 191, Col: 49}
+				}
+				_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var42))
+				if templ_7745c5c3_Err != nil {
+					return templ_7745c5c3_Err
+				}
+				templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 75, "\">")
+				if templ_7745c5c3_Err != nil {
+					return templ_7745c5c3_Err
+				}
+				var templ_7745c5c3_Var43 string
+				templ_7745c5c3_Var43, templ_7745c5c3_Err = templ.JoinStringErrs(r.Number)
+				if templ_7745c5c3_Err != nil {
+					return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 191, Col: 62}
+				}
+				_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var43))
+				if templ_7745c5c3_Err != nil {
+					return templ_7745c5c3_Err
+				}
+				templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 76, "</a> ")
+				if templ_7745c5c3_Err != nil {
+					return templ_7745c5c3_Err
+				}
+				var templ_7745c5c3_Var44 string
+				templ_7745c5c3_Var44, templ_7745c5c3_Err = templ.JoinStringErrs(" " + r.Title + " ")
+				if templ_7745c5c3_Err != nil {
+					return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 192, Col: 27}
+				}
+				_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var44))
+				if templ_7745c5c3_Err != nil {
+					return templ_7745c5c3_Err
+				}
+				templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 77, " <span class=\"mr-state\" data-state=\"")
+				if templ_7745c5c3_Err != nil {
+					return templ_7745c5c3_Err
+				}
+				var templ_7745c5c3_Var45 string
+				templ_7745c5c3_Var45, templ_7745c5c3_Err = templ.ResolveAttributeValue(r.State)
+				if templ_7745c5c3_Err != nil {
+					return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 193, Col: 49}
+				}
+				_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ_7745c5c3_Var45)
+				if templ_7745c5c3_Err != nil {
+					return templ_7745c5c3_Err
+				}
+				templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 78, "\">")
+				if templ_7745c5c3_Err != nil {
+					return templ_7745c5c3_Err
+				}
+				var templ_7745c5c3_Var46 string
+				templ_7745c5c3_Var46, templ_7745c5c3_Err = templ.JoinStringErrs(r.State)
+				if templ_7745c5c3_Err != nil {
+					return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 193, Col: 61}
+				}
+				_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var46))
+				if templ_7745c5c3_Err != nil {
+					return templ_7745c5c3_Err
+				}
+				templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 79, "</span> ")
+				if templ_7745c5c3_Err != nil {
+					return templ_7745c5c3_Err
+				}
+				if r.Closes {
+					var templ_7745c5c3_Var47 string
+					templ_7745c5c3_Var47, templ_7745c5c3_Err = templ.JoinStringErrs(" · closes")
+					if templ_7745c5c3_Err != nil {
+						return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 195, Col: 21}
+					}
+					_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var47))
+					if templ_7745c5c3_Err != nil {
+						return templ_7745c5c3_Err
+					}
+				}
+				templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 80, "</li>")
+				if templ_7745c5c3_Err != nil {
+					return templ_7745c5c3_Err
+				}
+			}
+			templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 81, "</ul></section>")
+			if templ_7745c5c3_Err != nil {
+				return templ_7745c5c3_Err
+			}
+		}
 		if p.Transition != nil {
-			templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 70, "<section aria-labelledby=\"r-act\"><h2 id=\"r-act\">Issue</h2><form method=\"post\" action=\"")
+			templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 82, "<section aria-labelledby=\"r-act\"><h2 id=\"r-act\">Issue</h2><form method=\"post\" action=\"")
 			if templ_7745c5c3_Err != nil {
 				return templ_7745c5c3_Err
 			}
-			var templ_7745c5c3_Var40 templ.SafeURL
+			var templ_7745c5c3_Var48 templ.SafeURL
-			templ_7745c5c3_Var40, templ_7745c5c3_Err = templ.JoinURLErrs(templ.SafeURL(p.Transition.Action))
+			templ_7745c5c3_Var48, templ_7745c5c3_Err = templ.JoinURLErrs(templ.SafeURL(p.Transition.Action))
 			if templ_7745c5c3_Err != nil {
-				return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 184, Col: 66}
+				return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 205, Col: 66}
 			}
-			_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var40))
+			_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var48))
 			if templ_7745c5c3_Err != nil {
 				return templ_7745c5c3_Err
 			}
-			templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 71, "\"><button type=\"submit\" class=\"btn\">")
+			templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 83, "\"><button type=\"submit\" class=\"btn\">")
 			if templ_7745c5c3_Err != nil {
 				return templ_7745c5c3_Err
 			}
-			var templ_7745c5c3_Var41 string
+			var templ_7745c5c3_Var49 string
-			templ_7745c5c3_Var41, templ_7745c5c3_Err = templ.JoinStringErrs(p.Transition.Label)
+			templ_7745c5c3_Var49, templ_7745c5c3_Err = templ.JoinStringErrs(p.Transition.Label)
 			if templ_7745c5c3_Err != nil {
-				return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 185, Col: 58}
+				return templ.Error{Err: templ_7745c5c3_Err, FileName: `internal/adapters/web/issues.templ`, Line: 206, Col: 58}
 			}
-			_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var41))
+			_, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var49))
 			if templ_7745c5c3_Err != nil {
 				return templ_7745c5c3_Err
 			}
-			templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 72, "</button></form></section>")
+			templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 84, "</button></form></section>")
 			if templ_7745c5c3_Err != nil {
 				return templ_7745c5c3_Err
 			}

M internal/adapters/web/issues_test.go +45 -0


@@ -309,6 +309,8 @@ func TestIssueLiveNotices(t *testing.T) {
309	309		{domain.IssueReopened{Issue: issue}, "issue", "5", "this issue was reopened"},
310	310		{domain.IssueCommented{Repo: issue.Repo, Number: 5}, "issue", "5", "a comment was added"},
311	311		{domain.IssueCommented{Repo: issue.Repo, Number: 6}, "issue", "5", ""},
	312	+	{domain.IssueReferenced{Repo: issue.Repo, Issue: 5, MergeRequest: 2}, "issue", "5", "a merge request mentions this issue"},
	313	+	{domain.IssueReferenced{Repo: issue.Repo, Issue: 6, MergeRequest: 2}, "issue", "5", ""},
312	314		{domain.IssueClosed{Issue: issue}, "mrs", "", ""},
313	315		{domain.IssueClosed{Issue: issue}, "summary", "", ""},
314	316		}

@@ -330,3 +332,46 @@ func TestIssueLiveNotices(t *testing.T) {
330	332		require.NoError(t, err)
331	333		assert.Empty(t, got)
332	334		}
	335	+
	336	+	func TestIssueShowReferences(t *testing.T) {
	337	+	t.Parallel()
	338	+	r := newIssueRig(t, domain.IssuesPublic, true)
	339	+	title, err := domain.ParseMRTitle("fix <b>it</b>")
	340	+	require.NoError(t, err)
	341	+	issue := testIssue(t, 5, domain.IssueStateClosed, "bug", "see #7 and #8")
	342	+	issue.ClosedByMergeRequest = 2
	343	+	r.issues.EXPECT().Get(mock.Anything, mock.Anything, repoName(t, "proj"), int64(5)).Return(ports.IssueDetail{
	344	+	Issue: issue,
	345	+	References: []ports.IssueReference{
	346	+	{Number: 2, Title: title, State: domain.MRStateMerged, Closes: true},
	347	+	{Number: 3, Title: title, State: domain.MRStateOpen},
	348	+	},
	349	+	}, nil)
	350	+	r.nums.EXPECT().Kind(mock.Anything, mock.Anything, repoName(t, "proj"), int64(7)).Return(domain.NumberMergeRequest, nil)
	351	+	r.nums.EXPECT().Kind(mock.Anything, mock.Anything, repoName(t, "proj"), int64(8)).Return(domain.NumberNone, nil)
	352	+
	353	+	rec := r.do("GET", "/proj/issues/5", false, nil)
	354	+	require.Equal(t, 200, rec.Code, rec.Body.String())
	355	+	body := rec.Body.String()
	356	+	assert.Contains(t, body, "closed by")
	357	+	assert.Contains(t, body, `href="/proj/merge-requests/2"`)
	358	+	assert.Contains(t, body, ">!2<")
	359	+	assert.Contains(t, body, ">!3<")
	360	+	assert.Contains(t, body, `id="r-refs"`)
	361	+	assert.Contains(t, body, "closes")
	362	+	assert.Contains(t, body, "fix <b>it</b>")
	363	+	assert.Contains(t, body, `href="/proj/merge-requests/7"`, "#7 in the body")
	364	+	assert.Contains(t, body, `title="merge request 7"`)
	365	+	assert.NotContains(t, body, `/issues/8"`)
	366	+	}
	367	+
	368	+	func TestIssueShowWithoutReferences(t *testing.T) {
	369	+	t.Parallel()
	370	+	r := newIssueRig(t, domain.IssuesPublic, false)
	371	+	r.issues.EXPECT().Get(mock.Anything, mock.Anything, mock.Anything, int64(5)).Return(ports.IssueDetail{
	372	+	Issue: testIssue(t, 5, domain.IssueStateOpen, "bug", ""),
	373	+	}, nil)
	374	+	body := r.do("GET", "/proj/issues/5", false, nil).Body.String()
	375	+	assert.NotContains(t, body, "r-refs")
	376	+	assert.NotContains(t, body, "closed by")
	377	+	}


@@ -309,6 +309,8 @@ func TestIssueLiveNotices(t *testing.T) {
309	{domain.IssueReopened{Issue: issue}, "issue", "5", "this issue was reopened"},	309		{domain.IssueReopened{Issue: issue}, "issue", "5", "this issue was reopened"},
310	{domain.IssueCommented{Repo: issue.Repo, Number: 5}, "issue", "5", "a comment was added"},	310		{domain.IssueCommented{Repo: issue.Repo, Number: 5}, "issue", "5", "a comment was added"},
311	{domain.IssueCommented{Repo: issue.Repo, Number: 6}, "issue", "5", ""},	311		{domain.IssueCommented{Repo: issue.Repo, Number: 6}, "issue", "5", ""},
		312	+	{domain.IssueReferenced{Repo: issue.Repo, Issue: 5, MergeRequest: 2}, "issue", "5", "a merge request mentions this issue"},
		313	+	{domain.IssueReferenced{Repo: issue.Repo, Issue: 6, MergeRequest: 2}, "issue", "5", ""},
312	{domain.IssueClosed{Issue: issue}, "mrs", "", ""},	314		{domain.IssueClosed{Issue: issue}, "mrs", "", ""},
313	{domain.IssueClosed{Issue: issue}, "summary", "", ""},	315		{domain.IssueClosed{Issue: issue}, "summary", "", ""},
314	}	316		}

@@ -330,3 +332,46 @@ func TestIssueLiveNotices(t *testing.T) {
330	require.NoError(t, err)	332		require.NoError(t, err)
331	assert.Empty(t, got)	333		assert.Empty(t, got)
332	}	334		}
		335	+
		336	+	func TestIssueShowReferences(t *testing.T) {
		337	+	t.Parallel()
		338	+	r := newIssueRig(t, domain.IssuesPublic, true)
		339	+	title, err := domain.ParseMRTitle("fix <b>it</b>")
		340	+	require.NoError(t, err)
		341	+	issue := testIssue(t, 5, domain.IssueStateClosed, "bug", "see #7 and #8")
		342	+	issue.ClosedByMergeRequest = 2
		343	+	r.issues.EXPECT().Get(mock.Anything, mock.Anything, repoName(t, "proj"), int64(5)).Return(ports.IssueDetail{
		344	+	Issue: issue,
		345	+	References: []ports.IssueReference{
		346	+	{Number: 2, Title: title, State: domain.MRStateMerged, Closes: true},
		347	+	{Number: 3, Title: title, State: domain.MRStateOpen},
		348	+	},
		349	+	}, nil)
		350	+	r.nums.EXPECT().Kind(mock.Anything, mock.Anything, repoName(t, "proj"), int64(7)).Return(domain.NumberMergeRequest, nil)
		351	+	r.nums.EXPECT().Kind(mock.Anything, mock.Anything, repoName(t, "proj"), int64(8)).Return(domain.NumberNone, nil)
		352	+
		353	+	rec := r.do("GET", "/proj/issues/5", false, nil)
		354	+	require.Equal(t, 200, rec.Code, rec.Body.String())
		355	+	body := rec.Body.String()
		356	+	assert.Contains(t, body, "closed by")
		357	+	assert.Contains(t, body, `href="/proj/merge-requests/2"`)
		358	+	assert.Contains(t, body, ">!2<")
		359	+	assert.Contains(t, body, ">!3<")
		360	+	assert.Contains(t, body, `id="r-refs"`)
		361	+	assert.Contains(t, body, "closes")
		362	+	assert.Contains(t, body, "fix <b>it</b>")
		363	+	assert.Contains(t, body, `href="/proj/merge-requests/7"`, "#7 in the body")
		364	+	assert.Contains(t, body, `title="merge request 7"`)
		365	+	assert.NotContains(t, body, `/issues/8"`)
		366	+	}
		367	+
		368	+	func TestIssueShowWithoutReferences(t *testing.T) {
		369	+	t.Parallel()
		370	+	r := newIssueRig(t, domain.IssuesPublic, false)
		371	+	r.issues.EXPECT().Get(mock.Anything, mock.Anything, mock.Anything, int64(5)).Return(ports.IssueDetail{
		372	+	Issue: testIssue(t, 5, domain.IssueStateOpen, "bug", ""),
		373	+	}, nil)
		374	+	body := r.do("GET", "/proj/issues/5", false, nil).Body.String()
		375	+	assert.NotContains(t, body, "r-refs")
		376	+	assert.NotContains(t, body, "closed by")
		377	+	}

M internal/adapters/web/markdown.go +73 -23


@@ -12,6 +12,7 @@ import (
12	12		"strings"
13	13		"time"
14	14
	15	+	"bnema.dev/ermite/internal/domain"
15	16		"github.com/yuin/goldmark"
16	17		"github.com/yuin/goldmark/ast"
17	18		"github.com/yuin/goldmark/extension"

@@ -65,15 +66,32 @@ func (m *markdown) render(source []byte, repo, ref, dir string) (template.HTML,
65	66		// #fragment links chosen, so that several documents on one page (the summaries
66	67		// of a run) do not share ids.
67	68		func (m *markdown) renderWithIDs(source []byte, repo, ref, dir, idPrefix string) (template.HTML, []Heading, error) {
68		-	return m.renderPolicy(source, linkPolicy{repo: repo, ref: ref, dir: dir, idPrefix: idPrefix}, nil)
	69	+	return m.renderPolicy(source, linkPolicy{repo: repo, ref: ref, dir: dir, idPrefix: idPrefix}, refResolver{})
69	70		}
70	71
71		-	// renderNote uses the repository Markdown policy, then adds local note links.
72		-	func (m *markdown) renderNote(source []byte, repo, ref, idPrefix string, notes func(int64) bool) (template.HTML, error) {
73		-	h, _, err := m.renderPolicy(source, linkPolicy{repo: repo, ref: ref, idPrefix: idPrefix}, notes)
	72	+	// renderNote uses the repository Markdown policy, then adds local note links
	73	+	// and links to issues and merge requests.
	74	+	func (m *markdown) renderNote(source []byte, repo, ref, idPrefix string, refs refResolver) (template.HTML, error) {
	75	+	h, _, err := m.renderPolicy(source, linkPolicy{repo: repo, ref: ref, idPrefix: idPrefix}, refs)
74	76		return h, err
75	77		}
76	78
	79	+	// renderIssue renders the trusted body of an issue: the policy of render, plus
	80	+	// links to issues and merge requests.
	81	+	func (m *markdown) renderIssue(source []byte, repo, ref, idPrefix string, numbers func(int64) (string, domain.NumberKind, bool)) (template.HTML, error) {
	82	+	h, _, err := m.renderPolicy(source, linkPolicy{repo: repo, ref: ref, idPrefix: idPrefix}, refResolver{numbers: numbers})
	83	+	return h, err
	84	+	}
	85	+
	86	+	// refResolver tells which references of a text are links.
	87	+	type refResolver struct {
	88	+	// notes tells whether ^N names a note of the page (nil: no ^N links).
	89	+	notes func(int64) bool
	90	+	// numbers gives the page of the issue or merge request #N, when it exists
	91	+	// (nil: no #N links). The href is built by the server, never from the text.
	92	+	numbers func(int64) (href string, kind domain.NumberKind, ok bool)
	93	+	}
	94	+
77	95		// renderUntrusted renders Markdown written by an anonymous visitor (an issue
78	96		// approved from the public form). On top of the policy of render, which already
79	97		// drops raw HTML and never loads an image:

@@ -81,19 +99,19 @@ func (m *markdown) renderNote(source []byte, repo, ref, idPrefix string, notes f
81	99		// rel="nofollow noopener noreferrer ugc"; relative links, #fragments and
82	100		// every other scheme lose their link and keep the text;
83	101		// - nothing points into the repository.
84		-	func (m *markdown) renderUntrusted(source []byte, idPrefix string) (template.HTML, error) {
85		-	h, _, err := m.renderPolicy(source, linkPolicy{idPrefix: idPrefix, untrusted: true}, nil)
	102	+	func (m *markdown) renderUntrusted(source []byte, idPrefix string, numbers func(int64) (string, domain.NumberKind, bool)) (template.HTML, error) {
	103	+	h, _, err := m.renderPolicy(source, linkPolicy{idPrefix: idPrefix, untrusted: true}, refResolver{numbers: numbers})
86	104		return h, err
87	105		}
88	106
89		-	func (m *markdown) renderPolicy(source []byte, pol linkPolicy, notes func(int64) bool) (template.HTML, []Heading, error) {
	107	+	func (m *markdown) renderPolicy(source []byte, pol linkPolicy, res refResolver) (template.HTML, []Heading, error) {
90	108		pc := parser.NewContext(parser.WithIDs(&prefixedIDs{prefix: pol.idPrefix, inner: parser.NewContext().IDs()}))
91	109		doc := m.md.Parser().Parse(text.NewReader(source), parser.WithContext(pc))
92	110		pol.source = source
93	111		// Collect eligible text before the policy unwraps rejected links: their
94	112		// labels must not accidentally become references either.
95	113		var refs []*ast.Text
96		-	if notes != nil {
	114	+	if res.notes != nil \|\| res.numbers != nil {
97	115		_ = ast.Walk(doc, func(n ast.Node, entering bool) (ast.WalkStatus, error) {
98	116		if !entering {
99	117		return ast.WalkContinue, nil

@@ -109,7 +127,7 @@ func (m *markdown) renderPolicy(source []byte, pol linkPolicy, notes func(int64)
109	127		}
110	128		pol.apply(doc)
111	129		for _, t := range refs {
112		-	noteReferences(t, source, notes)
	130	+	references(t, source, res)
113	131		}
114	132
115	133		doc.SetAttributeString(markdownBudgetKey, &markdownLexBudget{deadline: time.Now().Add(markdownLexTime)})

@@ -392,42 +410,74 @@ func (altRenderer) RegisterFuncs(r renderer.NodeRendererFuncRegisterer) {
392	410		})
393	411		}
394	412
395		-	var noteReferencePattern = regexp.MustCompile(`(^\|[^0-9A-Za-z_^])\^([1-9][0-9]{0,5})\b`)
	413	+	// referencePattern matches ^N (groups 1-2) and #N (groups 3-4). The preceding
	414	+	// character is not part of a word; #N also rejects & and # so that numeric
	415	+	// entities such as ' stay text.
	416	+	var referencePattern = regexp.MustCompile(`(^\|[^0-9A-Za-z_^])\^([1-9][0-9]{0,5})\b\|(^\|[^0-9A-Za-z_&#])#([1-9][0-9]{0,9})\b`)
396	417
397		-	// noteReferences changes only text segments; code and link labels never enter
398		-	// this function. New fragment links deliberately bypass heading-prefix rewriting.
399		-	func noteReferences(t *ast.Text, source []byte, exists func(int64) bool) {
	418	+	// references changes only text segments; code and link labels never enter
	419	+	// this function. New links deliberately bypass heading-prefix rewriting.
	420	+	func references(t *ast.Text, source []byte, res refResolver) {
400	421		parent := t.Parent()
401	422		if parent == nil {
402	423		return
403	424		}
404	425		value := t.Value(source)
405	426		offset := 0
406		-	for _, match := range noteReferencePattern.FindAllSubmatchIndex(value, -1) {
407		-	id := string(value[match[4]:match[5]])
	427	+	for _, match := range referencePattern.FindAllSubmatchIndex(value, -1) {
	428	+	isNote := match[4] >= 0
	429	+	var from, to int
	430	+	if isNote {
	431	+	from, to = match[4], match[5]
	432	+	} else {
	433	+	from, to = match[8], match[9]
	434	+	}
	435	+	if (isNote && res.notes == nil) \|\| (!isNote && res.numbers == nil) {
	436	+	continue
	437	+	}
	438	+	id := string(value[from:to])
408	439		n, err := strconv.ParseInt(id, 10, 64)
409		-	if err != nil \|\| !exists(n) {
	440	+	if err != nil {
410	441		continue
411	442		}
412		-	start := match[4] - 1
	443	+	start := from - 1
413	444		// Markdown punctuation may split adjacent text into separate AST nodes.
414	445		// Check the original preceding byte as well as the segment-local regex.
415	446		if at := t.Segment.Start + start; at > 0 {
416	447		prev := source[at-1]
417		-	if prev >= '0' && prev <= '9' \|\| prev >= 'A' && prev <= 'Z' \|\| prev >= 'a' && prev <= 'z' \|\| prev == '_' \|\| prev == '^' {
	448	+	if prev >= '0' && prev <= '9' \|\| prev >= 'A' && prev <= 'Z' \|\| prev >= 'a' && prev <= 'z' \|\| prev == '_' {
	449	+	continue
	450	+	}
	451	+	if isNote && prev == '^' \|\| !isNote && (prev == '&' \|\| prev == '#') {
418	452		continue
419	453		}
420	454		}
	455	+	link := ast.NewLink()
	456	+	if isNote {
	457	+	if !res.notes(n) {
	458	+	continue
	459	+	}
	460	+	link.Destination = []byte("#c" + id)
	461	+	link.Title = []byte("note " + id)
	462	+	} else {
	463	+	href, kind, ok := res.numbers(n)
	464	+	if !ok {
	465	+	continue
	466	+	}
	467	+	link.Destination = []byte(href)
	468	+	title := "issue "
	469	+	if kind == domain.NumberMergeRequest {
	470	+	title = "merge request "
	471	+	}
	472	+	link.Title = []byte(title + id)
	473	+	}
421	474		if start > offset {
422	475		parent.InsertBefore(parent, t, ast.NewTextSegment(text.NewSegment(t.Segment.Start+offset, t.Segment.Start+start)))
423	476		}
424		-	link := ast.NewLink()
425		-	link.Destination = []byte("#c" + id)
426		-	link.Title = []byte("note " + id)
427	477		link.SetAttributeString("class", []byte("ref"))
428		-	link.AppendChild(link, ast.NewString(value[start:match[5]]))
	478	+	link.AppendChild(link, ast.NewString(value[start:to]))
429	479		parent.InsertBefore(parent, t, link)
430		-	offset = match[5]
	480	+	offset = to
431	481		}
432	482		if offset == 0 {
433	483		return

 	"strings"
 	"time"
+	"bnema.dev/ermite/internal/domain"
 	"github.com/yuin/goldmark"
 	"github.com/yuin/goldmark/ast"
 	"github.com/yuin/goldmark/extension"
 // #fragment links chosen, so that several documents on one page (the summaries
 // of a run) do not share ids.
 func (m *markdown) renderWithIDs(source []byte, repo, ref, dir, idPrefix string) (template.HTML, []Heading, error) {
-	return m.renderPolicy(source, linkPolicy{repo: repo, ref: ref, dir: dir, idPrefix: idPrefix}, nil)
+	return m.renderPolicy(source, linkPolicy{repo: repo, ref: ref, dir: dir, idPrefix: idPrefix}, refResolver{})
 }
-// renderNote uses the repository Markdown policy, then adds local note links.
+// renderNote uses the repository Markdown policy, then adds local note links
-func (m *markdown) renderNote(source []byte, repo, ref, idPrefix string, notes func(int64) bool) (template.HTML, error) {
+// and links to issues and merge requests.
-	h, _, err := m.renderPolicy(source, linkPolicy{repo: repo, ref: ref, idPrefix: idPrefix}, notes)
+func (m *markdown) renderNote(source []byte, repo, ref, idPrefix string, refs refResolver) (template.HTML, error) {
+	h, _, err := m.renderPolicy(source, linkPolicy{repo: repo, ref: ref, idPrefix: idPrefix}, refs)
 	return h, err
 }
+// renderIssue renders the trusted body of an issue: the policy of render, plus
+// links to issues and merge requests.
+func (m *markdown) renderIssue(source []byte, repo, ref, idPrefix string, numbers func(int64) (string, domain.NumberKind, bool)) (template.HTML, error) {
+	h, _, err := m.renderPolicy(source, linkPolicy{repo: repo, ref: ref, idPrefix: idPrefix}, refResolver{numbers: numbers})
+	return h, err
+}
+// refResolver tells which references of a text are links.
+type refResolver struct {
+	// notes tells whether ^N names a note of the page (nil: no ^N links).
+	notes func(int64) bool
+	// numbers gives the page of the issue or merge request #N, when it exists
+	// (nil: no #N links). The href is built by the server, never from the text.
+	numbers func(int64) (href string, kind domain.NumberKind, ok bool)
+}
 // renderUntrusted renders Markdown written by an anonymous visitor (an issue
 // approved from the public form). On top of the policy of render, which already
 // drops raw HTML and never loads an image:
 //     rel="nofollow noopener noreferrer ugc"; relative links, #fragments and
 //     every other scheme lose their link and keep the text;
 //   - nothing points into the repository.
-func (m *markdown) renderUntrusted(source []byte, idPrefix string) (template.HTML, error) {
+func (m *markdown) renderUntrusted(source []byte, idPrefix string, numbers func(int64) (string, domain.NumberKind, bool)) (template.HTML, error) {
-	h, _, err := m.renderPolicy(source, linkPolicy{idPrefix: idPrefix, untrusted: true}, nil)
+	h, _, err := m.renderPolicy(source, linkPolicy{idPrefix: idPrefix, untrusted: true}, refResolver{numbers: numbers})
 	return h, err
 }
-func (m *markdown) renderPolicy(source []byte, pol linkPolicy, notes func(int64) bool) (template.HTML, []Heading, error) {
+func (m *markdown) renderPolicy(source []byte, pol linkPolicy, res refResolver) (template.HTML, []Heading, error) {
 	pc := parser.NewContext(parser.WithIDs(&prefixedIDs{prefix: pol.idPrefix, inner: parser.NewContext().IDs()}))
 	doc := m.md.Parser().Parse(text.NewReader(source), parser.WithContext(pc))
 	pol.source = source
 	// Collect eligible text before the policy unwraps rejected links: their
 	// labels must not accidentally become references either.
 	var refs []*ast.Text
-	if notes != nil {
+	if res.notes != nil || res.numbers != nil {
 		_ = ast.Walk(doc, func(n ast.Node, entering bool) (ast.WalkStatus, error) {
 			if !entering {
 				return ast.WalkContinue, nil
 	}
 	pol.apply(doc)
 	for _, t := range refs {
-		noteReferences(t, source, notes)
+		references(t, source, res)
 	}
 	doc.SetAttributeString(markdownBudgetKey, &markdownLexBudget{deadline: time.Now().Add(markdownLexTime)})
 	})
 }
-var noteReferencePattern = regexp.MustCompile(`(^|[^0-9A-Za-z_^])\^([1-9][0-9]{0,5})\b`)
+// referencePattern matches ^N (groups 1-2) and #N (groups 3-4). The preceding
+// character is not part of a word; #N also rejects & and # so that numeric
+// entities such as &#39; stay text.
+var referencePattern = regexp.MustCompile(`(^|[^0-9A-Za-z_^])\^([1-9][0-9]{0,5})\b|(^|[^0-9A-Za-z_&#])#([1-9][0-9]{0,9})\b`)
-// noteReferences changes only text segments; code and link labels never enter
+// references changes only text segments; code and link labels never enter
-// this function. New fragment links deliberately bypass heading-prefix rewriting.
+// this function. New links deliberately bypass heading-prefix rewriting.
-func noteReferences(t *ast.Text, source []byte, exists func(int64) bool) {
+func references(t *ast.Text, source []byte, res refResolver) {
 	parent := t.Parent()
 	if parent == nil {
 		return
 	}
 	value := t.Value(source)
 	offset := 0
-	for _, match := range noteReferencePattern.FindAllSubmatchIndex(value, -1) {
+	for _, match := range referencePattern.FindAllSubmatchIndex(value, -1) {
-		id := string(value[match[4]:match[5]])
+		isNote := match[4] >= 0
+		var from, to int
+		if isNote {
+			from, to = match[4], match[5]
+		} else {
+			from, to = match[8], match[9]
+		}
+		if (isNote && res.notes == nil) || (!isNote && res.numbers == nil) {
+			continue
+		}
+		id := string(value[from:to])
 		n, err := strconv.ParseInt(id, 10, 64)
-		if err != nil || !exists(n) {
+		if err != nil {
 			continue
 		}
-		start := match[4] - 1
+		start := from - 1
 		// Markdown punctuation may split adjacent text into separate AST nodes.
 		// Check the original preceding byte as well as the segment-local regex.
 		if at := t.Segment.Start + start; at > 0 {
 			prev := source[at-1]
-			if prev >= '0' && prev <= '9' || prev >= 'A' && prev <= 'Z' || prev >= 'a' && prev <= 'z' || prev == '_' || prev == '^' {
+			if prev >= '0' && prev <= '9' || prev >= 'A' && prev <= 'Z' || prev >= 'a' && prev <= 'z' || prev == '_' {
+				continue
+			}
+			if isNote && prev == '^' || !isNote && (prev == '&' || prev == '#') {
 				continue
 			}
 		}
+		link := ast.NewLink()
+		if isNote {
+			if !res.notes(n) {
+				continue
+			}
+			link.Destination = []byte("#c" + id)
+			link.Title = []byte("note " + id)
+		} else {
+			href, kind, ok := res.numbers(n)
+			if !ok {
+				continue
+			}
+			link.Destination = []byte(href)
+			title := "issue "
+			if kind == domain.NumberMergeRequest {
+				title = "merge request "
+			}
+			link.Title = []byte(title + id)
+		}
 		if start > offset {
 			parent.InsertBefore(parent, t, ast.NewTextSegment(text.NewSegment(t.Segment.Start+offset, t.Segment.Start+start)))
 		}
-		link := ast.NewLink()
-		link.Destination = []byte("#c" + id)
-		link.Title = []byte("note " + id)
 		link.SetAttributeString("class", []byte("ref"))
-		link.AppendChild(link, ast.NewString(value[start:match[5]]))
+		link.AppendChild(link, ast.NewString(value[start:to]))
 		parent.InsertBefore(parent, t, link)
-		offset = match[5]
+		offset = to
 	}
 	if offset == 0 {
 		return

M internal/adapters/web/markdown_test.go +91 -4


@@ -6,7 +6,10 @@ import (
6	6		"strings"
7	7		"testing"
8	8
	9	+	"bnema.dev/ermite/internal/domain"
	10	+	"bnema.dev/ermite/internal/ports/mocks"
9	11		"github.com/stretchr/testify/assert"
	12	+	"github.com/stretchr/testify/mock"
10	13		"github.com/stretchr/testify/require"
11	14		)
12	15

@@ -139,7 +142,7 @@ func TestMarkdownGFM(t *testing.T) {
139	142
140	143		func renderUntrustedMD(t *testing.T, src string) string {
141	144		t.Helper()
142		-	h, err := newMarkdown().renderUntrusted([]byte(src), "issue-desc-")
	145	+	h, err := newMarkdown().renderUntrusted([]byte(src), "issue-desc-", nil)
143	146		require.NoError(t, err)
144	147		return string(h)
145	148		}

@@ -218,14 +221,14 @@ func TestNoteMarkdown(t *testing.T) {
218	221		for _, tt := range tests {
219	222		t.Run(tt.source, func(t *testing.T) {
220	223		t.Parallel()
221		-	h, err := newMarkdown().renderNote([]byte(tt.source), "demo", "main", "c1-", func(n int64) bool { return n == 2 })
	224	+	h, err := newMarkdown().renderNote([]byte(tt.source), "demo", "main", "c1-", refResolver{notes: func(n int64) bool { return n == 2 }})
222	225		require.NoError(t, err)
223	226		assert.Equal(t, tt.links, strings.Count(string(h), `href="#c2"`), string(h))
224	227		assert.NotContains(t, string(h), `href="#c99"`)
225	228		assert.NotContains(t, string(h), "javascript:")
226	229		})
227	230		}
228		-	h, err := newMarkdown().renderNote([]byte("# Heading\n\n<script>alert(1)</script>\n\nbold ^2"), "demo", "main", "c1-", func(n int64) bool { return n == 2 })
	231	+	h, err := newMarkdown().renderNote([]byte("# Heading\n\n<script>alert(1)</script>\n\nbold ^2"), "demo", "main", "c1-", refResolver{notes: func(n int64) bool { return n == 2 }})
229	232		require.NoError(t, err)
230	233		assert.Contains(t, string(h), `id="c1-heading"`)
231	234		assert.Contains(t, string(h), "<strong>bold</strong>")

@@ -233,6 +236,90 @@ func TestNoteMarkdown(t *testing.T) {
233	236		assert.Contains(t, string(h), `title="note 2"`)
234	237		}
235	238
	239	+	func TestNumberReferences(t *testing.T) {
	240	+	t.Parallel()
	241	+	numbers := func(n int64) (string, domain.NumberKind, bool) {
	242	+	switch n {
	243	+	case 3:
	244	+	return "/demo/issues/3", domain.NumberIssue, true
	245	+	case 4:
	246	+	return "/demo/merge-requests/4", domain.NumberMergeRequest, true
	247	+	}
	248	+	return "", domain.NumberNone, false
	249	+	}
	250	+	tests := []struct {
	251	+	source string
	252	+	want []string
	253	+	not []string
	254	+	}{
	255	+	{"fix #3 and #4, not #9", []string{`<a href="/demo/issues/3" title="issue 3" class="ref">#3</a>`, `title="merge request 4"`}, []string{"/issues/9", "#9</a>"}},
	256	+	{"abc#3 _#3 ##3 1#3", nil, []string{"<a "}},
	257	+	{"' ", nil, []string{"<a "}},
	258	+	{"`#3`\n\n```\n#3\n```", nil, []string{"<a "}},
	259	+	{"[#3](https://example.org)", []string{`href="https://example.org"`}, []string{"/demo/issues/3"}},
	260	+	{"#3\n#3", []string{`href="/demo/issues/3"`}, nil},
	261	+	{"#03 #12345678901", nil, []string{"<a "}},
	262	+	}
	263	+	for _, tt := range tests {
	264	+	t.Run(tt.source, func(t *testing.T) {
	265	+	t.Parallel()
	266	+	h, err := newMarkdown().renderIssue([]byte(tt.source), "demo", "main", "i-", numbers)
	267	+	require.NoError(t, err)
	268	+	for _, w := range tt.want {
	269	+	assert.Contains(t, string(h), w)
	270	+	}
	271	+	for _, w := range tt.not {
	272	+	assert.NotContains(t, string(h), w)
	273	+	}
	274	+	u, err := newMarkdown().renderUntrusted([]byte(tt.source), "i-", numbers)
	275	+	require.NoError(t, err)
	276	+	assert.Equal(t, strings.Count(string(h), `class="ref"`), strings.Count(string(u), `class="ref"`))
	277	+	})
	278	+	}
	279	+	// Without a resolver nothing links.
	280	+	h, err := newMarkdown().renderUntrusted([]byte("#3"), "i-", nil)
	281	+	require.NoError(t, err)
	282	+	assert.NotContains(t, string(h), "<a ")
	283	+	}
	284	+
	285	+	func TestNumberAndNoteReferencesTogether(t *testing.T) {
	286	+	t.Parallel()
	287	+	h, err := newMarkdown().renderNote([]byte("see ^2 and #3."), "demo", "main", "c1-", refResolver{
	288	+	notes: func(n int64) bool { return n == 2 },
	289	+	numbers: func(n int64) (string, domain.NumberKind, bool) { return "/demo/issues/3", domain.NumberIssue, n == 3 },
	290	+	})
	291	+	require.NoError(t, err)
	292	+	assert.Contains(t, string(h), `href="#c2"`)
	293	+	assert.Contains(t, string(h), `href="/demo/issues/3"`)
	294	+	assert.Contains(t, string(h), "and ")
	295	+	}
	296	+
	297	+	func TestNumberResolverCapsLookups(t *testing.T) {
	298	+	t.Parallel()
	299	+	nums := mocks.NewIssueNumberResolver(t)
	300	+	nums.EXPECT().Kind(mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(domain.NumberIssue, nil).Times(maxNumberLookups)
	301	+	srv := &Server{cfg: Config{IssueNumbers: nums}}
	302	+	resolve := srv.numberResolver(t.Context(), "demo")
	303	+	require.NotNil(t, resolve)
	304	+	for n := int64(1); n <= maxNumberLookups+10; n++ {
	305	+	_, _, ok := resolve(n)
	306	+	assert.Equal(t, n <= maxNumberLookups, ok, n)
	307	+	}
	308	+	_, _, ok := resolve(1) // memoized
	309	+	assert.True(t, ok)
	310	+	}
	311	+
	312	+	func TestNumberReferenceTitleFromKindNotHref(t *testing.T) {
	313	+	t.Parallel()
	314	+	numbers := func(n int64) (string, domain.NumberKind, bool) {
	315	+	return "/owner/merge-requests/issues/3", domain.NumberIssue, true
	316	+	}
	317	+	h, err := newMarkdown().renderIssue([]byte("see #3"), "merge-requests", "main", "i-", numbers)
	318	+	require.NoError(t, err)
	319	+	assert.Contains(t, string(h), `title="issue 3"`)
	320	+	assert.NotContains(t, string(h), "merge request 3")
	321	+	}
	322	+
236	323		func TestMarkdownFencedHighlight(t *testing.T) {
237	324		tests := []struct {
238	325		name, info, code string

@@ -252,7 +339,7 @@ func TestMarkdownFencedHighlight(t *testing.T) {
252	339		for _, untrusted := range []bool{false, true} {
253	340		var h string
254	341		if untrusted {
255		-	out, err := newMarkdown().renderUntrusted([]byte(src), "test-")
	342	+	out, err := newMarkdown().renderUntrusted([]byte(src), "test-", nil)
256	343		require.NoError(t, err)
257	344		h = string(out)
258	345		} else {


@@ -6,7 +6,10 @@ import (
6		"strings"	6		"strings"
7		"testing"	7		"testing"
8			8
			9	+	"bnema.dev/ermite/internal/domain"
			10	+	"bnema.dev/ermite/internal/ports/mocks"
9		"github.com/stretchr/testify/assert"	11		"github.com/stretchr/testify/assert"
			12	+	"github.com/stretchr/testify/mock"
10		"github.com/stretchr/testify/require"	13		"github.com/stretchr/testify/require"
11		)	14		)
12			15

@@ -139,7 +142,7 @@ func TestMarkdownGFM(t *testing.T) {
139			142
140		func renderUntrustedMD(t *testing.T, src string) string {	143		func renderUntrustedMD(t *testing.T, src string) string {
141		t.Helper()	144		t.Helper()
142	-	h, err := newMarkdown().renderUntrusted([]byte(src), "issue-desc-")	145	+	h, err := newMarkdown().renderUntrusted([]byte(src), "issue-desc-", nil)
143		require.NoError(t, err)	146		require.NoError(t, err)
144		return string(h)	147		return string(h)
145		}	148		}

@@ -218,14 +221,14 @@ func TestNoteMarkdown(t *testing.T) {
218		for _, tt := range tests {	221		for _, tt := range tests {
219		t.Run(tt.source, func(t *testing.T) {	222		t.Run(tt.source, func(t *testing.T) {
220		t.Parallel()	223		t.Parallel()
221	-	h, err := newMarkdown().renderNote([]byte(tt.source), "demo", "main", "c1-", func(n int64) bool { return n == 2 })	224	+	h, err := newMarkdown().renderNote([]byte(tt.source), "demo", "main", "c1-", refResolver{notes: func(n int64) bool { return n == 2 }})
222		require.NoError(t, err)	225		require.NoError(t, err)
223		assert.Equal(t, tt.links, strings.Count(string(h), `href="#c2"`), string(h))	226		assert.Equal(t, tt.links, strings.Count(string(h), `href="#c2"`), string(h))
224		assert.NotContains(t, string(h), `href="#c99"`)	227		assert.NotContains(t, string(h), `href="#c99"`)
225		assert.NotContains(t, string(h), "javascript:")	228		assert.NotContains(t, string(h), "javascript:")
226		})	229		})
227		}	230		}
228	-	h, err := newMarkdown().renderNote([]byte("# Heading\n\n<script>alert(1)</script>\n\nbold ^2"), "demo", "main", "c1-", func(n int64) bool { return n == 2 })	231	+	h, err := newMarkdown().renderNote([]byte("# Heading\n\n<script>alert(1)</script>\n\nbold ^2"), "demo", "main", "c1-", refResolver{notes: func(n int64) bool { return n == 2 }})
229		require.NoError(t, err)	232		require.NoError(t, err)
230		assert.Contains(t, string(h), `id="c1-heading"`)	233		assert.Contains(t, string(h), `id="c1-heading"`)
231		assert.Contains(t, string(h), "<strong>bold</strong>")	234		assert.Contains(t, string(h), "<strong>bold</strong>")

@@ -233,6 +236,90 @@ func TestNoteMarkdown(t *testing.T) {
233		assert.Contains(t, string(h), `title="note 2"`)	236		assert.Contains(t, string(h), `title="note 2"`)
234		}	237		}
235			238
			239	+	func TestNumberReferences(t *testing.T) {
			240	+	t.Parallel()
			241	+	numbers := func(n int64) (string, domain.NumberKind, bool) {
			242	+	switch n {
			243	+	case 3:
			244	+	return "/demo/issues/3", domain.NumberIssue, true
			245	+	case 4:
			246	+	return "/demo/merge-requests/4", domain.NumberMergeRequest, true
			247	+	}
			248	+	return "", domain.NumberNone, false
			249	+	}
			250	+	tests := []struct {
			251	+	source string
			252	+	want []string
			253	+	not []string
			254	+	}{
			255	+	{"fix #3 and #4, not #9", []string{`<a href="/demo/issues/3" title="issue 3" class="ref">#3</a>`, `title="merge request 4"`}, []string{"/issues/9", "#9</a>"}},
			256	+	{"abc#3 _#3 ##3 1#3", nil, []string{"<a "}},
			257	+	{"' ", nil, []string{"<a "}},
			258	+	{"`#3`\n\n```\n#3\n```", nil, []string{"<a "}},
			259	+	{"[#3](https://example.org)", []string{`href="https://example.org"`}, []string{"/demo/issues/3"}},
			260	+	{"#3\n#3", []string{`href="/demo/issues/3"`}, nil},
			261	+	{"#03 #12345678901", nil, []string{"<a "}},
			262	+	}
			263	+	for _, tt := range tests {
			264	+	t.Run(tt.source, func(t *testing.T) {
			265	+	t.Parallel()
			266	+	h, err := newMarkdown().renderIssue([]byte(tt.source), "demo", "main", "i-", numbers)
			267	+	require.NoError(t, err)
			268	+	for _, w := range tt.want {
			269	+	assert.Contains(t, string(h), w)
			270	+	}
			271	+	for _, w := range tt.not {
			272	+	assert.NotContains(t, string(h), w)
			273	+	}
			274	+	u, err := newMarkdown().renderUntrusted([]byte(tt.source), "i-", numbers)
			275	+	require.NoError(t, err)
			276	+	assert.Equal(t, strings.Count(string(h), `class="ref"`), strings.Count(string(u), `class="ref"`))
			277	+	})
			278	+	}
			279	+	// Without a resolver nothing links.
			280	+	h, err := newMarkdown().renderUntrusted([]byte("#3"), "i-", nil)
			281	+	require.NoError(t, err)
			282	+	assert.NotContains(t, string(h), "<a ")
			283	+	}
			284	+
			285	+	func TestNumberAndNoteReferencesTogether(t *testing.T) {
			286	+	t.Parallel()
			287	+	h, err := newMarkdown().renderNote([]byte("see ^2 and #3."), "demo", "main", "c1-", refResolver{
			288	+	notes: func(n int64) bool { return n == 2 },
			289	+	numbers: func(n int64) (string, domain.NumberKind, bool) { return "/demo/issues/3", domain.NumberIssue, n == 3 },
			290	+	})
			291	+	require.NoError(t, err)
			292	+	assert.Contains(t, string(h), `href="#c2"`)
			293	+	assert.Contains(t, string(h), `href="/demo/issues/3"`)
			294	+	assert.Contains(t, string(h), "and ")
			295	+	}
			296	+
			297	+	func TestNumberResolverCapsLookups(t *testing.T) {
			298	+	t.Parallel()
			299	+	nums := mocks.NewIssueNumberResolver(t)
			300	+	nums.EXPECT().Kind(mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(domain.NumberIssue, nil).Times(maxNumberLookups)
			301	+	srv := &Server{cfg: Config{IssueNumbers: nums}}
			302	+	resolve := srv.numberResolver(t.Context(), "demo")
			303	+	require.NotNil(t, resolve)
			304	+	for n := int64(1); n <= maxNumberLookups+10; n++ {
			305	+	_, _, ok := resolve(n)
			306	+	assert.Equal(t, n <= maxNumberLookups, ok, n)
			307	+	}
			308	+	_, _, ok := resolve(1) // memoized
			309	+	assert.True(t, ok)
			310	+	}
			311	+
			312	+	func TestNumberReferenceTitleFromKindNotHref(t *testing.T) {
			313	+	t.Parallel()
			314	+	numbers := func(n int64) (string, domain.NumberKind, bool) {
			315	+	return "/owner/merge-requests/issues/3", domain.NumberIssue, true
			316	+	}
			317	+	h, err := newMarkdown().renderIssue([]byte("see #3"), "merge-requests", "main", "i-", numbers)
			318	+	require.NoError(t, err)
			319	+	assert.Contains(t, string(h), `title="issue 3"`)
			320	+	assert.NotContains(t, string(h), "merge request 3")
			321	+	}
			322	+
236		func TestMarkdownFencedHighlight(t *testing.T) {	323		func TestMarkdownFencedHighlight(t *testing.T) {
237		tests := []struct {	324		tests := []struct {
238		name, info, code string	325		name, info, code string

@@ -252,7 +339,7 @@ func TestMarkdownFencedHighlight(t *testing.T) {
252		for _, untrusted := range []bool{false, true} {	339		for _, untrusted := range []bool{false, true} {
253		var h string	340		var h string
254		if untrusted {	341		if untrusted {
255	-	out, err := newMarkdown().renderUntrusted([]byte(src), "test-")	342	+	out, err := newMarkdown().renderUntrusted([]byte(src), "test-", nil)
256		require.NoError(t, err)	343		require.NoError(t, err)
257		h = string(out)	344		h = string(out)
258		} else {	345		} else {

M internal/adapters/web/mr.go +4 -4


@@ -616,7 +616,7 @@ func (s Server) mrPage(ctx context.Context, r http.Request, since bool) (templ
616	616		if canWrite {
617	617		on = parseOn(r.URL.Query().Get("on"))
618	618		}
619		-	s.placeComments(&p, d.name(), n, res.Comments, head, !since, canWrite, on)
	619	+	s.placeComments(ctx, &p, d.name(), n, res.Comments, head, !since, canWrite, on)
620	620		lines, invisible := diffLines(p.Files)
621	621		p.Invisible = invisible
622	622		p.DiffView = newDiffView(r, lines, withFrom(self+"?view=unified", from), withFrom(self+"?view=split", from))

@@ -680,7 +680,7 @@ func (s Server) mrFacts(ctx context.Context, r http.Request, d repoData, p M
680	680		// Relative links point into the source branch as it is now (its head
681	681		// commit); the heading ids carry their own prefix, apart from the
682	682		// ids of the diff.
683		-	h, err := s.md.renderNote([]byte(desc), d.name(), head, "mr-desc-", noteIDs(res.Comments))
	683	+	h, err := s.md.renderNote([]byte(desc), d.name(), head, "mr-desc-", refResolver{notes: noteIDs(res.Comments), numbers: s.numberResolver(ctx, d.name())})
684	684		if err != nil {
685	685		return err
686	686		}

@@ -905,7 +905,7 @@ func parseOn(s string) *lineRef {
905	905		// as links to the form of their line; on designates the line whose form shows.
906	906		//
907	907		//hexcheck:ignore suspicious-business-logic-in-adapter places comments under the lines of the diff shown; display only
908		-	func (s Server) placeComments(p MRPage, repo string, n int64, comments []domain.Comment, head string, inline, canWrite bool, on *lineRef) {
	908	+	func (s Server) placeComments(ctx context.Context, p MRPage, repo string, n int64, comments []domain.Comment, head string, inline, canWrite bool, on *lineRef) {
909	909		now := s.cfg.Now()
910	910		self := mrHref(repo, n)
911	911		resolveAction := func(id string) string { return mrHref(repo, n, "comments", id, "resolve") }

@@ -953,7 +953,7 @@ func (s Server) placeComments(p MRPage, repo string, n int64, comments []domai
953	953		return index[lineKey{path, side, line}]
954	954		}
955	955
956		-	exists := noteIDs(comments)
	956	+	exists := refResolver{notes: noteIDs(comments), numbers: s.numberResolver(ctx, repo)}
957	957		children := map[int64][]domain.Comment{}
958	958		for _, c := range comments {
959	959		if c.ReplyTo != 0 && !c.Deleted {


@@ -616,7 +616,7 @@ func (s Server) mrPage(ctx context.Context, r http.Request, since bool) (templ
616		if canWrite {	616		if canWrite {
617		on = parseOn(r.URL.Query().Get("on"))	617		on = parseOn(r.URL.Query().Get("on"))
618		}	618		}
619	-	s.placeComments(&p, d.name(), n, res.Comments, head, !since, canWrite, on)	619	+	s.placeComments(ctx, &p, d.name(), n, res.Comments, head, !since, canWrite, on)
620		lines, invisible := diffLines(p.Files)	620		lines, invisible := diffLines(p.Files)
621		p.Invisible = invisible	621		p.Invisible = invisible
622		p.DiffView = newDiffView(r, lines, withFrom(self+"?view=unified", from), withFrom(self+"?view=split", from))	622		p.DiffView = newDiffView(r, lines, withFrom(self+"?view=unified", from), withFrom(self+"?view=split", from))

@@ -680,7 +680,7 @@ func (s Server) mrFacts(ctx context.Context, r http.Request, d repoData, p M
680		// Relative links point into the source branch as it is now (its head	680		// Relative links point into the source branch as it is now (its head
681		// commit); the heading ids carry their own prefix, apart from the	681		// commit); the heading ids carry their own prefix, apart from the
682		// ids of the diff.	682		// ids of the diff.
683	-	h, err := s.md.renderNote([]byte(desc), d.name(), head, "mr-desc-", noteIDs(res.Comments))	683	+	h, err := s.md.renderNote([]byte(desc), d.name(), head, "mr-desc-", refResolver{notes: noteIDs(res.Comments), numbers: s.numberResolver(ctx, d.name())})
684		if err != nil {	684		if err != nil {
685		return err	685		return err
686		}	686		}

@@ -905,7 +905,7 @@ func parseOn(s string) *lineRef {
905		// as links to the form of their line; on designates the line whose form shows.	905		// as links to the form of their line; on designates the line whose form shows.
906		//	906		//
907		//hexcheck:ignore suspicious-business-logic-in-adapter places comments under the lines of the diff shown; display only	907		//hexcheck:ignore suspicious-business-logic-in-adapter places comments under the lines of the diff shown; display only
908	-	func (s Server) placeComments(p MRPage, repo string, n int64, comments []domain.Comment, head string, inline, canWrite bool, on *lineRef) {	908	+	func (s Server) placeComments(ctx context.Context, p MRPage, repo string, n int64, comments []domain.Comment, head string, inline, canWrite bool, on *lineRef) {
909		now := s.cfg.Now()	909		now := s.cfg.Now()
910		self := mrHref(repo, n)	910		self := mrHref(repo, n)
911		resolveAction := func(id string) string { return mrHref(repo, n, "comments", id, "resolve") }	911		resolveAction := func(id string) string { return mrHref(repo, n, "comments", id, "resolve") }

@@ -953,7 +953,7 @@ func (s Server) placeComments(p MRPage, repo string, n int64, comments []domai
953		return index[lineKey{path, side, line}]	953		return index[lineKey{path, side, line}]
954		}	954		}
955			955
956	-	exists := noteIDs(comments)	956	+	exists := refResolver{notes: noteIDs(comments), numbers: s.numberResolver(ctx, repo)}
957		children := map[int64][]domain.Comment{}	957		children := map[int64][]domain.Comment{}
958		for _, c := range comments {	958		for _, c := range comments {
959		if c.ReplyTo != 0 && !c.Deleted {	959		if c.ReplyTo != 0 && !c.Deleted {

M internal/adapters/web/mr_files.go +1 -1


@@ -227,7 +227,7 @@ func (s Server) mrFiles(ctx context.Context, r http.Request) (templ.Component,
227	227		} else {
228	228		collapseFiles(p.Files, res.Diff.Files, links)
229	229		}
230		-	s.placeComments(&p, d.name(), n, res.Comments, m.HeadID.String(), !since, canWrite, nil)
	230	+	s.placeComments(ctx, &p, d.name(), n, res.Comments, m.HeadID.String(), !since, canWrite, nil)
231	231		window := p.Files[from:min(from+mrWindow, len(p.Files))]
232	232		if one {
233	233		window = p.Files[from : from+1]


@@ -227,7 +227,7 @@ func (s Server) mrFiles(ctx context.Context, r http.Request) (templ.Component,
227		} else {	227		} else {
228		collapseFiles(p.Files, res.Diff.Files, links)	228		collapseFiles(p.Files, res.Diff.Files, links)
229		}	229		}
230	-	s.placeComments(&p, d.name(), n, res.Comments, m.HeadID.String(), !since, canWrite, nil)	230	+	s.placeComments(ctx, &p, d.name(), n, res.Comments, m.HeadID.String(), !since, canWrite, nil)
231		window := p.Files[from:min(from+mrWindow, len(p.Files))]	231		window := p.Files[from:min(from+mrWindow, len(p.Files))]
232		if one {	232		if one {
233		window = p.Files[from : from+1]	233		window = p.Files[from : from+1]

M internal/adapters/web/mr_notes_test.go +3 -3


@@ -43,7 +43,7 @@ func TestNoteThreads(t *testing.T) {
43	43		{ID: 6, Author: "alice", Text: text, Verdict: domain.VerdictApprove, Resolved: true},
44	44		}
45	45		p := MRPage{NoteAuthor: "alice"}
46		-	s.placeComments(&p, "demo", 1, comments, "", true, true, nil)
	46	+	s.placeComments(t.Context(), &p, "demo", 1, comments, "", true, true, nil)
47	47		require.Len(t, p.General, 3)
48	48		assert.Equal(t, 4, p.NComments)
49	49		assert.Equal(t, 1, p.NUnresolved)

@@ -117,7 +117,7 @@ func TestDeletedNoteRendering(t *testing.T) {
117	117		require.NoError(t, err)
118	118		s := &Server{cfg: Config{Now: time.Now}, md: newMarkdown()}
119	119		p := MRPage{}
120		-	s.placeComments(&p, "demo", 1, []domain.Comment{
	120	+	s.placeComments(t.Context(), &p, "demo", 1, []domain.Comment{
121	121		{ID: 1, Author: "reviewer", Deleted: true, Verdict: domain.VerdictApprove},
122	122		{ID: 2, Deleted: true},
123	123		{ID: 3, ReplyTo: 2, Deleted: true},

@@ -147,7 +147,7 @@ func TestInlineNoteHeadingIDs(t *testing.T) {
147	147		require.NoError(t, err)
148	148		s := &Server{cfg: Config{Now: time.Now}, md: newMarkdown()}
149	149		p := MRPage{Files: []DiffFile{{Key: "a", ID: "f1", Hunks: []DiffHunk{{Lines: []DiffLine{{Kind: "add", newN: 1}}}}}}}
150		-	s.placeComments(&p, "demo", 1, []domain.Comment{{ID: 12, Path: "a", Side: domain.SideNew, Line: 1, Text: text}}, "", true, true, nil)
	150	+	s.placeComments(t.Context(), &p, "demo", 1, []domain.Comment{{ID: 12, Path: "a", Side: domain.SideNew, Line: 1, Text: text}}, "", true, true, nil)
151	151		notes := p.Files[0].Hunks[0].Lines[0].Notes
152	152		require.Len(t, notes, 1)
153	153		var b bytes.Buffer


@@ -43,7 +43,7 @@ func TestNoteThreads(t *testing.T) {
43		{ID: 6, Author: "alice", Text: text, Verdict: domain.VerdictApprove, Resolved: true},	43		{ID: 6, Author: "alice", Text: text, Verdict: domain.VerdictApprove, Resolved: true},
44		}	44		}
45		p := MRPage{NoteAuthor: "alice"}	45		p := MRPage{NoteAuthor: "alice"}
46	-	s.placeComments(&p, "demo", 1, comments, "", true, true, nil)	46	+	s.placeComments(t.Context(), &p, "demo", 1, comments, "", true, true, nil)
47		require.Len(t, p.General, 3)	47		require.Len(t, p.General, 3)
48		assert.Equal(t, 4, p.NComments)	48		assert.Equal(t, 4, p.NComments)
49		assert.Equal(t, 1, p.NUnresolved)	49		assert.Equal(t, 1, p.NUnresolved)

@@ -117,7 +117,7 @@ func TestDeletedNoteRendering(t *testing.T) {
117		require.NoError(t, err)	117		require.NoError(t, err)
118		s := &Server{cfg: Config{Now: time.Now}, md: newMarkdown()}	118		s := &Server{cfg: Config{Now: time.Now}, md: newMarkdown()}
119		p := MRPage{}	119		p := MRPage{}
120	-	s.placeComments(&p, "demo", 1, []domain.Comment{	120	+	s.placeComments(t.Context(), &p, "demo", 1, []domain.Comment{
121		{ID: 1, Author: "reviewer", Deleted: true, Verdict: domain.VerdictApprove},	121		{ID: 1, Author: "reviewer", Deleted: true, Verdict: domain.VerdictApprove},
122		{ID: 2, Deleted: true},	122		{ID: 2, Deleted: true},
123		{ID: 3, ReplyTo: 2, Deleted: true},	123		{ID: 3, ReplyTo: 2, Deleted: true},

@@ -147,7 +147,7 @@ func TestInlineNoteHeadingIDs(t *testing.T) {
147		require.NoError(t, err)	147		require.NoError(t, err)
148		s := &Server{cfg: Config{Now: time.Now}, md: newMarkdown()}	148		s := &Server{cfg: Config{Now: time.Now}, md: newMarkdown()}
149		p := MRPage{Files: []DiffFile{{Key: "a", ID: "f1", Hunks: []DiffHunk{{Lines: []DiffLine{{Kind: "add", newN: 1}}}}}}}	149		p := MRPage{Files: []DiffFile{{Key: "a", ID: "f1", Hunks: []DiffHunk{{Lines: []DiffLine{{Kind: "add", newN: 1}}}}}}}
150	-	s.placeComments(&p, "demo", 1, []domain.Comment{{ID: 12, Path: "a", Side: domain.SideNew, Line: 1, Text: text}}, "", true, true, nil)	150	+	s.placeComments(t.Context(), &p, "demo", 1, []domain.Comment{{ID: 12, Path: "a", Side: domain.SideNew, Line: 1, Text: text}}, "", true, true, nil)
151		notes := p.Files[0].Hunks[0].Lines[0].Notes	151		notes := p.Files[0].Hunks[0].Lines[0].Notes
152		require.Len(t, notes, 1)	152		require.Len(t, notes, 1)
153		var b bytes.Buffer	153		var b bytes.Buffer

M internal/app/api_test.go +1 -1


@@ -196,7 +196,7 @@ func TestAC2ReadAccess(t *testing.T) {
196	196		for _, who := range allPrincipals {
197	197		resp, err := r.who[who].server.GetVersion(ctx, connect.NewRequest(&pb.GetVersionRequest{}))
198	198		require.NoError(t, err, who)
199		-	assert.ElementsMatch(t, []string{"repo.update", "events.resume", "merge_requests", "merge_requests.delete_branch", "issues", "merge_requests.mergeability", "signing_key", "session", "git.list_paths", "token.branch_prefixes", "ci.runs", "ci.runs.filters", "ci.runners", "ci.actions", "ci.annotations", "ci.summaries", "ci.concurrency", "ci.dispatch", "ci.workflows", "ci.cache", "ci.secrets", "ci.artifacts", "commit_signatures", "mirror"}, resp.Msg.GetFeatures(), who)
	199	+	assert.ElementsMatch(t, []string{"repo.update", "events.resume", "merge_requests", "merge_requests.delete_branch", "issues", "issues.links", "merge_requests.mergeability", "signing_key", "session", "git.list_paths", "token.branch_prefixes", "ci.runs", "ci.runs.filters", "ci.runners", "ci.actions", "ci.annotations", "ci.summaries", "ci.concurrency", "ci.dispatch", "ci.workflows", "ci.cache", "ci.secrets", "ci.artifacts", "commit_signatures", "mirror"}, resp.Msg.GetFeatures(), who)
200	200		assert.NotEmpty(t, resp.Msg.GetVersion())
201	201		}
202	202		})


@@ -196,7 +196,7 @@ func TestAC2ReadAccess(t *testing.T) {
196		for _, who := range allPrincipals {	196		for _, who := range allPrincipals {
197		resp, err := r.who[who].server.GetVersion(ctx, connect.NewRequest(&pb.GetVersionRequest{}))	197		resp, err := r.who[who].server.GetVersion(ctx, connect.NewRequest(&pb.GetVersionRequest{}))
198		require.NoError(t, err, who)	198		require.NoError(t, err, who)
199	-	assert.ElementsMatch(t, []string{"repo.update", "events.resume", "merge_requests", "merge_requests.delete_branch", "issues", "merge_requests.mergeability", "signing_key", "session", "git.list_paths", "token.branch_prefixes", "ci.runs", "ci.runs.filters", "ci.runners", "ci.actions", "ci.annotations", "ci.summaries", "ci.concurrency", "ci.dispatch", "ci.workflows", "ci.cache", "ci.secrets", "ci.artifacts", "commit_signatures", "mirror"}, resp.Msg.GetFeatures(), who)	199	+	assert.ElementsMatch(t, []string{"repo.update", "events.resume", "merge_requests", "merge_requests.delete_branch", "issues", "issues.links", "merge_requests.mergeability", "signing_key", "session", "git.list_paths", "token.branch_prefixes", "ci.runs", "ci.runs.filters", "ci.runners", "ci.actions", "ci.annotations", "ci.summaries", "ci.concurrency", "ci.dispatch", "ci.workflows", "ci.cache", "ci.secrets", "ci.artifacts", "commit_signatures", "mirror"}, resp.Msg.GetFeatures(), who)
200		assert.NotEmpty(t, resp.Msg.GetVersion())	200		assert.NotEmpty(t, resp.Msg.GetVersion())
201		}	201		}
202		})	202		})

M internal/app/cli_e2e_test.go +1 -1


@@ -350,7 +350,7 @@ func TestAC6CLIEndToEnd(t *testing.T) {
350	350		ver := decode[versionOut](t, res.stdout)
351	351		assert.Equal(t, c.url, ver.Server.URL)
352	352		assert.NotEmpty(t, ver.Server.Version)
353		-	assert.ElementsMatch(t, []string{"repo.update", "events.resume", "merge_requests", "merge_requests.delete_branch", "issues", "merge_requests.mergeability", "signing_key", "session", "git.list_paths", "token.branch_prefixes", "ci.runs", "ci.runs.filters", "ci.runners", "ci.actions", "ci.annotations", "ci.summaries", "ci.concurrency", "ci.dispatch", "ci.workflows", "ci.cache", "ci.secrets", "ci.artifacts", "commit_signatures", "mirror"}, ver.Server.Features)
	353	+	assert.ElementsMatch(t, []string{"repo.update", "events.resume", "merge_requests", "merge_requests.delete_branch", "issues", "issues.links", "merge_requests.mergeability", "signing_key", "session", "git.list_paths", "token.branch_prefixes", "ci.runs", "ci.runs.filters", "ci.runners", "ci.actions", "ci.annotations", "ci.summaries", "ci.concurrency", "ci.dispatch", "ci.workflows", "ci.cache", "ci.secrets", "ci.artifacts", "commit_signatures", "mirror"}, ver.Server.Features)
354	354		assert.Equal(t, []string{"passkeys"}, ver.Server.MissingFeatures)
355	355		stdout, stderr, code = c.bin(t, secret, "version")
356	356		require.Equal(t, 0, code, stderr)


@@ -350,7 +350,7 @@ func TestAC6CLIEndToEnd(t *testing.T) {
350		ver := decode[versionOut](t, res.stdout)	350		ver := decode[versionOut](t, res.stdout)
351		assert.Equal(t, c.url, ver.Server.URL)	351		assert.Equal(t, c.url, ver.Server.URL)
352		assert.NotEmpty(t, ver.Server.Version)	352		assert.NotEmpty(t, ver.Server.Version)
353	-	assert.ElementsMatch(t, []string{"repo.update", "events.resume", "merge_requests", "merge_requests.delete_branch", "issues", "merge_requests.mergeability", "signing_key", "session", "git.list_paths", "token.branch_prefixes", "ci.runs", "ci.runs.filters", "ci.runners", "ci.actions", "ci.annotations", "ci.summaries", "ci.concurrency", "ci.dispatch", "ci.workflows", "ci.cache", "ci.secrets", "ci.artifacts", "commit_signatures", "mirror"}, ver.Server.Features)	353	+	assert.ElementsMatch(t, []string{"repo.update", "events.resume", "merge_requests", "merge_requests.delete_branch", "issues", "issues.links", "merge_requests.mergeability", "signing_key", "session", "git.list_paths", "token.branch_prefixes", "ci.runs", "ci.runs.filters", "ci.runners", "ci.actions", "ci.annotations", "ci.summaries", "ci.concurrency", "ci.dispatch", "ci.workflows", "ci.cache", "ci.secrets", "ci.artifacts", "commit_signatures", "mirror"}, ver.Server.Features)
354		assert.Equal(t, []string{"passkeys"}, ver.Server.MissingFeatures)	354		assert.Equal(t, []string{"passkeys"}, ver.Server.MissingFeatures)
355		stdout, stderr, code = c.bin(t, secret, "version")	355		stdout, stderr, code = c.bin(t, secret, "version")
356		require.Equal(t, 0, code, stderr)	356		require.Equal(t, 0, code, stderr)

M internal/app/cli_issue.go +55 -9

show this file

M internal/app/cli_issue_e2e_test.go +7 -2

show this file

M internal/app/cli_issue_test.go +36 -1

show this file

M internal/app/forge.go +4 -2

show this file

M internal/app/issue_api_test.go +52 -0

show this file

M internal/domain/event.go +12 -0

show this file

M internal/domain/issue.go +8 -0

show this file

A internal/domain/reference.go +112 -0

show this file

A internal/domain/reference_test.go +78 -0

show this file

M internal/ports/dto.go +12 -2

show this file

A internal/ports/mocks/IssueLinkStore.go +296 -0

show this file

A internal/ports/mocks/IssueLinkTrigger.go +262 -0

show this file

M internal/ports/ports.go +20 -0

show this file

M internal/ports/services.go +2 -1

show this file

M internal/usecase/events.go +7 -1

show this file

M internal/usecase/events_test.go +24 -0

show this file

A internal/usecase/issue_links.go +286 -0

show this file

A internal/usecase/issue_links_test.go +235 -0

show this file

M internal/usecase/issues.go +35 -9

show this file

M internal/usecase/issues_test.go +4 -2

show this file

M internal/usecase/mergerequests.go +33 -3

show this file

M internal/usecase/pushes.go +7 -0

show this file

M proto/ermite/storage/issue.proto +12 -0

show this file

Merge settings

Comments0 open / 0

Commit	Subject	Author	Date	Signature
4bec9a0	refactor(web): render the issue body and its merge request links in their own helpers	brice	44h ago	GPG Verified
804d55b	Merge branch 'main' into feat/issue-mr-links	brice	44h ago	GPG Verified
8782b5a	build(deps): require bnema.dev/ermite-api v0.13.0 for issue references	brice	44h ago	GPG Verified
b58599a	fix(issues): serialize issue link reindexing, keep truncated references whole and refresh links after merges	brice	45h ago	GPG Verified
29c90bb	Merge branch 'feat/issue-mr-links-api' into feat/issue-mr-links	brice	45h ago	GPG Verified
7dac988	feat(issues): show merge request references and closing merge request in the API and CLI	brice	45h ago	GPG Verified
6859f89	feat(web): link #N references in Markdown and show merge request links on issue pages	brice	45h ago	GPG Verified
1386983	feat(issues): index merge request mentions of issues and close linked issues on merge	brice	45h ago	GPG Verified
8a27537	feat(issues): parse issue references and store issue to merge request links	brice	46h ago	GPG Verified