| @@ -0,0 +1,561 @@ |
| 1 | + | // SPDX-License-Identifier: AGPL-3.0-or-later |
| 2 | + | |
| 3 | + | package kvstore_test |
| 4 | + | |
| 5 | + | import ( |
| 6 | + | "context" |
| 7 | + | "slices" |
| 8 | + | "sort" |
| 9 | + | "strconv" |
| 10 | + | "sync" |
| 11 | + | "testing" |
| 12 | + | |
| 13 | + | "github.com/stretchr/testify/assert" |
| 14 | + | "github.com/stretchr/testify/require" |
| 15 | + | "google.golang.org/protobuf/proto" |
| 16 | + | |
| 17 | + | storagepb "bnema.dev/ermite/gen/ermite/storage" |
| 18 | + | "bnema.dev/ermite/internal/adapters/kvstore" |
| 19 | + | "bnema.dev/ermite/internal/domain" |
| 20 | + | "bnema.dev/ermite/internal/ports" |
| 21 | + | ) |
| 22 | + | |
| 23 | + | func newIssue(t *testing.T, repo domain.RepoName, title string) domain.Issue { |
| 24 | + | t.Helper() |
| 25 | + | ti, err := domain.ParseIssueTitle(title) |
| 26 | + | require.NoError(t, err) |
| 27 | + | body, err := domain.ParseIssueBody("what\nhappened") |
| 28 | + | require.NoError(t, err) |
| 29 | + | return domain.Issue{ |
| 30 | + | Repo: repo, Title: ti, Body: body, State: domain.IssueStateOpen, |
| 31 | + | Author: "agent", CreatedAt: created, UpdatedAt: created, |
| 32 | + | } |
| 33 | + | } |
| 34 | + | |
| 35 | + | func newIssueComment(t *testing.T, id int64, text string) domain.IssueComment { |
| 36 | + | t.Helper() |
| 37 | + | body, err := domain.ParseIssueBody(text) |
| 38 | + | require.NoError(t, err) |
| 39 | + | return domain.IssueComment{ID: id, Author: "agent", Text: body, CreatedAt: created} |
| 40 | + | } |
| 41 | + | |
| 42 | + | // countKeys counts the keys of the store under prefix. |
| 43 | + | func countKeys(t *testing.T, s *kvstore.Store, prefix string) int { |
| 44 | + | t.Helper() |
| 45 | + | return s.CountKeysForTest(context.Background(), prefix) |
| 46 | + | } |
| 47 | + | |
| 48 | + | func TestIssueRoundTripAndPaging(t *testing.T) { |
| 49 | + | ctx := context.Background() |
| 50 | + | s, _, n := repoWithMRs(t) |
| 51 | + | is := s.Issues() |
| 52 | + | |
| 53 | + | first, err := is.Create(ctx, newIssue(t, n, "one")) |
| 54 | + | require.NoError(t, err) |
| 55 | + | assert.Equal(t, int64(1), first.Number) |
| 56 | + | assert.NotZero(t, first.Version) |
| 57 | + | got, err := is.Get(ctx, n, 1) |
| 58 | + | require.NoError(t, err) |
| 59 | + | assert.Equal(t, first, got) |
| 60 | + | _, err = is.Get(ctx, n, 2) |
| 61 | + | assert.ErrorIs(t, err, domain.ErrNotFound) |
| 62 | + | |
| 63 | + | for _, title := range []string{"two", "three", "four"} { |
| 64 | + | _, err := is.Create(ctx, newIssue(t, n, title)) |
| 65 | + | require.NoError(t, err) |
| 66 | + | } |
| 67 | + | closed, err := is.Get(ctx, n, 2) |
| 68 | + | require.NoError(t, err) |
| 69 | + | closed.State = domain.IssueStateClosed |
| 70 | + | require.NoError(t, is.Update(ctx, closed)) |
| 71 | + | |
| 72 | + | page, err := is.List(ctx, n, ports.ListIssuesParams{PageSize: 3}) |
| 73 | + | require.NoError(t, err) |
| 74 | + | require.Len(t, page.Issues, 3) |
| 75 | + | assert.Equal(t, int64(4), page.Issues[0].Number) |
| 76 | + | require.NotEmpty(t, page.NextPageToken) |
| 77 | + | page, err = is.List(ctx, n, ports.ListIssuesParams{PageSize: 3, PageToken: page.NextPageToken}) |
| 78 | + | require.NoError(t, err) |
| 79 | + | require.Len(t, page.Issues, 1) |
| 80 | + | assert.Equal(t, int64(1), page.Issues[0].Number) |
| 81 | + | assert.Empty(t, page.NextPageToken) |
| 82 | + | |
| 83 | + | page, err = is.List(ctx, n, ports.ListIssuesParams{State: domain.IssueStateClosed}) |
| 84 | + | require.NoError(t, err) |
| 85 | + | require.Len(t, page.Issues, 1) |
| 86 | + | assert.Equal(t, int64(2), page.Issues[0].Number) |
| 87 | + | |
| 88 | + | _, err = is.List(ctx, n, ports.ListIssuesParams{PageToken: "x"}) |
| 89 | + | assert.ErrorIs(t, err, domain.ErrInvalid) |
| 90 | + | |
| 91 | + | _, err = is.Create(ctx, newIssue(t, name(t, "ghost"), "x")) |
| 92 | + | assert.ErrorIs(t, err, domain.ErrNotFound) |
| 93 | + | } |
| 94 | + | |
| 95 | + | func TestIssueUpdateNeedsTheVersionItWasReadAt(t *testing.T) { |
| 96 | + | ctx := context.Background() |
| 97 | + | s, _, n := repoWithMRs(t) |
| 98 | + | is := s.Issues() |
| 99 | + | first, err := is.Create(ctx, newIssue(t, n, "t")) |
| 100 | + | require.NoError(t, err) |
| 101 | + | a, b := first, first |
| 102 | + | a.State = domain.IssueStateClosed |
| 103 | + | require.NoError(t, is.Update(ctx, a)) |
| 104 | + | b.State = domain.IssueStateClosed |
| 105 | + | assert.ErrorIs(t, is.Update(ctx, b), domain.ErrConflict) |
| 106 | + | } |
| 107 | + | |
| 108 | + | func TestIssueCommentsAndSaveCommentPreconditions(t *testing.T) { |
| 109 | + | ctx := context.Background() |
| 110 | + | s, _, n := repoWithMRs(t) |
| 111 | + | is := s.Issues() |
| 112 | + | issue, err := is.Create(ctx, newIssue(t, n, "t")) |
| 113 | + | require.NoError(t, err) |
| 114 | + | |
| 115 | + | issue.CommentSeq = 1 |
| 116 | + | require.NoError(t, is.SaveComment(ctx, issue, newIssueComment(t, 1, "first"))) |
| 117 | + | // The issue moved on: the same version is refused. |
| 118 | + | issue.CommentSeq = 2 |
| 119 | + | assert.ErrorIs(t, is.SaveComment(ctx, issue, newIssueComment(t, 2, "second")), domain.ErrConflict) |
| 120 | + | issue, err = is.Get(ctx, n, issue.Number) |
| 121 | + | require.NoError(t, err) |
| 122 | + | issue.CommentSeq = 2 |
| 123 | + | require.NoError(t, is.SaveComment(ctx, issue, newIssueComment(t, 2, "second"))) |
| 124 | + | |
| 125 | + | comments, err := is.ListComments(ctx, n, issue.Number) |
| 126 | + | require.NoError(t, err) |
| 127 | + | require.Len(t, comments, 2) |
| 128 | + | assert.Equal(t, "first", comments[0].Text.String()) |
| 129 | + | assert.Equal(t, int64(2), comments[1].ID) |
| 130 | + | |
| 131 | + | require.NoError(t, s.Delete(ctx, n)) |
| 132 | + | assert.ErrorIs(t, is.SaveComment(ctx, issue, newIssueComment(t, 3, "late")), domain.ErrNotFound) |
| 133 | + | } |
| 134 | + | |
| 135 | + | func TestConcurrentMergeRequestsAndIssuesNeverShareANumber(t *testing.T) { |
| 136 | + | ctx := context.Background() |
| 137 | + | s, mrs, n := repoWithMRs(t) |
| 138 | + | is := s.Issues() |
| 139 | + | const workers = 16 |
| 140 | + | var ( |
| 141 | + | wg sync.WaitGroup |
| 142 | + | mu sync.Mutex |
| 143 | + | numbers []int64 |
| 144 | + | ) |
| 145 | + | for w := range workers { |
| 146 | + | wg.Go(func() { |
| 147 | + | var number int64 |
| 148 | + | if w%2 == 0 { |
| 149 | + | got, err := mrs.Create(ctx, newMR(t, n, "t")) |
| 150 | + | if !assert.NoError(t, err) { |
| 151 | + | return |
| 152 | + | } |
| 153 | + | number = got.Number |
| 154 | + | } else { |
| 155 | + | got, err := is.Create(ctx, newIssue(t, n, "t")) |
| 156 | + | if !assert.NoError(t, err) { |
| 157 | + | return |
| 158 | + | } |
| 159 | + | number = got.Number |
| 160 | + | } |
| 161 | + | mu.Lock() |
| 162 | + | numbers = append(numbers, number) |
| 163 | + | mu.Unlock() |
| 164 | + | }) |
| 165 | + | } |
| 166 | + | wg.Wait() |
| 167 | + | want := make([]int64, workers) |
| 168 | + | for i := range want { |
| 169 | + | want[i] = int64(i + 1) |
| 170 | + | } |
| 171 | + | assert.ElementsMatch(t, want, numbers, "every number is used once, by an issue or a merge request") |
| 172 | + | } |
| 173 | + | |
| 174 | + | func TestDeleteDropsTheIssuesOfTheRepository(t *testing.T) { |
| 175 | + | ctx := context.Background() |
| 176 | + | s, _, n := repoWithMRs(t) |
| 177 | + | sib := name(t, "proj-2") |
| 178 | + | require.NoError(t, s.Create(ctx, domain.Repo{Name: sib, CreatedAt: created, Visibility: domain.VisibilityPublic})) |
| 179 | + | is := s.Issues() |
| 180 | + | |
| 181 | + | for _, repo := range []domain.RepoName{n, sib} { |
| 182 | + | issue, err := is.Create(ctx, newIssue(t, repo, "t")) |
| 183 | + | require.NoError(t, err) |
| 184 | + | issue.CommentSeq = 1 |
| 185 | + | require.NoError(t, is.SaveComment(ctx, issue, newIssueComment(t, 1, "note"))) |
| 186 | + | } |
| 187 | + | require.NoError(t, s.Delete(ctx, n)) |
| 188 | + | |
| 189 | + | page, err := is.List(ctx, n, ports.ListIssuesParams{}) |
| 190 | + | require.NoError(t, err) |
| 191 | + | assert.Empty(t, page.Issues) |
| 192 | + | comments, err := is.ListComments(ctx, n, 1) |
| 193 | + | require.NoError(t, err) |
| 194 | + | assert.Empty(t, comments) |
| 195 | + | assert.Empty(t, openOf(t, is, n)) |
| 196 | + | assert.Zero(t, countKeys(t, s, "is/proj/")) |
| 197 | + | assert.Zero(t, countKeys(t, s, "isc/proj/")) |
| 198 | + | assert.Zero(t, countKeys(t, s, "isopen/proj/")) |
| 199 | + | |
| 200 | + | open := openOf(t, is, sib) |
| 201 | + | assert.Len(t, open, 1, "a repository whose name starts like the deleted one keeps its issues") |
| 202 | + | comments, err = is.ListComments(ctx, sib, 1) |
| 203 | + | require.NoError(t, err) |
| 204 | + | assert.Len(t, comments, 1) |
| 205 | + | |
| 206 | + | require.NoError(t, s.Create(ctx, domain.Repo{Name: n, CreatedAt: created, Visibility: domain.VisibilityPrivate})) |
| 207 | + | again, err := is.Create(ctx, newIssue(t, n, "fresh")) |
| 208 | + | require.NoError(t, err) |
| 209 | + | assert.Equal(t, int64(1), again.Number) |
| 210 | + | } |
| 211 | + | |
| 212 | + | func TestOpenIssueIndexFollowsUpdates(t *testing.T) { |
| 213 | + | ctx := context.Background() |
| 214 | + | s, _, n := repoWithMRs(t) |
| 215 | + | is := s.Issues() |
| 216 | + | a, err := is.Create(ctx, newIssue(t, n, "a")) |
| 217 | + | require.NoError(t, err) |
| 218 | + | b, err := is.Create(ctx, newIssue(t, n, "b")) |
| 219 | + | require.NoError(t, err) |
| 220 | + | |
| 221 | + | numbers := func() []int64 { |
| 222 | + | open := openOf(t, is, n) |
| 223 | + | var out []int64 |
| 224 | + | for _, i := range open { |
| 225 | + | out = append(out, i.Number) |
| 226 | + | } |
| 227 | + | return out |
| 228 | + | } |
| 229 | + | assert.Equal(t, []int64{2, 1}, numbers()) |
| 230 | + | assert.Equal(t, 2, countKeys(t, s, "isopen/proj/")) |
| 231 | + | |
| 232 | + | a.State = domain.IssueStateClosed |
| 233 | + | require.NoError(t, is.Update(ctx, a)) |
| 234 | + | assert.Equal(t, []int64{2}, numbers()) |
| 235 | + | assert.Equal(t, 1, countKeys(t, s, "isopen/proj/")) |
| 236 | + | |
| 237 | + | a, err = is.Get(ctx, n, a.Number) |
| 238 | + | require.NoError(t, err) |
| 239 | + | a.State = domain.IssueStateOpen |
| 240 | + | require.NoError(t, is.Update(ctx, a)) |
| 241 | + | assert.Equal(t, []int64{2, 1}, numbers()) |
| 242 | + | |
| 243 | + | // A comment keeps the index as the issue says. |
| 244 | + | b.State = domain.IssueStateClosed |
| 245 | + | b.CommentSeq = 1 |
| 246 | + | require.NoError(t, is.SaveComment(ctx, b, newIssueComment(t, 1, "closing"))) |
| 247 | + | assert.Equal(t, []int64{1}, numbers()) |
| 248 | + | assert.Equal(t, 1, countKeys(t, s, "isopen/proj/")) |
| 249 | + | } |
| 250 | + | |
| 251 | + | func TestRepoSettingsKeepTheIssuesMode(t *testing.T) { |
| 252 | + | ctx := context.Background() |
| 253 | + | s := openStore(t, t.TempDir()) |
| 254 | + | n := name(t, "proj") |
| 255 | + | require.NoError(t, s.Create(ctx, domain.Repo{Name: n, CreatedAt: created, Visibility: domain.VisibilityPrivate})) |
| 256 | + | got, err := s.Get(ctx, n) |
| 257 | + | require.NoError(t, err) |
| 258 | + | assert.Equal(t, domain.IssuesOff, got.Settings.Issues) |
| 259 | + | for _, m := range []domain.IssuesMode{domain.IssuesOwner, domain.IssuesPublic, domain.IssuesOff} { |
| 260 | + | got.Settings.Issues = m |
| 261 | + | require.NoError(t, s.Update(ctx, got)) |
| 262 | + | again, err := s.Get(ctx, n) |
| 263 | + | require.NoError(t, err) |
| 264 | + | assert.Equal(t, m, again.Settings.Issues) |
| 265 | + | } |
| 266 | + | got.Settings.Issues = "everyone" |
| 267 | + | assert.ErrorIs(t, s.Update(ctx, got), domain.ErrInvalid) |
| 268 | + | } |
| 269 | + | |
| 270 | + | // TestSchema4UpgradesTheTokensWithAllScopes: the tokens that held every |
| 271 | + | // original scope keep their owner rights, gaining mr:review and issue:write |
| 272 | + | // (each only if missing); no other token changes. |
| 273 | + | func TestSchema4UpgradesTheTokensWithAllScopes(t *testing.T) { |
| 274 | + | ctx := context.Background() |
| 275 | + | dir := t.TempDir() |
| 276 | + | putRaw(t, dir, "meta/schema", mustProto(t, &storagepb.SchemaVersion{Version: 3})) |
| 277 | + | |
| 278 | + | all9 := []string{ |
| 279 | + | "repo:read", "repo:write", "repo:admin", "mr:write", "mr:merge", |
| 280 | + | "ci:write", "secrets:write", "runner:register", "token:admin", |
| 281 | + | } |
| 282 | + | tokens := map[string]*storagepb.Token{ |
| 283 | + | "full": {Id: "full", Scopes: all9}, |
| 284 | + | "full10": {Id: "full10", Scopes: append(slices.Clone(all9), "mr:review")}, |
| 285 | + | "reposmr": {Id: "reposmr", Scopes: append(slices.Clone(all9), "mr:review"), Repos: []string{"proj"}}, |
| 286 | + | "missing": {Id: "missing", Scopes: all9[:8]}, |
| 287 | + | "repos": {Id: "repos", Scopes: all9, Repos: []string{"proj"}}, |
| 288 | + | "prefix": {Id: "prefix", Scopes: all9, BranchPrefixes: []string{"agent/"}}, |
| 289 | + | "small": {Id: "small", Scopes: []string{"repo:read"}}, |
| 290 | + | "otherfull": {Id: "otherfull", Scopes: append([]string{"token:admin"}, all9[:8]...)}, |
| 291 | + | } |
| 292 | + | for id, tok := range tokens { |
| 293 | + | tok.Hash = make([]byte, 32) |
| 294 | + | tok.Hash[0] = byte(len(id)) |
| 295 | + | putRaw(t, dir, "token/"+id, mustProto(t, tok)) |
| 296 | + | } |
| 297 | + | |
| 298 | + | s, err := kvstore.Open(ctx, dir) |
| 299 | + | require.NoError(t, err) |
| 300 | + | t.Cleanup(func() { _ = s.Close(ctx) }) |
| 301 | + | get := func(id string) domain.Token { |
| 302 | + | tok, err := s.Tokens().Get(ctx, id) |
| 303 | + | require.NoError(t, err) |
| 304 | + | return tok |
| 305 | + | } |
| 306 | + | |
| 307 | + | full := get("full") |
| 308 | + | assert.Contains(t, full.Scopes, domain.ScopeIssueWrite) |
| 309 | + | assert.Contains(t, full.Scopes, domain.ScopeMRReview) |
| 310 | + | assert.Len(t, full.Scopes, 11) |
| 311 | + | full10 := get("full10") |
| 312 | + | assert.Len(t, full10.Scopes, 11) |
| 313 | + | assert.Equal(t, 1, countScope(full10.Scopes, domain.ScopeMRReview)) |
| 314 | + | assert.Contains(t, full10.Scopes, domain.ScopeIssueWrite) |
| 315 | + | assert.True(t, domain.TokenPrincipal(full10).HasOwnerRights()) |
| 316 | + | assert.Len(t, get("reposmr").Scopes, 10) |
| 317 | + | assert.NotContains(t, get("reposmr").Scopes, domain.ScopeIssueWrite) |
| 318 | + | assert.True(t, domain.TokenPrincipal(full).HasOwnerRights()) |
| 319 | + | assert.True(t, domain.TokenPrincipal(get("otherfull")).HasOwnerRights(), "the order of the scopes does not matter") |
| 320 | + | |
| 321 | + | assert.NotContains(t, get("missing").Scopes, domain.ScopeIssueWrite) |
| 322 | + | assert.NotContains(t, get("missing").Scopes, domain.ScopeMRReview) |
| 323 | + | assert.NotContains(t, get("repos").Scopes, domain.ScopeMRReview) |
| 324 | + | assert.NotContains(t, get("prefix").Scopes, domain.ScopeMRReview) |
| 325 | + | assert.False(t, domain.TokenPrincipal(get("missing")).HasOwnerRights()) |
| 326 | + | assert.NotContains(t, get("repos").Scopes, domain.ScopeIssueWrite) |
| 327 | + | assert.NotContains(t, get("prefix").Scopes, domain.ScopeIssueWrite) |
| 328 | + | assert.Equal(t, []domain.Scope{domain.ScopeRepoRead}, get("small").Scopes) |
| 329 | + | assert.Len(t, get("missing").Scopes, 8) |
| 330 | + | assert.Len(t, get("repos").Scopes, 9) |
| 331 | + | assert.Len(t, get("prefix").Scopes, 9) |
| 332 | + | assert.Equal(t, []string{"agent/"}, get("prefix").BranchPrefixes) |
| 333 | + | assert.Equal(t, "full", full.ID) |
| 334 | + | |
| 335 | + | require.NoError(t, s.Close(ctx)) |
| 336 | + | assert.Equal(t, uint32(4), readSchema(t, dir)) |
| 337 | + | |
| 338 | + | // A second open changes nothing. |
| 339 | + | s2, err := kvstore.Open(ctx, dir) |
| 340 | + | require.NoError(t, err) |
| 341 | + | tok, err := s2.Tokens().Get(ctx, "full") |
| 342 | + | require.NoError(t, err) |
| 343 | + | assert.Equal(t, full.Scopes, tok.Scopes) |
| 344 | + | tok10, err := s2.Tokens().Get(ctx, "full10") |
| 345 | + | require.NoError(t, err) |
| 346 | + | assert.Equal(t, full10.Scopes, tok10.Scopes) |
| 347 | + | require.NoError(t, s2.Close(ctx)) |
| 348 | + | } |
| 349 | + | |
| 350 | + | func TestSchemaNewerThanThisBuildStopsIssuesData(t *testing.T) { |
| 351 | + | ctx := context.Background() |
| 352 | + | dir := t.TempDir() |
| 353 | + | putRaw(t, dir, "meta/schema", mustProto(t, &storagepb.SchemaVersion{Version: kvstore.SchemaVersion + 1})) |
| 354 | + | _, err := kvstore.Open(ctx, dir) |
| 355 | + | require.ErrorIs(t, err, kvstore.ErrSchemaTooNew) |
| 356 | + | assert.Equal(t, uint32(4), uint32(kvstore.SchemaVersion)) |
| 357 | + | } |
| 358 | + | |
| 359 | + | // A reopen racing the delete of the repository either lands before the delete |
| 360 | + | // removes it or fails; it never leaves an isopen/ key of a repository that is |
| 361 | + | // gone. |
| 362 | + | func TestDeleteVersusReopenLeavesNoIssueKeys(t *testing.T) { |
| 363 | + | ctx := context.Background() |
| 364 | + | for range 30 { |
| 365 | + | s, _, n := repoWithMRs(t) |
| 366 | + | is := s.Issues() |
| 367 | + | issue, err := is.Create(ctx, newIssue(t, n, "t")) |
| 368 | + | require.NoError(t, err) |
| 369 | + | issue.State = domain.IssueStateClosed |
| 370 | + | require.NoError(t, is.Update(ctx, issue)) |
| 371 | + | closed, err := is.Get(ctx, n, issue.Number) |
| 372 | + | require.NoError(t, err) |
| 373 | + | closed.State = domain.IssueStateOpen |
| 374 | + | |
| 375 | + | var wg sync.WaitGroup |
| 376 | + | start := make(chan struct{}) |
| 377 | + | wg.Add(2) |
| 378 | + | go func() { defer wg.Done(); <-start; _ = is.Update(ctx, closed) }() |
| 379 | + | go func() { defer wg.Done(); <-start; _ = s.Delete(ctx, n) }() |
| 380 | + | close(start) |
| 381 | + | wg.Wait() |
| 382 | + | |
| 383 | + | for _, prefix := range []string{"is/proj/", "isc/proj/", "isopen/proj/"} { |
| 384 | + | assert.Zero(t, countKeys(t, s, prefix), prefix) |
| 385 | + | } |
| 386 | + | assert.ErrorIs(t, is.Update(ctx, closed), domain.ErrNotFound) |
| 387 | + | } |
| 388 | + | } |
| 389 | + | |
| 390 | + | func TestListOpenAllSpansRepositoriesThroughTheIndex(t *testing.T) { |
| 391 | + | ctx := context.Background() |
| 392 | + | s, mrs, n := repoWithMRs(t) |
| 393 | + | other := name(t, "other") |
| 394 | + | require.NoError(t, s.Create(ctx, domain.Repo{Name: other, CreatedAt: created, Visibility: domain.VisibilityPublic})) |
| 395 | + | is := s.Issues() |
| 396 | + | |
| 397 | + | i1, err := is.Create(ctx, newIssue(t, n, "one")) |
| 398 | + | require.NoError(t, err) |
| 399 | + | i2, err := is.Create(ctx, newIssue(t, other, "two")) |
| 400 | + | require.NoError(t, err) |
| 401 | + | i3, err := is.Create(ctx, newIssue(t, other, "three")) |
| 402 | + | require.NoError(t, err) |
| 403 | + | i3.State = domain.IssueStateClosed |
| 404 | + | require.NoError(t, is.Update(ctx, i3)) |
| 405 | + | _, err = mrs.Create(ctx, newMR(t, n, "mr1")) |
| 406 | + | require.NoError(t, err) |
| 407 | + | m2, err := mrs.Create(ctx, newMR(t, other, "mr2")) |
| 408 | + | require.NoError(t, err) |
| 409 | + | m3, err := mrs.Create(ctx, newMR(t, other, "mr3")) |
| 410 | + | require.NoError(t, err) |
| 411 | + | m3.State = domain.MRStateClosed |
| 412 | + | require.NoError(t, mrs.Update(ctx, m3)) |
| 413 | + | |
| 414 | + | issues, err := is.ListOpenAll(ctx) |
| 415 | + | require.NoError(t, err) |
| 416 | + | var got []string |
| 417 | + | for _, i := range issues { |
| 418 | + | got = append(got, i.Repo.String()+"#"+strconv.FormatInt(i.Number, 10)) |
| 419 | + | } |
| 420 | + | assert.ElementsMatch(t, []string{ |
| 421 | + | i1.Repo.String() + "#" + strconv.FormatInt(i1.Number, 10), |
| 422 | + | i2.Repo.String() + "#" + strconv.FormatInt(i2.Number, 10), |
| 423 | + | }, got) |
| 424 | + | |
| 425 | + | open, err := mrs.ListOpenAll(ctx) |
| 426 | + | require.NoError(t, err) |
| 427 | + | got = nil |
| 428 | + | for _, m := range open { |
| 429 | + | got = append(got, m.Repo.String()+"#"+strconv.FormatInt(m.Number, 10)) |
| 430 | + | } |
| 431 | + | assert.ElementsMatch(t, []string{"proj#2", m2.Repo.String() + "#" + strconv.FormatInt(m2.Number, 10)}, got) |
| 432 | + | assert.Len(t, open, 2) |
| 433 | + | } |
| 434 | + | |
| 435 | + | func TestListOpenAllIsEmptyWithoutOpenItems(t *testing.T) { |
| 436 | + | ctx := context.Background() |
| 437 | + | s, mrs, _ := repoWithMRs(t) |
| 438 | + | issues, err := s.Issues().ListOpenAll(ctx) |
| 439 | + | require.NoError(t, err) |
| 440 | + | assert.Empty(t, issues) |
| 441 | + | open, err := mrs.ListOpenAll(ctx) |
| 442 | + | require.NoError(t, err) |
| 443 | + | assert.Empty(t, open) |
| 444 | + | } |
| 445 | + | |
| 446 | + | func TestListOpenAllSkipsAStaleIndexEntry(t *testing.T) { |
| 447 | + | ctx := context.Background() |
| 448 | + | s, mrs, n := repoWithMRs(t) |
| 449 | + | is := s.Issues() |
| 450 | + | keepI, err := is.Create(ctx, newIssue(t, n, "keep")) |
| 451 | + | require.NoError(t, err) |
| 452 | + | goneI, err := is.Create(ctx, newIssue(t, n, "gone")) |
| 453 | + | require.NoError(t, err) |
| 454 | + | keepM, err := mrs.Create(ctx, newMR(t, n, "keep")) |
| 455 | + | require.NoError(t, err) |
| 456 | + | goneM, err := mrs.Create(ctx, newMR(t, n, "gone")) |
| 457 | + | require.NoError(t, err) |
| 458 | + | |
| 459 | + | require.NoError(t, is.DropIssueRecordForTest(ctx, n, goneI.Number)) |
| 460 | + | require.NoError(t, mrs.DropMRRecordForTest(ctx, n, goneM.Number)) |
| 461 | + | require.Positive(t, countKeys(t, s, "isopen/proj/"), "the index entries are still there") |
| 462 | + | require.Positive(t, countKeys(t, s, "mropen/proj/")) |
| 463 | + | |
| 464 | + | issues, err := is.ListOpenAll(ctx) |
| 465 | + | require.NoError(t, err) |
| 466 | + | require.Len(t, issues, 1) |
| 467 | + | assert.Equal(t, keepI.Number, issues[0].Number) |
| 468 | + | open, err := mrs.ListOpenAll(ctx) |
| 469 | + | require.NoError(t, err) |
| 470 | + | require.Len(t, open, 1) |
| 471 | + | assert.Equal(t, keepM.Number, open[0].Number) |
| 472 | + | } |
| 473 | + | |
| 474 | + | func TestIssueListPagesThroughManyIssues(t *testing.T) { |
| 475 | + | ctx := context.Background() |
| 476 | + | s, _, n := repoWithMRs(t) |
| 477 | + | is := s.Issues() |
| 478 | + | const total = 53 |
| 479 | + | for i := 1; i <= total; i++ { |
| 480 | + | _, err := is.Create(ctx, newIssue(t, n, "issue "+strconv.Itoa(i))) |
| 481 | + | require.NoError(t, err) |
| 482 | + | } |
| 483 | + | for i := 2; i <= total; i += 3 { // 2, 5, 8, ... |
| 484 | + | is, err := is.Get(ctx, n, int64(i)) |
| 485 | + | require.NoError(t, err) |
| 486 | + | is.State = domain.IssueStateClosed |
| 487 | + | require.NoError(t, s.Issues().Update(ctx, is)) |
| 488 | + | } |
| 489 | + | |
| 490 | + | walk := func(state domain.IssueState, size int) []int64 { |
| 491 | + | var got []int64 |
| 492 | + | token := "" |
| 493 | + | for { |
| 494 | + | page, err := s.Issues().List(ctx, n, ports.ListIssuesParams{State: state, PageSize: size, PageToken: token}) |
| 495 | + | require.NoError(t, err) |
| 496 | + | require.LessOrEqual(t, len(page.Issues), size) |
| 497 | + | for _, is := range page.Issues { |
| 498 | + | got = append(got, is.Number) |
| 499 | + | } |
| 500 | + | if page.NextPageToken == "" { |
| 501 | + | return got |
| 502 | + | } |
| 503 | + | token = page.NextPageToken |
| 504 | + | } |
| 505 | + | } |
| 506 | + | for _, size := range []int{1, 7, 10, 53, 100} { |
| 507 | + | var all, closed []int64 |
| 508 | + | for i := int64(total); i >= 1; i-- { |
| 509 | + | all = append(all, i) |
| 510 | + | if i%3 == 2 { |
| 511 | + | closed = append(closed, i) |
| 512 | + | } |
| 513 | + | } |
| 514 | + | assert.Equal(t, all, walk("", size), "size %d", size) |
| 515 | + | assert.Equal(t, closed, walk(domain.IssueStateClosed, size), "closed, size %d", size) |
| 516 | + | } |
| 517 | + | page, err := s.Issues().List(ctx, n, ports.ListIssuesParams{PageSize: 10, PageToken: "1"}) |
| 518 | + | require.NoError(t, err) |
| 519 | + | assert.Empty(t, page.Issues) |
| 520 | + | assert.Empty(t, page.NextPageToken) |
| 521 | + | } |
| 522 | + | |
| 523 | + | // openOf lists the open issues of one repository through the isopen/ index. |
| 524 | + | func openOf(t *testing.T, is *kvstore.Issues, repo domain.RepoName) []domain.Issue { |
| 525 | + | t.Helper() |
| 526 | + | all, err := is.ListOpenAll(context.Background()) |
| 527 | + | require.NoError(t, err) |
| 528 | + | var out []domain.Issue |
| 529 | + | for _, i := range all { |
| 530 | + | if i.Repo == repo { |
| 531 | + | out = append(out, i) |
| 532 | + | } |
| 533 | + | } |
| 534 | + | sort.Slice(out, func(a, b int) bool { return out[a].Number > out[b].Number }) |
| 535 | + | return out |
| 536 | + | } |
| 537 | + | |
| 538 | + | func TestStoredPendingIssueStateIsCorrupt(t *testing.T) { |
| 539 | + | ctx := context.Background() |
| 540 | + | s, _, n := repoWithMRs(t) |
| 541 | + | is := s.Issues() |
| 542 | + | raw, err := proto.Marshal(&storagepb.Issue{Number: 1, Title: "x", State: storagepb.IssueState_ISSUE_STATE_PENDING}) |
| 543 | + | require.NoError(t, err) |
| 544 | + | require.NoError(t, is.PutRawIssueForTest(ctx, n, 1, raw)) |
| 545 | + | _, err = is.Get(ctx, n, 1) |
| 546 | + | assert.ErrorContains(t, err, "pending") |
| 547 | + | _, err = is.List(ctx, n, ports.ListIssuesParams{}) |
| 548 | + | assert.ErrorContains(t, err, "pending") |
| 549 | + | _, err = is.List(ctx, n, ports.ListIssuesParams{State: domain.IssueStateOpen}) |
| 550 | + | assert.ErrorContains(t, err, "pending") |
| 551 | + | } |
| 552 | + | |
| 553 | + | func countScope(scopes []domain.Scope, want domain.Scope) int { |
| 554 | + | n := 0 |
| 555 | + | for _, s := range scopes { |
| 556 | + | if s == want { |
| 557 | + | n++ |
| 558 | + | } |
| 559 | + | } |
| 560 | + | return n |
| 561 | + | } |