fix: handle errcheck for cliWritef/cliWriteLine in attachments push
- commit
- 1e66d5a0ac647ac55c59bb314540b6a71ee88d6f
- author
- brice · · 2026-03-14 09:24 UTC
- parent
- 760ee8d
- signature
- unsigned
1 file · +15 -5
M internal/adapters/in/cli/attachments_push.go +15 -5
| @@ -77,11 +77,19 @@ func runAttachmentsPush(ctx context.Context, imageArg, tag string, build bool, p | |||
| 77 | 77 | ||
| 78 | 78 | versionRef, latestRef := resolveImageRefs(registry, imageName, version) | |
| 79 | 79 | ||
| 80 | - | cliWritef(out, "Attachment image: %s\n", styles.Theme.Bold.Render(imageArg)) | |
| 81 | - | cliWritef(out, "Targets: %s\n", styles.Theme.Bold.Render(formatAttachmentTargets(targets))) | |
| 82 | - | cliWritef(out, "Image: %s\n", styles.Theme.Bold.Render(versionRef)) | |
| 80 | + | if err := cliWritef(out, "Attachment image: %s\n", styles.Theme.Bold.Render(imageArg)); err != nil { | |
| 81 | + | return err | |
| 82 | + | } | |
| 83 | + | if err := cliWritef(out, "Targets: %s\n", styles.Theme.Bold.Render(formatAttachmentTargets(targets))); err != nil { | |
| 84 | + | return err | |
| 85 | + | } | |
| 86 | + | if err := cliWritef(out, "Image: %s\n", styles.Theme.Bold.Render(versionRef)); err != nil { | |
| 87 | + | return err | |
| 88 | + | } | |
| 83 | 89 | if version != "latest" { | |
| 84 | - | cliWritef(out, "Also: %s\n", styles.Theme.Bold.Render(latestRef)) | |
| 90 | + | if err := cliWritef(out, "Also: %s\n", styles.Theme.Bold.Render(latestRef)); err != nil { | |
| 91 | + | return err | |
| 92 | + | } | |
| 85 | 93 | } | |
| 86 | 94 | ||
| 87 | 95 | if build { | |
| @@ -94,7 +102,9 @@ func runAttachmentsPush(ctx context.Context, imageArg, tag string, build bool, p | |||
| 94 | 102 | } | |
| 95 | 103 | } | |
| 96 | 104 | ||
| 97 | - | cliWriteLine(out, styles.RenderSuccess("Push complete")) | |
| 105 | + | if err := cliWriteLine(out, styles.RenderSuccess("Push complete")); err != nil { | |
| 106 | + | return err | |
| 107 | + | } | |
| 98 | 108 | return nil | |
| 99 | 109 | } | |
| 100 | 110 | ||
| @@ -77,11 +77,19 @@ func runAttachmentsPush(ctx context.Context, imageArg, tag string, build bool, p | |||||
| 77 | 77 | ||||
| 78 | versionRef, latestRef := resolveImageRefs(registry, imageName, version) | 78 | versionRef, latestRef := resolveImageRefs(registry, imageName, version) | ||
| 79 | 79 | ||||
| 80 | - | cliWritef(out, "Attachment image: %s\n", styles.Theme.Bold.Render(imageArg)) | 80 | + | if err := cliWritef(out, "Attachment image: %s\n", styles.Theme.Bold.Render(imageArg)); err != nil { |
| 81 | - | cliWritef(out, "Targets: %s\n", styles.Theme.Bold.Render(formatAttachmentTargets(targets))) | 81 | + | return err |
| 82 | - | cliWritef(out, "Image: %s\n", styles.Theme.Bold.Render(versionRef)) | 82 | + | } |
| 83 | + | if err := cliWritef(out, "Targets: %s\n", styles.Theme.Bold.Render(formatAttachmentTargets(targets))); err != nil { | |||
| 84 | + | return err | |||
| 85 | + | } | |||
| 86 | + | if err := cliWritef(out, "Image: %s\n", styles.Theme.Bold.Render(versionRef)); err != nil { | |||
| 87 | + | return err | |||
| 88 | + | } | |||
| 83 | if version != "latest" { | 89 | if version != "latest" { | ||
| 84 | - | cliWritef(out, "Also: %s\n", styles.Theme.Bold.Render(latestRef)) | 90 | + | if err := cliWritef(out, "Also: %s\n", styles.Theme.Bold.Render(latestRef)); err != nil { |
| 91 | + | return err | |||
| 92 | + | } | |||
| 85 | } | 93 | } | ||
| 86 | 94 | ||||
| 87 | if build { | 95 | if build { | ||
| @@ -94,7 +102,9 @@ func runAttachmentsPush(ctx context.Context, imageArg, tag string, build bool, p | |||||
| 94 | } | 102 | } | ||
| 95 | } | 103 | } | ||
| 96 | 104 | ||||
| 97 | - | cliWriteLine(out, styles.RenderSuccess("Push complete")) | 105 | + | if err := cliWriteLine(out, styles.RenderSuccess("Push complete")); err != nil { |
| 106 | + | return err | |||
| 107 | + | } | |||
| 98 | return nil | 108 | return nil | ||
| 99 | } | 109 | } | ||
| 100 | 110 | ||||