detached 1e66d5a

fix: handle errcheck for cliWritef/cliWriteLine in attachments push

commit
1e66d5a0ac647ac55c59bb314540b6a71ee88d6f
author
brice · · 2026-03-14 09:24 UTC
parent
760ee8d
signature
unsigned
1 file · +15 -5
M internal/adapters/in/cli/attachments_push.go +15 -5
@@ -77,11 +77,19 @@ func runAttachmentsPush(ctx context.Context, imageArg, tag string, build bool, p
7777
7878 versionRef, latestRef := resolveImageRefs(registry, imageName, version)
7979
80- cliWritef(out, "Attachment image: %s\n", styles.Theme.Bold.Render(imageArg))
81- cliWritef(out, "Targets: %s\n", styles.Theme.Bold.Render(formatAttachmentTargets(targets)))
82- cliWritef(out, "Image: %s\n", styles.Theme.Bold.Render(versionRef))
80+ if err := cliWritef(out, "Attachment image: %s\n", styles.Theme.Bold.Render(imageArg)); err != nil {
81+ return err
82+ }
83+ if err := cliWritef(out, "Targets: %s\n", styles.Theme.Bold.Render(formatAttachmentTargets(targets))); err != nil {
84+ return err
85+ }
86+ if err := cliWritef(out, "Image: %s\n", styles.Theme.Bold.Render(versionRef)); err != nil {
87+ return err
88+ }
8389 if version != "latest" {
84- cliWritef(out, "Also: %s\n", styles.Theme.Bold.Render(latestRef))
90+ if err := cliWritef(out, "Also: %s\n", styles.Theme.Bold.Render(latestRef)); err != nil {
91+ return err
92+ }
8593 }
8694
8795 if build {
@@ -94,7 +102,9 @@ func runAttachmentsPush(ctx context.Context, imageArg, tag string, build bool, p
94102 }
95103 }
96104
97- cliWriteLine(out, styles.RenderSuccess("Push complete"))
105+ if err := cliWriteLine(out, styles.RenderSuccess("Push complete")); err != nil {
106+ return err
107+ }
98108 return nil
99109 }
100110
@@ -77,11 +77,19 @@ func runAttachmentsPush(ctx context.Context, imageArg, tag string, build bool, p
77 77
78 versionRef, latestRef := resolveImageRefs(registry, imageName, version)78 versionRef, latestRef := resolveImageRefs(registry, imageName, version)
79 79
80- cliWritef(out, "Attachment image: %s\n", styles.Theme.Bold.Render(imageArg))80+ if err := cliWritef(out, "Attachment image: %s\n", styles.Theme.Bold.Render(imageArg)); err != nil {
81- cliWritef(out, "Targets: %s\n", styles.Theme.Bold.Render(formatAttachmentTargets(targets)))81+ return err
82- cliWritef(out, "Image: %s\n", styles.Theme.Bold.Render(versionRef))82+ }
83+ if err := cliWritef(out, "Targets: %s\n", styles.Theme.Bold.Render(formatAttachmentTargets(targets))); err != nil {
84+ return err
85+ }
86+ if err := cliWritef(out, "Image: %s\n", styles.Theme.Bold.Render(versionRef)); err != nil {
87+ return err
88+ }
83 if version != "latest" {89 if version != "latest" {
84- cliWritef(out, "Also: %s\n", styles.Theme.Bold.Render(latestRef))90+ if err := cliWritef(out, "Also: %s\n", styles.Theme.Bold.Render(latestRef)); err != nil {
91+ return err
92+ }
85 }93 }
86 94
87 if build {95 if build {
@@ -94,7 +102,9 @@ func runAttachmentsPush(ctx context.Context, imageArg, tag string, build bool, p
94 }102 }
95 }103 }
96 104
97- cliWriteLine(out, styles.RenderSuccess("Push complete"))105+ if err := cliWriteLine(out, styles.RenderSuccess("Push complete")); err != nil {
106+ return err
107+ }
98 return nil108 return nil
99 }109 }
100 110

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 7

Tags 106

↑↓ moveenter openesc close