skip to content

detached 39cdcd8

docs: clarify HTTP onboarding comment intent

commit: 39cdcd8814be32728dd7434fef48f124a9e10109
author: brice · 6mo ago · 2026-04-01 12:21 UTC
parent: 29b9578
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

2 files · +2 -2

M internal/adapters/in/http/middleware/cidr.go +1 -1


@@ -79,7 +79,7 @@ func HTTPSAuthority(host string, httpPort, tlsPort int) string {
79	79		return host
80	80		}
81	81
82		-	port, _ := strconv.Atoi(portStr)
	82	+	port, _ := strconv.Atoi(portStr) // Ignore parse errors so invalid explicit ports fall through to the preserve-as-is branch.
83	83		if port == httpPort {
84	84		return net.JoinHostPort(hostname, strconv.Itoa(tlsPort))
85	85		}


@@ -79,7 +79,7 @@ func HTTPSAuthority(host string, httpPort, tlsPort int) string {
79		return host	79		return host
80		}	80		}
81			81
82	-	port, _ := strconv.Atoi(portStr)	82	+	port, _ := strconv.Atoi(portStr) // Ignore parse errors so invalid explicit ports fall through to the preserve-as-is branch.
83		if port == httpPort {	83		if port == httpPort {
84		return net.JoinHostPort(hostname, strconv.Itoa(tlsPort))	84		return net.JoinHostPort(hostname, strconv.Itoa(tlsPort))
85		}	85		}

M internal/app/run.go +1 -1


@@ -1727,7 +1727,7 @@ func directHTTPOnboardingGate(ob onboarding.Handler, proxyNets []net.IPNet, pr
1727	1727
1728	1728		onboardingWithMiddleware := middleware.Chain(
1729	1729		middleware.PanicRecovery(log),
1730		-	middleware.RequestLogger(log), // no trusted proxy nets — log RemoteAddr only
	1730	+	middleware.RequestLogger(log), // Intentionally omit trusted proxy nets so direct onboarding logs use RemoteAddr only.
1731	1731		middleware.SecurityHeaders,
1732	1732		)(onboardingMux)
1733	1733


@@ -1727,7 +1727,7 @@ func directHTTPOnboardingGate(ob onboarding.Handler, proxyNets []net.IPNet, pr
1727			1727
1728		onboardingWithMiddleware := middleware.Chain(	1728		onboardingWithMiddleware := middleware.Chain(
1729		middleware.PanicRecovery(log),	1729		middleware.PanicRecovery(log),
1730	-	middleware.RequestLogger(log), // no trusted proxy nets — log RemoteAddr only	1730	+	middleware.RequestLogger(log), // Intentionally omit trusted proxy nets so direct onboarding logs use RemoteAddr only.
1731		middleware.SecurityHeaders,	1731		middleware.SecurityHeaders,
1732		)(onboardingMux)	1732		)(onboardingMux)
1733			1733