fix(app): handle error from srv.Shutdown in closeStarted cleanup

commit: 937d56d1f28f858de263db9220a1c0deb97016e3
author: brice · 6mo ago · 2026-04-01 04:29 UTC
parent: b1d7815
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +3 -1

M internal/app/run.go +3 -1


@@ -1949,7 +1949,9 @@ func runServers(ctx context.Context, v viper.Viper, cfg Config, svc services,
1949	1949		defer shutdownCancel()
1950	1950		for _, srv := range servers {
1951	1951		if srv != nil {
1952		-	srv.Shutdown(shutdownCtx)
	1952	+	if err := srv.Shutdown(shutdownCtx); err != nil {
	1953	+	log.Error().Err(err).Msg("failed to shut down server during startup cleanup")
	1954	+	}
1953	1955		}
1954	1956		}
1955	1957		}

 		defer shutdownCancel()
 		for _, srv := range servers {
 			if srv != nil {
-				srv.Shutdown(shutdownCtx)
+				if err := srv.Shutdown(shutdownCtx); err != nil {
+					log.Error().Err(err).Msg("failed to shut down server during startup cleanup")
+				}
 			}
 		}
 	}