detached 96d1318

fix: add error handling for SendFileAsChunks resp

commit
96d131871ec8444bcbc71d5f44130f69cc981182
author
Brice · · 2024-11-19 19:22 UTC
committer
Brice · · 2024-11-19 22:07 UTC
parent
5ff97c4
signature
unsigned
1 file · +9 -0
M internal/cli/cmd/push.go +9 -0
@@ -97,6 +97,15 @@ func pushImage(a *cli.App, reader io.Reader, imageName string) error {
9797 defer cancel()
9898
9999 resp, err := chunkedClient.SendFileAsChunks(ctx, "/push/chunked", headers, imageReader, size, imageName)
100+ if err != nil {
101+ log.Error("Failed to send chunks", "error", err)
102+ return fmt.Errorf("failed to send chunks: %w", err)
103+ }
104+
105+ if resp == nil {
106+ return fmt.Errorf("received nil response from server")
107+ }
108+
100109 var pushResponse common.PushResponse
101110 if err := json.Unmarshal(resp.Body, &pushResponse); err != nil {
102111 log.Error("Error parsing response", "error", err)
@@ -97,6 +97,15 @@ func pushImage(a *cli.App, reader io.Reader, imageName string) error {
97 defer cancel()97 defer cancel()
98 98
99 resp, err := chunkedClient.SendFileAsChunks(ctx, "/push/chunked", headers, imageReader, size, imageName)99 resp, err := chunkedClient.SendFileAsChunks(ctx, "/push/chunked", headers, imageReader, size, imageName)
100+ if err != nil {
101+ log.Error("Failed to send chunks", "error", err)
102+ return fmt.Errorf("failed to send chunks: %w", err)
103+ }
104+
105+ if resp == nil {
106+ return fmt.Errorf("received nil response from server")
107+ }
108+
100 var pushResponse common.PushResponse109 var pushResponse common.PushResponse
101 if err := json.Unmarshal(resp.Body, &pushResponse); err != nil {110 if err := json.Unmarshal(resp.Body, &pushResponse); err != nil {
102 log.Error("Error parsing response", "error", err)111 log.Error("Error parsing response", "error", err)

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 7

Tags 106

↑↓ moveenter openesc close