detached a7406bc

docs(app): fix stale docstring on cleanupOrphanDomainResources

commit
a7406bc4911792574f6c3a93e15a08f7655c4aab
author
brice · · 2026-03-25 18:35 UTC
parent
b035b02
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +4 -3
M internal/app/run.go +4 -3
@@ -682,9 +682,10 @@ func gcOrphanedPreviews(ctx context.Context, svc *services, previewConfig domain
682682 }
683683 }
684684
685-// cleanupOrphanDomainResources removes volumes, network, and route for an
686-// orphaned preview domain. Returns an error if any step fails so the caller
687-// can defer container removal until the next scan.
685+// cleanupOrphanDomainResources removes volumes and route for an orphaned
686+// preview domain. Network removal is handled separately in gcOrphanedPreviews
687+// after the container is removed. Returns an error if any step fails so the
688+// caller can defer container removal until the next scan.
688689 func cleanupOrphanDomainResources(ctx context.Context, svc *services, orphanDomain string) error {
689690 log := zerowrap.FromCtx(ctx)
690691 domainSanitized := strings.ReplaceAll(orphanDomain, ".", "-")
@@ -682,9 +682,10 @@ func gcOrphanedPreviews(ctx context.Context, svc *services, previewConfig domain
682 }682 }
683 }683 }
684 684
685-// cleanupOrphanDomainResources removes volumes, network, and route for an685+// cleanupOrphanDomainResources removes volumes and route for an orphaned
686-// orphaned preview domain. Returns an error if any step fails so the caller686+// preview domain. Network removal is handled separately in gcOrphanedPreviews
687-// can defer container removal until the next scan.687+// after the container is removed. Returns an error if any step fails so the
688+// caller can defer container removal until the next scan.
688 func cleanupOrphanDomainResources(ctx context.Context, svc *services, orphanDomain string) error {689 func cleanupOrphanDomainResources(ctx context.Context, svc *services, orphanDomain string) error {
689 log := zerowrap.FromCtx(ctx)690 log := zerowrap.FromCtx(ctx)
690 domainSanitized := strings.ReplaceAll(orphanDomain, ".", "-")691 domainSanitized := strings.ReplaceAll(orphanDomain, ".", "-")

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 7

Tags 106

↑↓ moveenter openesc close