fix: add waitForAttachmentReady mocks to attachment alias test
The TestDeployAttachedService_SetsAliasOnContainerConfig test was missing mock expectations for the readiness cascade (IsContainerRunning, GetContainerHealthStatus, GetContainerNetworkInfo) added in d56ae166.
- commit
- c151e5492bb9984c2ec44a4c33c761af7b15f3b4
- author
- brice · · 2026-03-23 19:13 UTC
- parent
- d56ae16
- signature
- GPG Verified
CD88F9E564E0102646FB6077A1A07C7C7C3E349D· arch-gpg Verified for the committer email
1 file · +7 -0
M internal/usecase/container/service_test.go +7 -0
| @@ -3965,6 +3965,13 @@ func TestDeployAttachedService_SetsAliasOnContainerConfig(t *testing.T) { | |||
| 3965 | 3965 | // StartContainer | |
| 3966 | 3966 | runtime.EXPECT().StartContainer(mock.Anything, "pg-container-1").Return(nil) | |
| 3967 | 3967 | ||
| 3968 | + | // waitForAttachmentReady: pollContainerRunning | |
| 3969 | + | runtime.EXPECT().IsContainerRunning(mock.Anything, "pg-container-1").Return(true, nil).Times(2) | |
| 3970 | + | // No Docker healthcheck | |
| 3971 | + | runtime.EXPECT().GetContainerHealthStatus(mock.Anything, "pg-container-1").Return("", false, nil) | |
| 3972 | + | // TCP probe: resolve endpoint fails -> falls back to delay | |
| 3973 | + | runtime.EXPECT().GetContainerNetworkInfo(mock.Anything, "pg-container-1").Return("", 0, errors.New("no network")) | |
| 3974 | + | ||
| 3968 | 3975 | err := svc.deployAttachedService(ctx, ownerDomain, serviceImage, networkName) | |
| 3969 | 3976 | require.NoError(t, err) | |
| 3970 | 3977 | ||
| @@ -3965,6 +3965,13 @@ func TestDeployAttachedService_SetsAliasOnContainerConfig(t *testing.T) { | |||||
| 3965 | // StartContainer | 3965 | // StartContainer | ||
| 3966 | runtime.EXPECT().StartContainer(mock.Anything, "pg-container-1").Return(nil) | 3966 | runtime.EXPECT().StartContainer(mock.Anything, "pg-container-1").Return(nil) | ||
| 3967 | 3967 | ||||
| 3968 | + | // waitForAttachmentReady: pollContainerRunning | |||
| 3969 | + | runtime.EXPECT().IsContainerRunning(mock.Anything, "pg-container-1").Return(true, nil).Times(2) | |||
| 3970 | + | // No Docker healthcheck | |||
| 3971 | + | runtime.EXPECT().GetContainerHealthStatus(mock.Anything, "pg-container-1").Return("", false, nil) | |||
| 3972 | + | // TCP probe: resolve endpoint fails -> falls back to delay | |||
| 3973 | + | runtime.EXPECT().GetContainerNetworkInfo(mock.Anything, "pg-container-1").Return("", 0, errors.New("no network")) | |||
| 3974 | + | ||||
| 3968 | err := svc.deployAttachedService(ctx, ownerDomain, serviceImage, networkName) | 3975 | err := svc.deployAttachedService(ctx, ownerDomain, serviceImage, networkName) | ||
| 3969 | require.NoError(t, err) | 3976 | require.NoError(t, err) | ||
| 3970 | 3977 | ||||