detached c151e54

fix: add waitForAttachmentReady mocks to attachment alias test

The TestDeployAttachedService_SetsAliasOnContainerConfig test was missing
mock expectations for the readiness cascade (IsContainerRunning,
GetContainerHealthStatus, GetContainerNetworkInfo) added in d56ae166.
commit
c151e5492bb9984c2ec44a4c33c761af7b15f3b4
author
brice · · 2026-03-23 19:13 UTC
parent
d56ae16
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +7 -0
M internal/usecase/container/service_test.go +7 -0
@@ -3965,6 +3965,13 @@ func TestDeployAttachedService_SetsAliasOnContainerConfig(t *testing.T) {
39653965 // StartContainer
39663966 runtime.EXPECT().StartContainer(mock.Anything, "pg-container-1").Return(nil)
39673967
3968+ // waitForAttachmentReady: pollContainerRunning
3969+ runtime.EXPECT().IsContainerRunning(mock.Anything, "pg-container-1").Return(true, nil).Times(2)
3970+ // No Docker healthcheck
3971+ runtime.EXPECT().GetContainerHealthStatus(mock.Anything, "pg-container-1").Return("", false, nil)
3972+ // TCP probe: resolve endpoint fails -> falls back to delay
3973+ runtime.EXPECT().GetContainerNetworkInfo(mock.Anything, "pg-container-1").Return("", 0, errors.New("no network"))
3974+
39683975 err := svc.deployAttachedService(ctx, ownerDomain, serviceImage, networkName)
39693976 require.NoError(t, err)
39703977
@@ -3965,6 +3965,13 @@ func TestDeployAttachedService_SetsAliasOnContainerConfig(t *testing.T) {
3965 // StartContainer3965 // StartContainer
3966 runtime.EXPECT().StartContainer(mock.Anything, "pg-container-1").Return(nil)3966 runtime.EXPECT().StartContainer(mock.Anything, "pg-container-1").Return(nil)
3967 3967
3968+ // waitForAttachmentReady: pollContainerRunning
3969+ runtime.EXPECT().IsContainerRunning(mock.Anything, "pg-container-1").Return(true, nil).Times(2)
3970+ // No Docker healthcheck
3971+ runtime.EXPECT().GetContainerHealthStatus(mock.Anything, "pg-container-1").Return("", false, nil)
3972+ // TCP probe: resolve endpoint fails -> falls back to delay
3973+ runtime.EXPECT().GetContainerNetworkInfo(mock.Anything, "pg-container-1").Return("", 0, errors.New("no network"))
3974+
3968 err := svc.deployAttachedService(ctx, ownerDomain, serviceImage, networkName)3975 err := svc.deployAttachedService(ctx, ownerDomain, serviceImage, networkName)
3969 require.NoError(t, err)3976 require.NoError(t, err)
3970 3977

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 7

Tags 106

↑↓ moveenter openesc close