detached c564572

fix: use SO_REUSEADDR in delayed listener test to prevent TIME_WAIT flakiness

commit
c564572dded72b89630b1bc5c4ddf4e067124b40
author
brice · · 2026-03-04 09:00 UTC
parent
9faaf17
signature
unsigned
1 file · +9 -1
M internal/usecase/container/readiness_test.go +9 -1
@@ -6,6 +6,7 @@ import (
66 "net/http"
77 "net/http/httptest"
88 "sync/atomic"
9+ "syscall"
910 "testing"
1011 "time"
1112
@@ -67,7 +68,14 @@ func TestTCPProbe_DelayedListener(t *testing.T) {
6768 // Re-open after 1 second
6869 go func() {
6970 time.Sleep(time.Second)
70- newLn, err := net.Listen("tcp", addr)
71+ lc := net.ListenConfig{
72+ Control: func(network, address string, c syscall.RawConn) error {
73+ return c.Control(func(fd uintptr) {
74+ _ = syscall.SetsockoptInt(int(fd), syscall.SOL_SOCKET, syscall.SO_REUSEADDR, 1)
75+ })
76+ },
77+ }
78+ newLn, err := lc.Listen(context.Background(), "tcp", addr)
7179 if err != nil {
7280 t.Logf("delayed listener failed to bind: %v", err)
7381 return
@@ -6,6 +6,7 @@ import (
6 "net/http"6 "net/http"
7 "net/http/httptest"7 "net/http/httptest"
8 "sync/atomic"8 "sync/atomic"
9+ "syscall"
9 "testing"10 "testing"
10 "time"11 "time"
11 12
@@ -67,7 +68,14 @@ func TestTCPProbe_DelayedListener(t *testing.T) {
67 // Re-open after 1 second68 // Re-open after 1 second
68 go func() {69 go func() {
69 time.Sleep(time.Second)70 time.Sleep(time.Second)
70- newLn, err := net.Listen("tcp", addr)71+ lc := net.ListenConfig{
72+ Control: func(network, address string, c syscall.RawConn) error {
73+ return c.Control(func(fd uintptr) {
74+ _ = syscall.SetsockoptInt(int(fd), syscall.SOL_SOCKET, syscall.SO_REUSEADDR, 1)
75+ })
76+ },
77+ }
78+ newLn, err := lc.Listen(context.Background(), "tcp", addr)
71 if err != nil {79 if err != nil {
72 t.Logf("delayed listener failed to bind: %v", err)80 t.Logf("delayed listener failed to bind: %v", err)
73 return81 return

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 7

Tags 106

↑↓ moveenter openesc close