skip to content

detached 89662fc

docs(ports): require explicit video geometry handling

commit: 89662fc4cf9991f71280059655b0554109cb861d
author: brice · 22d ago · 2026-09-30 08:17 UTC
committer: brice · 22d ago · 2026-09-30 14:48 UTC
parent: ad771a6
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +2 -0

M internal/ports/capture.go +2 -0


@@ -63,6 +63,8 @@ type VideoSettings struct {
63	63
64	64		// VideoWriter has one owner. Start fixes input geometry and reserves a new path.
65	65		// Start does not encode its frame; pass the first frame explicitly to Write.
	66	+	// Start rejects input/output geometry that its encoder cannot use; it must not
	67	+	// silently crop when zero output dimensions request source resolution.
66	68		// Write consumes borrowed pixels before returning; it must not queue frames.
67	69		// Close drains and finalizes the encoder with a bounded shutdown deadline.
68	70		// Abort interrupts pending writes and is safe concurrently with Write.


@@ -63,6 +63,8 @@ type VideoSettings struct {
63			63
64		// VideoWriter has one owner. Start fixes input geometry and reserves a new path.	64		// VideoWriter has one owner. Start fixes input geometry and reserves a new path.
65		// Start does not encode its frame; pass the first frame explicitly to Write.	65		// Start does not encode its frame; pass the first frame explicitly to Write.
			66	+	// Start rejects input/output geometry that its encoder cannot use; it must not
			67	+	// silently crop when zero output dimensions request source resolution.
66		// Write consumes borrowed pixels before returning; it must not queue frames.	68		// Write consumes borrowed pixels before returning; it must not queue frames.
67		// Close drains and finalizes the encoder with a bounded shutdown deadline.	69		// Close drains and finalizes the encoder with a bounded shutdown deadline.
68		// Abort interrupts pending writes and is safe concurrently with Write.	70		// Abort interrupts pending writes and is safe concurrently with Write.