detached 02f068b

perf(core): drop the duplicate stale-lane pass in dropStaleSpans

commit
02f068b689c9dcfaf8c1732f5f1cd3307b69a229
author
brice · · 2026-10-21 08:21 UTC
parent
09733c2
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +1 -13
M internal/core/layout_policy.go +1 -13
@@ -96,19 +96,7 @@ func (w *Workspace) dropStaleSpans() {
9696 if !stamped {
9797 return
9898 }
99- // The common case has only valid lanes: find out without allocating.
100- anyStale := false
101- for first := 0; first < len(w.Columns); {
102- _, last := w.laneBounds(w.laneOf(first))
103- if !w.validSpans(first, last) {
104- anyStale = true
105- break
106- }
107- first = last + 1
108- }
109- if !anyStale {
110- return
111- }
99+ // A nil stale slice does not allocate, so valid lanes cost nothing here.
112100 var stale []int
113101 for first := 0; first < len(w.Columns); {
114102 _, last := w.laneBounds(w.laneOf(first))
@@ -96,19 +96,7 @@ func (w *Workspace) dropStaleSpans() {
96 if !stamped {96 if !stamped {
97 return97 return
98 }98 }
99- // The common case has only valid lanes: find out without allocating.99+ // A nil stale slice does not allocate, so valid lanes cost nothing here.
100- anyStale := false
101- for first := 0; first < len(w.Columns); {
102- _, last := w.laneBounds(w.laneOf(first))
103- if !w.validSpans(first, last) {
104- anyStale = true
105- break
106- }
107- first = last + 1
108- }
109- if !anyStale {
110- return
111- }
112 var stale []int100 var stale []int
113 for first := 0; first < len(w.Columns); {101 for first := 0; first < len(w.Columns); {
114 _, last := w.laneBounds(w.laneOf(first))102 _, last := w.laneBounds(w.laneOf(first))

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 24

Tags 10

↑↓ moveenter openesc close