detached 052b0e6

test(core): cover the fullscreen latch moving with a stacked column

commit
052b0e64d3ba24ed734d940998b33f8b8d5f5a85
author
brice · · 2026-10-02 15:49 UTC
parent
c2347ef
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +9 -10
M internal/core/fullscreen_left_test.go +9 -10
@@ -86,18 +86,17 @@ func TestLeftFullscreenTaskbar(t *testing.T) {
8686 }
8787 }
8888
89-// A latched window moved away with its column drops the latch.
89+// A latched window moved away with its column, which another window of
90+// it has the focus of, drops the latch.
9091 func TestLeftFullscreenColumnMoved(t *testing.T) {
91- m := monitor()
92- m.AddWindow(1)
93- m.AddWindow(2)
94- w := m.Current()
95- m.ToggleFullscreen()
96- w.Activate(1)
92+ w := cols(OverflowScroll, 2, 0, []WindowID{2, 3}, []WindowID{1})
9793 w.FocusID(2)
98- w.left = 2 // as if moved before the latch settled
99- m.MoveToWorkspace(1, true)
100- if w.left != 0 {
94+ w.fullscreen = 2
95+ w.Activate(3)
96+ if w.left != 2 {
97+ t.Fatalf("latch %d", w.left)
98+ }
99+ if _, ok := w.takeColumn(); !ok || w.left != 0 {
101100 t.Fatalf("left %d", w.left)
102101 }
103102 }
@@ -86,18 +86,17 @@ func TestLeftFullscreenTaskbar(t *testing.T) {
86 }86 }
87 }87 }
88 88
89-// A latched window moved away with its column drops the latch.89+// A latched window moved away with its column, which another window of
90+// it has the focus of, drops the latch.
90 func TestLeftFullscreenColumnMoved(t *testing.T) {91 func TestLeftFullscreenColumnMoved(t *testing.T) {
91- m := monitor()92+ w := cols(OverflowScroll, 2, 0, []WindowID{2, 3}, []WindowID{1})
92- m.AddWindow(1)
93- m.AddWindow(2)
94- w := m.Current()
95- m.ToggleFullscreen()
96- w.Activate(1)
97 w.FocusID(2)93 w.FocusID(2)
98- w.left = 2 // as if moved before the latch settled94+ w.fullscreen = 2
99- m.MoveToWorkspace(1, true)95+ w.Activate(3)
100- if w.left != 0 {96+ if w.left != 2 {
97+ t.Fatalf("latch %d", w.left)
98+ }
99+ if _, ok := w.takeColumn(); !ok || w.left != 0 {
101 t.Fatalf("left %d", w.left)100 t.Fatalf("left %d", w.left)
102 }101 }
103 }102 }

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 25

Tags 10

↑↓ moveenter openesc close