detached 0640328

fix(drm): report leaving only for a kept window the scene draws

commit
0640328c665f3e6634c45ec11aed12f37b207ae7
author
brice · · 2026-10-08 19:49 UTC
parent
f958185
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +1 -1
M internal/adapters/drm/overlay.go +1 -1
@@ -116,7 +116,7 @@ func overlayCandidate(s ports.Scene, surfaces map[ports.WindowID]ports.SurfaceCo
116116 // The one window that could have gone on the plane fades out
117117 // after its close: composed from its kept content.
118118 for i := range s.Windows {
119- if w := &s.Windows[i]; !w.Hidden && w.Rect.W > 0 && w.Rect.H > 0 && kept(w.ID) {
119+ if w := &s.Windows[i]; s.Draws(*w) && kept(w.ID) {
120120 return ports.SceneWindow{}, ports.SurfaceContent{}, colorBypass, "leaving"
121121 }
122122 }
@@ -116,7 +116,7 @@ func overlayCandidate(s ports.Scene, surfaces map[ports.WindowID]ports.SurfaceCo
116 // The one window that could have gone on the plane fades out116 // The one window that could have gone on the plane fades out
117 // after its close: composed from its kept content.117 // after its close: composed from its kept content.
118 for i := range s.Windows {118 for i := range s.Windows {
119- if w := &s.Windows[i]; !w.Hidden && w.Rect.W > 0 && w.Rect.H > 0 && kept(w.ID) {119+ if w := &s.Windows[i]; s.Draws(*w) && kept(w.ID) {
120 return ports.SceneWindow{}, ports.SurfaceContent{}, colorBypass, "leaving"120 return ports.SceneWindow{}, ports.SurfaceContent{}, colorBypass, "leaving"
121 }121 }
122 }122 }

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 26

Tags 10

↑↓ moveenter openesc close