detached 14b0437

perf(core): keep the focus flash sample on the stack

commit
14b0437349125f6c54b27a45d6063c0de8bd1145
author
brice · · 2026-10-21 08:06 UTC
committer
brice · · 2026-10-21 08:07 UTC
parent
024f793
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +4 -1
Unified
UnifiedSplit
M internal/core/flash.go +4 -1
@@ -196,7 +196,10 @@ func (c *Core) flashFor(sc *screen) *ports.FocusFlash {
196196 }
197197 sample := ports.FocusFlash{Rect: f.rect, Width: c.cfg.Focus.FlashWidth, Radius: f.radius, Color: color, Alpha: f.value}
198198 if f.published == nil || *f.published != sample {
199- f.published = &sample
199+ // Allocate only for a changed sample; sample itself stays on the stack.
200+ published := new(ports.FocusFlash)
201+ *published = sample
202+ f.published = published
200203 }
201204 return f.published
202205 }
@@ -196,7 +196,10 @@ func (c *Core) flashFor(sc *screen) *ports.FocusFlash {
196 }196 }
197 sample := ports.FocusFlash{Rect: f.rect, Width: c.cfg.Focus.FlashWidth, Radius: f.radius, Color: color, Alpha: f.value}197 sample := ports.FocusFlash{Rect: f.rect, Width: c.cfg.Focus.FlashWidth, Radius: f.radius, Color: color, Alpha: f.value}
198 if f.published == nil || *f.published != sample {198 if f.published == nil || *f.published != sample {
199- f.published = &sample199+ // Allocate only for a changed sample; sample itself stays on the stack.
200+ published := new(ports.FocusFlash)
201+ *published = sample
202+ f.published = published
200 }203 }
201 return f.published204 return f.published
202 }205 }

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 25

Tags 10

↑↓ moveenter openesc close