detached 7ad9c3b

test(wayland): wait for each focus step in TestActivationPressSerial

The focus starts at 0, so waiting once for focus 0 could pass before
FocusWindow{ID} applied; the client then got the focus back and its
token stayed valid.
commit
7ad9c3b77fa1fc515187dc500b1e0aaaf9b3013b
author
brice · · 2026-10-08 08:42 UTC
committer
brice · · 2026-10-08 09:59 UTC
parent
4fd770d
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +4 -1
Unified
UnifiedSplit
M internal/adapters/wayland/activation_test.go +4 -1
@@ -163,8 +163,11 @@ func TestActivationPressSerial(t *testing.T) {
163163 token = newToken(t, c, manager, serial+100, seat)
164164 requestProtocol(t, c, manager, xdgactivation.ActivationV1RequestActivate, token, surf)
165165 noActivation(t, c, events)
166- // The focus moved after the press: stale.
166+ // The focus moved after the press: stale. Wait for each step: the
167+ // focus starts at 0, so a single wait could pass before either
168+ // command applies and leave the client focused.
167169 commands <- ports.FocusWindow{ID: w.ID}
170+ waitFocus(t, s, w.ID)
168171 commands <- ports.FocusWindow{}
169172 waitFocus(t, s, 0)
170173 token = newToken(t, c, manager, serial, seat)
@@ -163,8 +163,11 @@ func TestActivationPressSerial(t *testing.T) {
163 token = newToken(t, c, manager, serial+100, seat)163 token = newToken(t, c, manager, serial+100, seat)
164 requestProtocol(t, c, manager, xdgactivation.ActivationV1RequestActivate, token, surf)164 requestProtocol(t, c, manager, xdgactivation.ActivationV1RequestActivate, token, surf)
165 noActivation(t, c, events)165 noActivation(t, c, events)
166- // The focus moved after the press: stale.166+ // The focus moved after the press: stale. Wait for each step: the
167+ // focus starts at 0, so a single wait could pass before either
168+ // command applies and leave the client focused.
167 commands <- ports.FocusWindow{ID: w.ID}169 commands <- ports.FocusWindow{ID: w.ID}
170+ waitFocus(t, s, w.ID)
168 commands <- ports.FocusWindow{}171 commands <- ports.FocusWindow{}
169 waitFocus(t, s, 0)172 waitFocus(t, s, 0)
170 token = newToken(t, c, manager, serial, seat)173 token = newToken(t, c, manager, serial, seat)

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 26

Tags 10

↑↓ moveenter openesc close