detached c64260b

test(app): accept cancellation during session lock teardown

commit
c64260b018f2a81c31292054ab41102b41d60410
author
brice · · 2026-10-21 15:10 UTC
parent
716a579
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
checks
2/2
1 file · +4 -1
M internal/app/session_lock_test.go +4 -1
@@ -3,6 +3,7 @@ package app
33 import (
44 "bytes"
55 "context"
6+ "errors"
67 "io"
78 "os"
89 "path/filepath"
@@ -52,7 +53,9 @@ func TestHeadlessSessionLockEndToEnd(t *testing.T) {
5253 }
5354 select {
5455 case err := <-done:
55- if err != nil {
56+ // We canceled Run above. Workers may report that cancellation
57+ // during shutdown; it is not a failed session-lock assertion.
58+ if err != nil && !errors.Is(err, context.Canceled) {
5659 t.Errorf("Run: %v", err)
5760 }
5861 case <-time.After(3 * time.Second):
@@ -3,6 +3,7 @@ package app
3 import (3 import (
4 "bytes"4 "bytes"
5 "context"5 "context"
6+ "errors"
6 "io"7 "io"
7 "os"8 "os"
8 "path/filepath"9 "path/filepath"
@@ -52,7 +53,9 @@ func TestHeadlessSessionLockEndToEnd(t *testing.T) {
52 }53 }
53 select {54 select {
54 case err := <-done:55 case err := <-done:
55- if err != nil {56+ // We canceled Run above. Workers may report that cancellation
57+ // during shutdown; it is not a failed session-lock assertion.
58+ if err != nil && !errors.Is(err, context.Canceled) {
56 t.Errorf("Run: %v", err)59 t.Errorf("Run: %v", err)
57 }60 }
58 case <-time.After(3 * time.Second):61 case <-time.After(3 * time.Second):

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 25

Tags 10

↑↓ moveenter openesc close