refactor(core): remove unused border resize start state
- commit
- d02924590e31fdf56432eca0931bd292f185b790
- author
- brice · · 2026-10-21 05:46 UTC
- committer
- brice · · 2026-10-21 07:11 UTC
- parent
- d72b69d
- signature
- GPG Verified
CD88F9E564E0102646FB6077A1A07C7C7C3E349D· arch-gpg Verified for the committer email
2 files · +8 -2
M internal/core/border_resize.go +1 -2
| @@ -15,11 +15,10 @@ type borderResize struct { | |||
| 15 | 15 | border border | |
| 16 | 16 | btn uint32 | |
| 17 | 17 | saved []Column | |
| 18 | - | start [2]float64 | |
| 19 | 18 | } | |
| 20 | 19 | ||
| 21 | 20 | func newBorderResize(c *Core, s *screen, w *Workspace, b border, button uint32) *borderResize { | |
| 22 | - | g := &borderResize{core: c, screen: s, ws: w, border: b, btn: button, start: [2]float64{c.cursorX, c.cursorY}, saved: slices.Clone(w.Columns)} | |
| 21 | + | g := &borderResize{core: c, screen: s, ws: w, border: b, btn: button, saved: slices.Clone(w.Columns)} | |
| 23 | 22 | for i := range g.saved { | |
| 24 | 23 | g.saved[i].Windows = slices.Clone(g.saved[i].Windows) | |
| 25 | 24 | g.saved[i].Shares = slices.Clone(g.saved[i].Shares) | |
| @@ -15,11 +15,10 @@ type borderResize struct { | |||||
| 15 | border border | 15 | border border | ||
| 16 | btn uint32 | 16 | btn uint32 | ||
| 17 | saved []Column | 17 | saved []Column | ||
| 18 | - | start [2]float64 | |||
| 19 | } | 18 | } | ||
| 20 | 19 | ||||
| 21 | func newBorderResize(c *Core, s *screen, w *Workspace, b border, button uint32) *borderResize { | 20 | func newBorderResize(c *Core, s *screen, w *Workspace, b border, button uint32) *borderResize { | ||
| 22 | - | g := &borderResize{core: c, screen: s, ws: w, border: b, btn: button, start: [2]float64{c.cursorX, c.cursorY}, saved: slices.Clone(w.Columns)} | 21 | + | g := &borderResize{core: c, screen: s, ws: w, border: b, btn: button, saved: slices.Clone(w.Columns)} |
| 23 | for i := range g.saved { | 22 | for i := range g.saved { | ||
| 24 | g.saved[i].Windows = slices.Clone(g.saved[i].Windows) | 23 | g.saved[i].Windows = slices.Clone(g.saved[i].Windows) | ||
| 25 | g.saved[i].Shares = slices.Clone(g.saved[i].Shares) | 24 | g.saved[i].Shares = slices.Clone(g.saved[i].Shares) | ||
M internal/core/pointergrab_test.go +7 -0
| @@ -2,6 +2,7 @@ package core | |||
| 2 | 2 | ||
| 3 | 3 | import ( | |
| 4 | 4 | "context" | |
| 5 | + | "reflect" | |
| 5 | 6 | "slices" | |
| 6 | 7 | "testing" | |
| 7 | 8 | "time" | |
| @@ -289,3 +290,9 @@ func TestBorderGrabFullscreenPublish(t *testing.T) { | |||
| 289 | 290 | t.Fatal("release still held") | |
| 290 | 291 | } | |
| 291 | 292 | } | |
| 293 | + | ||
| 294 | + | func TestBorderResizeHasNoUnusedStart(t *testing.T) { | |
| 295 | + | if _, ok := reflect.TypeFor[borderResize]().FieldByName("start"); ok { | |
| 296 | + | t.Fatal("borderResize retains unused start state") | |
| 297 | + | } | |
| 298 | + | } | |
| @@ -2,6 +2,7 @@ package core | |||||
| 2 | 2 | ||||
| 3 | import ( | 3 | import ( | ||
| 4 | "context" | 4 | "context" | ||
| 5 | + | "reflect" | |||
| 5 | "slices" | 6 | "slices" | ||
| 6 | "testing" | 7 | "testing" | ||
| 7 | "time" | 8 | "time" | ||
| @@ -289,3 +290,9 @@ func TestBorderGrabFullscreenPublish(t *testing.T) { | |||||
| 289 | t.Fatal("release still held") | 290 | t.Fatal("release still held") | ||
| 290 | } | 291 | } | ||
| 291 | } | 292 | } | ||
| 293 | + | ||||
| 294 | + | func TestBorderResizeHasNoUnusedStart(t *testing.T) { | |||
| 295 | + | if _, ok := reflect.TypeFor[borderResize]().FieldByName("start"); ok { | |||
| 296 | + | t.Fatal("borderResize retains unused start state") | |||
| 297 | + | } | |||
| 298 | + | } | |||