detached ca9d24a

refactor: Simplify cleanup and event listener management in layout

commit
ca9d24adb255378e3c25780d157164e7f204541a
author
Kit · · 2025-02-14 16:52 UTC
parent
67ec9e6
signature
SSH UnverifiedSHA256:H91DFuEG4jpk5edzLA4aUKkpv4zv9Q339ipRmkph6Tk The key is unknown
1 file · +0 -11
M src/routes/+layout.svelte +0 -11
@@ -93,23 +93,12 @@
9393 // Add visibility change listener
9494 document.addEventListener('visibilitychange', handleVisibilityChange);
9595
96- // Add beforeunload listener
97- window.addEventListener('beforeunload', cleanup);
98-
9996 // Cleanup on unmount
10097 return () => {
10198 window.removeEventListener('beforeunload', cleanup);
102- cleanup();
10399 };
104100 });
105101
106- // Additional safety net for clean navigation within the app
107- onDestroy(() => {
108- if (!browser) return;
109- console.debug('Component being destroyed - Running cleanup');
110- window.removeEventListener('beforeunload', cleanup);
111- cleanup();
112- });
113102
114103 $effect(() => {
115104 if (!browser) return;
@@ -93,23 +93,12 @@
93 // Add visibility change listener93 // Add visibility change listener
94 document.addEventListener('visibilitychange', handleVisibilityChange);94 document.addEventListener('visibilitychange', handleVisibilityChange);
95 95
96- // Add beforeunload listener
97- window.addEventListener('beforeunload', cleanup);
98-
99 // Cleanup on unmount96 // Cleanup on unmount
100 return () => {97 return () => {
101 window.removeEventListener('beforeunload', cleanup);98 window.removeEventListener('beforeunload', cleanup);
102- cleanup();
103 };99 };
104 });100 });
105 101
106- // Additional safety net for clean navigation within the app
107- onDestroy(() => {
108- if (!browser) return;
109- console.debug('Component being destroyed - Running cleanup');
110- window.removeEventListener('beforeunload', cleanup);
111- cleanup();
112- });
113 102
114 $effect(() => {103 $effect(() => {
115 if (!browser) return;104 if (!browser) return;

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 3

Tags 9

↑↓ moveenter openesc close