detached 1556133

test(server): compare peer credentials with effective IDs

commit
155613350d002aca2fc4b3a7039bfa8c7cb51e01
author
brice · · 2026-09-30 14:38 UTC
committer
brice · · 2026-09-30 14:46 UTC
parent
4b5fcbc
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +2 -2
Unified
UnifiedSplit
M server/hotpath_test.go +2 -2
@@ -157,8 +157,8 @@ func TestClientCredentials(t *testing.T) {
157157 if err != nil {
158158 t.Fatal(err)
159159 }
160- if got.PID != os.Getpid() || got.UID != uint32(os.Getuid()) || got.GID != uint32(os.Getgid()) || pid != got.PID {
161- t.Fatalf("credentials %+v pid %d, want pid=%d uid=%d gid=%d", got, pid, os.Getpid(), os.Getuid(), os.Getgid())
160+ if got.PID != os.Getpid() || got.UID != uint32(os.Geteuid()) || got.GID != uint32(os.Getegid()) || pid != got.PID {
161+ t.Fatalf("credentials %+v pid %d, want pid=%d uid=%d gid=%d", got, pid, os.Getpid(), os.Geteuid(), os.Getegid())
162162 }
163163 if zerr == nil || zero != (Credentials{}) || (Client{}).PID() != 0 {
164164 t.Fatalf("invalid client: %+v, %v", zero, zerr)
@@ -157,8 +157,8 @@ func TestClientCredentials(t *testing.T) {
157 if err != nil {157 if err != nil {
158 t.Fatal(err)158 t.Fatal(err)
159 }159 }
160- if got.PID != os.Getpid() || got.UID != uint32(os.Getuid()) || got.GID != uint32(os.Getgid()) || pid != got.PID {160+ if got.PID != os.Getpid() || got.UID != uint32(os.Geteuid()) || got.GID != uint32(os.Getegid()) || pid != got.PID {
161- t.Fatalf("credentials %+v pid %d, want pid=%d uid=%d gid=%d", got, pid, os.Getpid(), os.Getuid(), os.Getgid())161+ t.Fatalf("credentials %+v pid %d, want pid=%d uid=%d gid=%d", got, pid, os.Getpid(), os.Geteuid(), os.Getegid())
162 }162 }
163 if zerr == nil || zero != (Credentials{}) || (Client{}).PID() != 0 {163 if zerr == nil || zero != (Credentials{}) || (Client{}).PID() != 0 {
164 t.Fatalf("invalid client: %+v, %v", zero, zerr)164 t.Fatalf("invalid client: %+v, %v", zero, zerr)

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 1

Tags 14

↑↓ moveenter openesc close