detached 07c3f73

fix(core): recover from purego panics during function registration

PuregoSafeRegister now recovers from panics thrown by purego.RegisterFunc
(e.g. 'too many stack arguments' for functions with >15 params like
g_spawn_async_with_pipes_and_fds). The function pointer stays nil and
will panic only if actually called, rather than crashing at init time.
commit
07c3f738f24e08e5622c8db24ffe129792386a85
author
brice · · 2026-03-19 18:26 UTC
committer
brice · · 2026-03-19 18:28 UTC
parent
53c483e
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +10 -2
M internal/core/core.go +10 -2
@@ -20,13 +20,21 @@ func PuregoSafeRegister(fptr interface{}, libs []uintptr, name string) {
2020 for _, lib := range libs {
2121 sym, err := purego.Dlsym(lib, name)
2222 if err == nil {
23- purego.RegisterFunc(fptr, sym)
24-
23+ registerFuncSafe(fptr, sym)
2524 return
2625 }
2726 }
2827 }
2928
29+// registerFuncSafe wraps purego.RegisterFunc with panic recovery for
30+// functions whose signatures exceed upstream purego limits (e.g. "too
31+// many stack arguments"). The function pointer stays nil and will
32+// panic only if actually called.
33+func registerFuncSafe(fptr interface{}, sym uintptr) {
34+ defer func() { recover() }()
35+ purego.RegisterFunc(fptr, sym)
36+}
37+
3038 // paths to where the shared object files should be located
3139 // this is unique per architecture
3240 // Debian/Ubuntu has it split into specific arch folder, Fedora is just /usr/lib64
@@ -20,13 +20,21 @@ func PuregoSafeRegister(fptr interface{}, libs []uintptr, name string) {
20 for _, lib := range libs {20 for _, lib := range libs {
21 sym, err := purego.Dlsym(lib, name)21 sym, err := purego.Dlsym(lib, name)
22 if err == nil {22 if err == nil {
23- purego.RegisterFunc(fptr, sym)23+ registerFuncSafe(fptr, sym)
24-
25 return24 return
26 }25 }
27 }26 }
28 }27 }
29 28
29+// registerFuncSafe wraps purego.RegisterFunc with panic recovery for
30+// functions whose signatures exceed upstream purego limits (e.g. "too
31+// many stack arguments"). The function pointer stays nil and will
32+// panic only if actually called.
33+func registerFuncSafe(fptr interface{}, sym uintptr) {
34+ defer func() { recover() }()
35+ purego.RegisterFunc(fptr, sym)
36+}
37+
30 // paths to where the shared object files should be located38 // paths to where the shared object files should be located
31 // this is unique per architecture39 // this is unique per architecture
32 // Debian/Ubuntu has it split into specific arch folder, Fedora is just /usr/lib6440 // Debian/Ubuntu has it split into specific arch folder, Fedora is just /usr/lib64

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 1

Tags 102

↑↓ moveenter openesc close